Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-24 13:21:05 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1454912 - remove spurious generated files; r=nalexander

Browse Source 
These GENERATED_FILES appear to be leftover from when parts
widget/android/bindings were still in Makefile.in, and are now redundant
with the GENERATED_FILES tuple in this moz.build file.

MozReview-Commit-ID: CxVDJQNCWeG

--HG--
extra : rebase_source : 9bed76436a458b680695ccc7ff9e19dc8497a80d
This commit is contained in:
Mike Shal 2018-05-09 16:15:03 -04:00
parent ae545cfb52
commit d46902e5dc
1 changed files with 0 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
widget/android/bindings/moz.build
View File

@ -24,17 +24,6 @@ SOURCES += ['!%s.cpp' % stem for stem in generated]
EXPORTS += ['!%s.h' % stem for stem in generated]
# There is an unfortunate race condition when using generated SOURCES and
# pattern rules (see Makefile.in) that manifests itself as a VPATH resolution
# conflict: MediaCodec.o looks for MediaCodec.cpp and $(CURDIR)/MediaCodec.cpp,
# and the pattern rule is matched but doesn't resolve both sources, causing a
# failure. Adding the SOURCES to GENERATED_FILES causes the sources
# to be built at export time, which is before MediaCodec.o needs them; and by
# the time MediaCodec.o is built, the source is in place and the VPATH
# resolution works as expected.
GENERATED_FILES += ['%s.h' % stem for stem in generated]
# The recursive make backend treats the first output specially: it's passed as
# an open FileAvoidWrite to the invoked script. That doesn't work well with
# the Gradle task that generates all of the outputs, so we add a dummy first