Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-25 20:01:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 471950 Improve bloatdiff.pl error handling - improve tinderbox integration, and do not error when two logs have the same bloat data. r=nthomas,dbaron

Browse Source
This commit is contained in:
Mark Banner 2009-02-17 08:44:51 +00:00
parent 3f39b39a8b
commit d4946ea882
1 changed files with 12 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
tools/rb/bloatdiff.pl
View File

@ -27,7 +27,7 @@ $NEWFILE = $ARGV[1];
if (!$OLDFILE or
! -e $OLDFILE or
-z $OLDFILE) {
print "\nERROR - Previous log file not specified, does not exist, or is empty.\n\n";
print "\nError: Previous log file not specified, does not exist, or is empty.\n\n";
&usage();
exit 1;
}
@ -35,7 +35,7 @@ if (!$OLDFILE or
if (!$NEWFILE or
! -e $NEWFILE or
-z $NEWFILE) {
print "\nERROR - Current log file not specified, does not exist, or is empty.\n\n";
print "\nError: Current log file not specified, does not exist, or is empty.\n\n";
&usage();
exit 1;
}
@ -183,14 +183,16 @@ print "Previous file: $OLDFILE\n";
print "----------------------------------------------leaks------leaks%------bloat------bloat%\n";
if (! $newMap{"TOTAL"} or
! $newMap{"TOTAL"}{bloat} or
! $newMap{"TOTAL"}{bloatPercent}) {
# it's OK if leaked or leakPercent are 0 (in fact, that would be good)
print "\nERROR - unable to calculate bloat/leak data.\n\n";
print "HINT - Did your test run complete successfully?\n";
print "HINT - Are you pointing at the right log files?\n\n";
&usage();
exit 1;
! $newMap{"TOTAL"}{bloat}) {
# It's OK if leaked or leakPercent are 0 (in fact, that would be good).
# If bloatPercent is zero, it is also OK, because we may have just had
# two runs exactly the same or with no new bloat.
print "\nError: unable to calculate bloat/leak data.\n";
print "There is no data present.\n\n";
print "HINT - Did your test run complete successfully?\n";
print "HINT - Are you pointing at the right log files?\n\n";
&usage();
exit 1;
}
printf "%-40s %10s %10.2f%% %10s %10.2f%%\n",