Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-29 07:42:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix test_xulbrowser_plugin_visibility to be more robust and use fewer magic timeouts, review note from bug 583109 comment 52.

Browse Source
This commit is contained in:
Benjamin Smedberg 2010-11-10 08:35:46 -05:00
parent 7cbfb897c8
commit d55dd1e25b
1 changed files with 18 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
modules/plugin/test/mochitest/xulbrowser_plugin_visibility.xul
View File

@ -98,6 +98,7 @@
}
clearInterval(paintInterval);
ok(true, "Plugin in tab 1 should be visible.");
is(plugin1.getPaintCount(), 1 * doubleForDoublePass(),
"Plugin in tab 1 should have painted once.");
@ -107,18 +108,30 @@
"Plugin in tab 2 should not have painted.");
tabbox.selectedIndex = 1;
setTimeout(part2, 100);
paintGiveUp = Date.now() + kTimeout;
paintInterval = setInterval(part2, 100);
}
function part2() {
if (!plugin2.isVisible()) {
if (Date.now() < paintGiveUp)
return;
ok(false, "Plugin in tab 2 never became visible.");
done();
return;
}
clearInterval(paintInterval);
ok(true, "Plugin in tab 2 became visible.");
is(plugin2.getPaintCount(), 1 * doubleForDoublePass(),
"Plugin in tab 2 should have painted once.");
ok(!plugin1.isVisible(), "Plugin in tab 1 should have become invisible.");
is(plugin1.getPaintCount(), 1 * doubleForDoublePass(),
"Plugin in tab 1 should not have repainted.");
ok(plugin2.isVisible(), "Plugin in tab 2 should have become visible.");
is(plugin2.getPaintCount(), 1 * doubleForDoublePass(),
"Plugin in tab 2 should have painted once.");
// Setcolor invalidates
plugin1.setColor('FF00FF00');
plugin2.setColor('FF00FF00');