Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D30883

--HG--
extra : moz-landing-system : lando

accessible/html/HTMLFormControlAccessible.cpp

@@ -338,7 +338,8 @@ uint64_t HTMLTextFieldAccessible::NativeState() const {
     return state | states::SUPPORTS_AUTOCOMPLETION | states::HASPOPUP;
 
   // Ordinal XUL textboxes don't support autocomplete.
-  if (!BindingOrWidgetParent() && Preferences::GetBool("browser.formfill.enable")) {
+  if (!BindingOrWidgetParent() &&
+      Preferences::GetBool("browser.formfill.enable")) {
     // Check to see if autocompletion is allowed on this input. We don't expose
     // it for password fields even though the entire password can be remembered
     // for a page if the user asks it to be. However, the kind of autocomplete

accessible/html/HTMLFormControlAccessible.h

@@ -102,7 +102,7 @@ class HTMLTextFieldAccessible final : public HyperTextAccessibleWrap {
    * HTML:input@type="number".
    */
   nsIContent* BindingOrWidgetParent() const {
-    nsIContent * el = mContent->GetBindingParent();
+    nsIContent* el = mContent->GetBindingParent();
     if (el) {
       return el;
     }

browser/app/winlauncher/LauncherProcessWin.cpp

@@ -176,11 +176,11 @@ static mozilla::Maybe<bool> RunAsLauncherProcess(int& argc, wchar_t** argv) {
   bool runAsLauncher = DoLauncherProcessChecks(argc, argv);
 
 #if defined(MOZ_LAUNCHER_PROCESS)
-  bool forceLauncher = runAsLauncher &&
+  bool forceLauncher =
+      runAsLauncher &&
       mozilla::CheckArg(argc, argv, L"force-launcher",
                         static_cast<const wchar_t**>(nullptr),
-                                         mozilla::CheckArgFlag::RemoveArg) ==
+                        mozilla::CheckArgFlag::RemoveArg) == mozilla::ARG_FOUND;
-                       mozilla::ARG_FOUND;
 
   mozilla::LauncherRegistryInfo::ProcessType desiredType =
       runAsLauncher ? mozilla::LauncherRegistryInfo::ProcessType::Launcher

caps/ContentPrincipal.cpp

@@ -49,8 +49,7 @@ NS_IMPL_CI_INTERFACE_GETTER(ContentPrincipal, nsIPrincipal, nsISerializable)
 
 ContentPrincipal::ContentPrincipal() : BasePrincipal(eCodebasePrincipal) {}
 
-ContentPrincipal::~ContentPrincipal() {
+ContentPrincipal::~ContentPrincipal() {}
-}
 
 nsresult ContentPrincipal::Init(nsIURI* aCodebase,
                                 const OriginAttributes& aOriginAttributes,

docshell/base/BrowsingContext.cpp

@@ -810,8 +810,8 @@ void BrowsingContext::Transaction::Apply(BrowsingContext* aBrowsingContext,
 }
 
 BrowsingContext::IPCInitializer BrowsingContext::GetIPCInitializer() {
-  MOZ_ASSERT(
+  MOZ_ASSERT(!mozilla::Preferences::GetBool(
-      !mozilla::Preferences::GetBool("fission.preserve_browsing_contexts", false) ||
+                 "fission.preserve_browsing_contexts", false) ||
              IsContent());
 
   IPCInitializer init;

dom/base/ResizeObserver.cpp

@@ -280,7 +280,7 @@ void ResizeObserverEntry::SetContentRectAndSize(const nsSize& aSize) {
   nsIFrame* frame = mTarget->GetPrimaryFrame();
 
   // 1. Update mContentRect.
-  nsMargin padding = frame ? frame->GetUsedPadding(): nsMargin();
+  nsMargin padding = frame ? frame->GetUsedPadding() : nsMargin();
   // Per the spec, we need to use the top-left padding offset as the origin of
   // our contentRect.
   nsRect rect(nsPoint(padding.left, padding.top), aSize);

dom/base/ResizeObserverController.cpp

@@ -59,7 +59,8 @@ void ResizeObserverNotificationHelper::Unregister() {
   }
 
   nsRefreshDriver* refreshDriver = GetRefreshDriver();
-  MOZ_RELEASE_ASSERT(refreshDriver,
+  MOZ_RELEASE_ASSERT(
+      refreshDriver,
       "We should not leave a dangling reference to the observer around");
 
   bool rv = refreshDriver->RemoveRefreshObserver(this, FlushType::Display);

dom/base/SerializedStackHolder.cpp

@@ -15,7 +15,8 @@ namespace dom {
 SerializedStackHolder::SerializedStackHolder()
     : mHolder(StructuredCloneHolder::CloningSupported,
               StructuredCloneHolder::TransferringNotSupported,
-            StructuredCloneHolder::StructuredCloneScope::SameProcessDifferentThread) {}
+              StructuredCloneHolder::StructuredCloneScope::
+                  SameProcessDifferentThread) {}
 
 void SerializedStackHolder::WriteStack(JSContext* aCx,
                                        JS::HandleObject aStack) {
@@ -37,8 +38,8 @@ void SerializedStackHolder::SerializeWorkerStack(JSContext* aCx,
                                                  JS::HandleObject aStack) {
   MOZ_ASSERT(aWorkerPrivate->IsOnCurrentThread());
 
-  RefPtr<StrongWorkerRef> workerRef = StrongWorkerRef::Create(
+  RefPtr<StrongWorkerRef> workerRef =
-      aWorkerPrivate, "WorkerErrorReport");
+      StrongWorkerRef::Create(aWorkerPrivate, "WorkerErrorReport");
   if (workerRef) {
     mWorkerRef = new ThreadSafeWorkerRef(workerRef);
   } else {
@@ -78,8 +79,7 @@ JSObject* SerializedStackHolder::ReadStack(JSContext* aCx) {
   }
 
   JS::RootedValue stackValue(aCx);
-  mHolder.Read(xpc::CurrentNativeGlobal(aCx), aCx, &stackValue,
+  mHolder.Read(xpc::CurrentNativeGlobal(aCx), aCx, &stackValue, IgnoreErrors());
-               IgnoreErrors());
   return stackValue.isObject() ? &stackValue.toObject() : nullptr;
 }
 
@@ -92,8 +92,8 @@ UniquePtr<SerializedStackHolder> GetCurrentStackForNetMonitor(JSContext* aCx) {
   return stack;
 }
 
-void NotifyNetworkMonitorAlternateStack(nsISupports* aChannel,
+void NotifyNetworkMonitorAlternateStack(
-                                        UniquePtr<SerializedStackHolder> aStackHolder) {
+    nsISupports* aChannel, UniquePtr<SerializedStackHolder> aStackHolder) {
   if (!aStackHolder) {
     return;
   }
@@ -121,8 +121,8 @@ void ConvertSerializedStackToJSON(UniquePtr<SerializedStackHolder> aStackHolder,
   }
 
   JS::RootedObject converted(cx);
-  converted = JS::ConvertSavedFrameToPlainObject(cx, savedFrame,
+  converted = JS::ConvertSavedFrameToPlainObject(
-                                                 JS::SavedFrameSelfHosted::Exclude);
+      cx, savedFrame, JS::SavedFrameSelfHosted::Exclude);
   if (!converted) {
     JS_ClearPendingException(cx);
     return;

dom/base/SerializedStackHolder.h

@@ -59,8 +59,8 @@ UniquePtr<SerializedStackHolder> GetCurrentStackForNetMonitor(JSContext* aCx);
 // thread. This call is synchronous, and aChannel and aStackHolder will not be
 // used afterward. aChannel is an nsISupports object because this can be used
 // with either nsIChannel or nsIWebSocketChannel.
-void NotifyNetworkMonitorAlternateStack(nsISupports* aChannel,
+void NotifyNetworkMonitorAlternateStack(
-                                        UniquePtr<SerializedStackHolder> aStackHolder);
+    nsISupports* aChannel, UniquePtr<SerializedStackHolder> aStackHolder);
 
 // Read back the saved frame stack and store it in a string as JSON.
 // This must be called on the main thread.

dom/base/TabGroup.cpp

@@ -81,13 +81,11 @@ void TabGroup::EnsureThrottledEventQueues() {
   for (size_t i = 0; i < size_t(TaskCategory::Count); i++) {
     TaskCategory category = static_cast<TaskCategory>(i);
     if (category == TaskCategory::Worker) {
-      mEventTargets[i] =
+      mEventTargets[i] = ThrottledEventQueue::Create(mEventTargets[i],
-          ThrottledEventQueue::Create(mEventTargets[i],
                                                      "TabGroup worker queue");
     } else if (category == TaskCategory::Timer) {
       mEventTargets[i] =
-          ThrottledEventQueue::Create(mEventTargets[i],
+          ThrottledEventQueue::Create(mEventTargets[i], "TabGroup timer queue");
-                                      "TabGroup timer queue");
     }
   }
 }

dom/base/nsContentUtils.cpp

@@ -4180,10 +4180,9 @@ void nsContentUtils::RequestFrameFocus(Element& aFrameElement, bool aCanRaise) {
   RefPtr<Element> target = &aFrameElement;
   bool defaultAction = true;
   if (aCanRaise) {
-    DispatchEventOnlyToChrome(target->OwnerDoc(), target,
+    DispatchEventOnlyToChrome(
-                              NS_LITERAL_STRING("framefocusrequested"),
+        target->OwnerDoc(), target, NS_LITERAL_STRING("framefocusrequested"),
-                              CanBubble::eYes, Cancelable::eYes,
+        CanBubble::eYes, Cancelable::eYes, &defaultAction);
-                              &defaultAction);
   }
   if (!defaultAction) {
     return;

dom/base/nsDOMDataChannel.cpp

@@ -142,7 +142,9 @@ mozilla::dom::Nullable<uint16_t> nsDOMDataChannel::GetMaxRetransmits() const {
   return mDataChannel->GetMaxRetransmits();
 }
 
-bool nsDOMDataChannel::Negotiated() const { return mDataChannel->GetNegotiated(); }
+bool nsDOMDataChannel::Negotiated() const {
+  return mDataChannel->GetNegotiated();
+}
 
 bool nsDOMDataChannel::Ordered() const { return mDataChannel->GetOrdered(); }
 

dom/base/nsDocumentEncoder.cpp

@@ -617,7 +617,8 @@ nsresult nsDocumentEncoder::SerializeNodeStart(nsINode& aOriginalNode,
       return rv;
     }
     Element* originalElement = aOriginalNode.AsElement();
-    rv = mSerializer->AppendElementStart(node->AsElement(), originalElement, aStr);
+    rv = mSerializer->AppendElementStart(node->AsElement(), originalElement,
+                                         aStr);
     return rv;
   }
 

dom/base/nsFrameLoaderOwner.cpp

@@ -47,7 +47,8 @@ void nsFrameLoaderOwner::ChangeRemoteness(
     // Policy, do not preserve the browsing context. Otherwise, save off the
     // browsing context and use it when creating our new FrameLoader.
     if (!aOptions.mReplaceBrowsingContext && !isChromeRemoteToLocal &&
-        mozilla::Preferences::GetBool("fission.preserve_browsing_contexts", false)) {
+        mozilla::Preferences::GetBool("fission.preserve_browsing_contexts",
+                                      false)) {
       bc = mFrameLoader->GetBrowsingContext();
       mFrameLoader->SkipBrowsingContextDetach();
     }

dom/base/nsGlobalWindowOuter.h

@@ -231,9 +231,7 @@ class nsGlobalWindowOuter final : public mozilla::dom::EventTarget,
   }
 
   // nsIGlobalJSObjectHolder
-  JSObject* GetGlobalJSObject() final {
+  JSObject* GetGlobalJSObject() final { return GetWrapper(); }
-    return GetWrapper();
-  }
   JSObject* GetGlobalJSObjectPreserveColor() const final {
     return GetWrapperPreserveColor();
   }

dom/canvas/WebGLShader.cpp

@@ -134,8 +134,8 @@ void WebGLShader::CompileShader() {
     PrintLongString(mCleanSource.BeginReading(), mCleanSource.Length());
   }
 
-  const bool success = Translate(mCleanSource, mValidator.get(), &mValidationLog,
+  const bool success = Translate(mCleanSource, mValidator.get(),
-                        &mTranslatedSource);
+                                 &mValidationLog, &mTranslatedSource);
 
   if (MOZ_UNLIKELY(kDumpShaders)) {
     printf_stderr("\n==== \\/ \\/ \\/ ====\n");

dom/canvas/WebGLShaderValidator.h

@@ -16,9 +16,10 @@ namespace mozilla {
 namespace webgl {
 
 class ShaderValidator final {
-public:
+ public:
   const ShHandle mHandle;
-private:
+
+ private:
   const ShCompileOptions mCompileOptions;
   const int mMaxVaryingVectors;
   bool mHasRun;

dom/events/PointerEventHandler.cpp

@@ -518,8 +518,8 @@ void PointerEventHandler::DispatchPointerFromMouseOrTouch(
         break;
       case eMouseDown:
         pointerMessage =
-            mouseEvent->mButtons &
+            mouseEvent->mButtons & ~nsContentUtils::GetButtonsFlagForButton(
-                    ~nsContentUtils::GetButtonsFlagForButton(mouseEvent->mButton)
+                                       mouseEvent->mButton)
                 ? ePointerMove
                 : ePointerDown;
         break;

dom/ipc/BrowserHost.h

@@ -55,9 +55,7 @@ class BrowserHost : public RemoteBrowser,
   ContentParent* GetContentParent() const {
     return mRoot ? mRoot->Manager() : nullptr;
   }
-  TabId GetTabId() const {
+  TabId GetTabId() const { return mId; }
-    return mId;
-  }
 
   BrowserHost* AsBrowserHost() override { return this; }
   BrowserBridgeHost* AsBrowserBridgeHost() override { return nullptr; }

dom/ipc/RemoteWebProgressRequest.cpp

@@ -161,17 +161,17 @@ NS_IMETHODIMP RemoteWebProgressRequest::GetMatchedFullHash(
 }
 
 NS_IMETHODIMP RemoteWebProgressRequest::SetMatchedTrackingInfo(
-    const nsTArray<nsCString> &aLists, const nsTArray<nsCString> &aFullHashes) {
+    const nsTArray<nsCString>& aLists, const nsTArray<nsCString>& aFullHashes) {
   return NS_ERROR_NOT_IMPLEMENTED;
 }
 
 NS_IMETHODIMP RemoteWebProgressRequest::GetMatchedTrackingLists(
-    nsTArray<nsCString> &aLists) {
+    nsTArray<nsCString>& aLists) {
   return NS_ERROR_NOT_IMPLEMENTED;
 }
 
 NS_IMETHODIMP RemoteWebProgressRequest::GetMatchedTrackingFullHashes(
-    nsTArray<nsCString> &aFullHashes) {
+    nsTArray<nsCString>& aFullHashes) {
   return NS_ERROR_NOT_IMPLEMENTED;
 }
 // nsIRequest methods

dom/media/GraphDriver.cpp

@@ -974,10 +974,14 @@ long AudioCallbackDriver::DataCallback(const AudioDataValue* aInputBuffer,
 
 static const char* StateToString(cubeb_state aState) {
   switch (aState) {
-    case CUBEB_STATE_STARTED: return "STARTED";
+    case CUBEB_STATE_STARTED:
-    case CUBEB_STATE_STOPPED: return "STOPPED";
+      return "STARTED";
-    case CUBEB_STATE_DRAINED: return "DRAINED";
+    case CUBEB_STATE_STOPPED:
-    case CUBEB_STATE_ERROR: return "ERROR";
+      return "STOPPED";
+    case CUBEB_STATE_DRAINED:
+      return "DRAINED";
+    case CUBEB_STATE_ERROR:
+      return "ERROR";
     default:
       MOZ_CRASH("Unexpected state!");
   }
@@ -985,7 +989,8 @@ static const char* StateToString(cubeb_state aState) {
 
 void AudioCallbackDriver::StateCallback(cubeb_state aState) {
   MOZ_ASSERT(!OnGraphThread());
-  LOG(LogLevel::Debug, ("AudioCallbackDriver State: %s", StateToString(aState)));
+  LOG(LogLevel::Debug,
+      ("AudioCallbackDriver State: %s", StateToString(aState)));
 
   // Clear the flag for the not running
   // states: stopped, drained, error.

dom/media/platforms/PDMFactory.cpp

@@ -345,8 +345,7 @@ void PDMFactory::CreatePDMs() {
     return;
   }
 
-  if (StaticPrefs::MediaRddProcessEnabled()
+  if (StaticPrefs::MediaRddProcessEnabled() && BrowserTabsRemoteAutostart()) {
-      && BrowserTabsRemoteAutostart()) {
     m = new RemoteDecoderModule;
     StartupPDM(m);
   }

dom/media/platforms/agnostic/AgnosticDecoderModule.cpp

@@ -26,8 +26,7 @@ bool AgnosticDecoderModule::SupportsMimeType(
       VPXDecoder::IsVPX(aMimeType) || OpusDataDecoder::IsOpus(aMimeType) ||
       WaveDataDecoder::IsWave(aMimeType) || TheoraDecoder::IsTheora(aMimeType);
   if (!StaticPrefs::MediaRddVorbisEnabled() ||
-      !StaticPrefs::MediaRddProcessEnabled() ||
+      !StaticPrefs::MediaRddProcessEnabled() || !BrowserTabsRemoteAutostart()) {
-      !BrowserTabsRemoteAutostart()) {
     supports |= VorbisDataDecoder::IsVorbis(aMimeType);
   }
 #ifdef MOZ_AV1

dom/network/TCPSocketParent.cpp

@@ -43,8 +43,7 @@ using namespace net;
 
 namespace dom {
 
-static void FireInteralError(TCPSocketParent* aActor,
+static void FireInteralError(TCPSocketParent* aActor, uint32_t aLineNo) {
-                             uint32_t aLineNo) {
   MOZ_ASSERT(aActor->IPCOpen());
 
   mozilla::Unused << aActor->SendCallback(

dom/plugins/base/nsJSNPRuntime.cpp

@@ -66,9 +66,7 @@ struct GCPolicy<nsJSObjWrapper*> {
     (*wrapper)->trace(trc);
   }
 
-  static bool isValid(const nsJSObjWrapper *&wrapper) {
+  static bool isValid(const nsJSObjWrapper*& wrapper) { return true; }
-    return true;
-  }
 };
 }  // namespace JS
 

dom/quota/QuotaManager.h

@@ -173,7 +173,8 @@ class QuotaManager final : public BackgroundThreadObject {
   /**
    * For use when creating an origin directory. It's possible that origin usage
    * is already being tracked due to a call to EnsureQuotaForOrigin, and in that
-   * case we need to update the existing OriginInfo rather than create a new one.
+   * case we need to update the existing OriginInfo rather than create a new
+   * one.
    */
   void NoteOriginDirectoryCreated(PersistenceType aPersistenceType,
                                   const nsACString& aGroup,

dom/storage/StorageNotifierService.cpp

@@ -75,8 +75,8 @@ void StorageNotifierService::Broadcast(StorageEvent* aEvent,
 
     // No reasons to continue if the principal of the event doesn't match with
     // the window's one.
-    if (!StorageUtils::PrincipalsEqual(aEvent->GetPrincipal(),
+    if (!StorageUtils::PrincipalsEqual(
-                                       observer->GetEffectiveStoragePrincipal())) {
+            aEvent->GetPrincipal(), observer->GetEffectiveStoragePrincipal())) {
       continue;
     }
 

dom/svg/SVGPathData.h

@@ -165,9 +165,11 @@ class SVGPathData {
    * which is generated by cbindgen from Rust (see ServoStyleConsts.h).
    * Basically, this is a variant of the above BuildPath() functions.
    */
-  static already_AddRefed<Path> BuildPath(
+  static already_AddRefed<Path> BuildPath(Span<const StylePathCommand> aPath,
-      Span<const StylePathCommand> aPath, PathBuilder* aBuilder,
+                                          PathBuilder* aBuilder,
-      uint8_t aStrokeLineCap, Float aStrokeWidth, float aZoomFactor = 1.0);
+                                          uint8_t aStrokeLineCap,
+                                          Float aStrokeWidth,
+                                          float aZoomFactor = 1.0);
 
   const_iterator begin() const { return mData.Elements(); }
   const_iterator end() const { return mData.Elements() + mData.Length(); }

dom/websocket/WebSocket.cpp

@@ -1649,8 +1649,8 @@ nsresult WebSocketImpl::Init(JSContext* aCx, nsIPrincipal* aLoadingPrincipal,
   return NS_OK;
 }
 
-nsresult WebSocketImpl::AsyncOpen(nsIPrincipal* aPrincipal,
+nsresult WebSocketImpl::AsyncOpen(
-                                  uint64_t aInnerWindowID,
+    nsIPrincipal* aPrincipal, uint64_t aInnerWindowID,
     nsITransportProvider* aTransportProvider,
     const nsACString& aNegotiatedExtensions,
     UniquePtr<SerializedStackHolder> aOriginStack) {

dom/workers/ScriptLoader.cpp

@@ -844,8 +844,7 @@ class ScriptLoaderRunnable final : public nsIRunnable, public nsINamed {
     // thread) explicitly, so that we can use the stack to notify the net
     // monitor about every script we load.
     if (mOriginStack) {
-      ConvertSerializedStackToJSON(std::move(mOriginStack),
+      ConvertSerializedStackToJSON(std::move(mOriginStack), mOriginStackJSON);
-                                   mOriginStackJSON);
     }
 
     if (!mWorkerPrivate->IsServiceWorker() || IsDebuggerScript()) {
@@ -2125,8 +2124,8 @@ void LoadAllScripts(WorkerPrivate* aWorkerPrivate,
   }
 
   RefPtr<ScriptLoaderRunnable> loader = new ScriptLoaderRunnable(
-      aWorkerPrivate, std::move(aOriginStack), syncLoopTarget, aLoadInfos, clientInfo,
+      aWorkerPrivate, std::move(aOriginStack), syncLoopTarget, aLoadInfos,
-      controller, aIsMainScript, aWorkerScriptType, aRv);
+      clientInfo, controller, aIsMainScript, aWorkerScriptType, aRv);
 
   NS_ASSERTION(aLoadInfos.IsEmpty(), "Should have swapped!");
 

dom/workers/WorkerPrivate.cpp

@@ -310,7 +310,8 @@ class CompileScriptRunnable final : public WorkerDebuggeeRunnable {
                                  UniquePtr<SerializedStackHolder> aOriginStack,
                                  const nsAString& aScriptURL)
       : WorkerDebuggeeRunnable(aWorkerPrivate, WorkerThreadModifyBusyCount),
-        mScriptURL(aScriptURL), mOriginStack(aOriginStack.release()) {}
+        mScriptURL(aScriptURL),
+        mOriginStack(aOriginStack.release()) {}
 
  private:
   // We can't implement PreRun effectively, because at the point when that would
@@ -2178,9 +2179,8 @@ WorkerPrivate::WorkerPrivate(WorkerPrivate* aParent,
   mMainThreadEventTargetForMessaging =
       ThrottledEventQueue::Create(target, "Worker queue for messaging");
   if (StaticPrefs::dom_worker_use_medium_high_event_queue()) {
-    mMainThreadEventTarget =
+    mMainThreadEventTarget = ThrottledEventQueue::Create(
-        ThrottledEventQueue::Create(GetMainThreadSerialEventTarget(),
+        GetMainThreadSerialEventTarget(), "Worker queue",
-                                    "Worker queue",
         nsIRunnablePriority::PRIORITY_MEDIUMHIGH);
   } else {
     mMainThreadEventTarget = mMainThreadEventTargetForMessaging;

dom/workers/WorkerPrivate.h

@@ -766,9 +766,7 @@ class WorkerPrivate : public RelativeTimeline {
     return mLoadInfo.mServiceWorkersTestingInWindow;
   }
 
-  bool IsWatchedByDevtools() const {
+  bool IsWatchedByDevtools() const { return mLoadInfo.mWatchedByDevtools; }
-    return mLoadInfo.mWatchedByDevtools;
-  }
 
   // Determine if the worker is currently loading its top level script.
   bool IsLoadingWorkerScript() const { return mLoadingWorkerScript; }

gfx/layers/LayerTreeInvalidation.cpp

@@ -141,9 +141,7 @@ static void NotifySubdocumentInvalidation(
 }
 
 static void SetChildrenChangedRecursive(Layer* aLayer) {
-  ForEachNode<ForwardIterator>(
+  ForEachNode<ForwardIterator>(aLayer, [](Layer* layer) {
-      aLayer,
-      [](Layer* layer) {
     ContainerLayer* container = layer->AsContainerLayer();
     if (container) {
       container->SetChildrenChanged(true);

gfx/layers/apz/src/APZCTreeManager.h

@@ -590,6 +590,7 @@ class APZCTreeManager : public IAPZCTreeManager, public APZInputBridge {
 
   // Also used for controlling time during tests
   void SetTestSampleTime(const Maybe<TimeStamp>& aTime);
+
  private:
   Maybe<TimeStamp> mTestSampleTime;
 

gfx/layers/apz/util/APZCCallbackHelper.cpp

@@ -666,8 +666,7 @@ static bool PrepareForSetTargetAPZCNotification(
     nsIWidget* aWidget, const LayersId& aLayersId, nsIFrame* aRootFrame,
     const LayoutDeviceIntPoint& aRefPoint,
     nsTArray<SLGuidAndRenderRoot>* aTargets) {
-  SLGuidAndRenderRoot guid(aLayersId, 0,
+  SLGuidAndRenderRoot guid(aLayersId, 0, ScrollableLayerGuid::NULL_SCROLL_ID,
-                           ScrollableLayerGuid::NULL_SCROLL_ID,
                            wr::RenderRoot::Default);
   nsPoint point = nsLayoutUtils::GetEventCoordinatesRelativeTo(
       aWidget, aRefPoint, aRootFrame);
@@ -818,9 +817,11 @@ void DisplayportSetListener::DidRefresh() {
 }
 
 UniquePtr<DisplayportSetListener>
-APZCCallbackHelper::SendSetTargetAPZCNotification(
+APZCCallbackHelper::SendSetTargetAPZCNotification(nsIWidget* aWidget,
-    nsIWidget* aWidget, dom::Document* aDocument, const WidgetGUIEvent& aEvent,
+                                                  dom::Document* aDocument,
-    const LayersId& aLayersId, uint64_t aInputBlockId) {
+                                                  const WidgetGUIEvent& aEvent,
+                                                  const LayersId& aLayersId,
+                                                  uint64_t aInputBlockId) {
   if (!aWidget || !aDocument) {
     return nullptr;
   }

gfx/layers/apz/util/APZEventState.cpp

@@ -176,8 +176,8 @@ void APZEventState::ProcessSingleTap(const CSSPoint& aPoint,
                                      const CSSToLayoutDeviceScale& aScale,
                                      Modifiers aModifiers,
                                      int32_t aClickCount) {
-  APZES_LOG("Handling single tap at %s with %d\n",
+  APZES_LOG("Handling single tap at %s with %d\n", Stringify(aPoint).c_str(),
-            Stringify(aPoint).c_str(), mTouchEndCancelled);
+            mTouchEndCancelled);
 
   RefPtr<nsIContent> touchRollup = GetTouchRollup();
   mTouchRollup = nullptr;

gfx/layers/basic/BasicCompositor.cpp

@@ -225,7 +225,6 @@ BasicCompositor::BasicCompositor(CompositorBridgeParent* aParent,
   mMaxTextureSize =
       std::min(Factory::GetMaxSurfaceSize(gfxVars::ContentBackend()),
                Factory::GetMaxSurfaceSize(BackendType::CAIRO));
-
 }
 
 BasicCompositor::~BasicCompositor() { MOZ_COUNT_DTOR(BasicCompositor); }

gfx/layers/d3d11/CompositorD3D11.cpp

@@ -451,7 +451,8 @@ CompositorD3D11::CreateRenderTargetFromSource(
 
 bool CompositorD3D11::ShouldAllowFrameRecording() const {
 #ifdef MOZ_GECKO_PROFILER
-  return mAllowFrameRecording || profiler_feature_active(ProfilerFeature::Screenshots);
+  return mAllowFrameRecording ||
+         profiler_feature_active(ProfilerFeature::Screenshots);
 #else
   return mAllowFrameRecording;
 #endif

gfx/layers/wr/WebRenderLayerManager.cpp

@@ -485,8 +485,8 @@ void WebRenderLayerManager::MakeSnapshotIfRequired(LayoutDeviceIntSize aSize) {
       SurfaceFormat::B8G8R8A8;
 #endif
   RefPtr<TextureClient> texture = TextureClient::CreateForRawBufferAccess(
-      WrBridge(), format, aSize.ToUnknownSize(),
+      WrBridge(), format, aSize.ToUnknownSize(), BackendType::SKIA,
-      BackendType::SKIA, TextureFlags::SNAPSHOT);
+      TextureFlags::SNAPSHOT);
   if (!texture) {
     return;
   }

gfx/thebes/SharedFontList.cpp

@@ -112,7 +112,7 @@ void Family::AddFaces(FontList* aList, const nsTArray<Face::InitData>& aFaces) {
   // of the full CSS font-matching algorithm) if there is at maximum one normal,
   // bold, italic, and bold-italic face; in this case, they are stored at known
   // positions in the mFaces array.
-  const Face::InitData* slots[4] = { nullptr, nullptr, nullptr, nullptr };
+  const Face::InitData* slots[4] = {nullptr, nullptr, nullptr, nullptr};
   if (count >= 2 && count <= 4) {
     // Check if this can be treated as a "simple" family
     isSimple = true;
@@ -332,8 +332,9 @@ void Family::SearchAllFontsForChar(FontList* aList,
         // already checked character coverage, do it now (note that
         // HasCharacter() will trigger loading the fontEntry's cmap, if
         // needed).
-        RefPtr<gfxFontEntry> fe = gfxPlatformFontList::PlatformFontList()
+        RefPtr<gfxFontEntry> fe =
-            ->GetOrCreateFontEntry(face, this);
+            gfxPlatformFontList::PlatformFontList()->GetOrCreateFontEntry(face,
+                                                                          this);
         if (!fe) {
           continue;
         }
@@ -358,9 +359,8 @@ void Family::SetFacePtrs(FontList* aList, nsTArray<Pointer>& aFaces) {
     // them at the appropriate slots in mFaces and set the mIsSimple flag to
     // accelerate font-matching.
     bool isSimple = true;
-    Pointer slots[4] = {
+    Pointer slots[4] = {Pointer::Null(), Pointer::Null(), Pointer::Null(),
-      Pointer::Null(), Pointer::Null(), Pointer::Null(), Pointer::Null()
+                        Pointer::Null()};
-    };
     for (const Pointer& fp : aFaces) {
       const Face* f = static_cast<const Face*>(fp.ToPtr(aList));
       if (!f->mWeight.IsSingle() || !f->mStyle.IsSingle() ||

gfx/thebes/gfxFontEntry.cpp

@@ -140,8 +140,7 @@ gfxFontEntry::~gfxFontEntry() {
   MOZ_ASSERT(!mGrFaceInitialized);
 }
 
-bool gfxFontEntry::TrySetShmemCharacterMap()
+bool gfxFontEntry::TrySetShmemCharacterMap() {
-{
   MOZ_ASSERT(mShmemFace);
   auto list = gfxPlatformFontList::PlatformFontList()->SharedFontList();
   mShmemCharacterMap =

gfx/thebes/gfxFontUtils.h

@@ -487,7 +487,8 @@ inline void gfxSparseBitSet::Union(const SharedBitSet& aBitset) {
     mBlockIndex.AppendElement(NO_BLOCK);
   }
   auto blockIndex = reinterpret_cast<const uint16_t*>(&aBitset + 1);
-  auto blocks = reinterpret_cast<const Block*>(blockIndex + aBitset.mBlockIndexCount);
+  auto blocks =
+      reinterpret_cast<const Block*>(blockIndex + aBitset.mBlockIndexCount);
   for (uint32_t i = 0; i < aBitset.mBlockIndexCount; ++i) {
     // if it is missing (implicitly empty) in source, just skip
     if (blockIndex[i] == NO_BLOCK) {
@@ -501,10 +502,9 @@ inline void gfxSparseBitSet::Union(const SharedBitSet& aBitset) {
       continue;
     }
     // else set existing target block to the union of both
-    uint32_t* dst = reinterpret_cast<uint32_t*>(
+    uint32_t* dst = reinterpret_cast<uint32_t*>(&mBlocks[mBlockIndex[i]].mBits);
-        &mBlocks[mBlockIndex[i]].mBits);
+    const uint32_t* src =
-    const uint32_t* src = reinterpret_cast<const uint32_t*>(
+        reinterpret_cast<const uint32_t*>(&blocks[blockIndex[i]].mBits);
-        &blocks[blockIndex[i]].mBits);
     for (uint32_t j = 0; j < BLOCK_SIZE / 4; ++j) {
       dst[j] |= src[j];
     }

gfx/thebes/gfxMacPlatformFontList.mm

@@ -1763,8 +1763,7 @@ void gfxMacPlatformFontList::ActivateFontsFromDir(nsIFile* aDir) {
 }
 
 void gfxMacPlatformFontList::GetFacesInitDataForFamily(
-    const fontlist::Family* aFamily,
+    const fontlist::Family* aFamily, nsTArray<fontlist::Face::InitData>& aFaces) const {
-    nsTArray<fontlist::Face::InitData>& aFaces) const {
   nsAutoreleasePool localPool;
 
   NS_ConvertUTF8toUTF16 name(aFamily->Key().AsString(SharedFontList()));
@@ -1860,8 +1859,7 @@ void gfxMacPlatformFontList::ReadFaceNamesForFamily(fontlist::Family* aFamily,
     // of the macOS UI font; see MacOSFontEntry::GetFontRef(). We pass 16.0 in
     // order to get a standard text-size face in this case, although it's
     // unlikely to matter for the purpose of just reading family names.
-    auto fe = MakeUnique<MacOSFontEntry>(name, WeightRange(FontWeight::Normal()),
+    auto fe = MakeUnique<MacOSFontEntry>(name, WeightRange(FontWeight::Normal()), false, 16.0);
-                                         false, 16.0);
     if (!fe) {
       continue;
     }
@@ -1872,8 +1870,8 @@ void gfxMacPlatformFontList::ReadFaceNamesForFamily(fontlist::Family* aFamily,
     uint32_t dataLength;
     const char* nameData = hb_blob_get_data(nameTable, &dataLength);
     AutoTArray<nsCString, 4> otherFamilyNames;
-    gfxFontUtils::ReadOtherFamilyNamesForFace(canonicalName, nameData, dataLength,
+    gfxFontUtils::ReadOtherFamilyNamesForFace(canonicalName, nameData, dataLength, otherFamilyNames,
-                                              otherFamilyNames, false);
+                                              false);
     for (const auto& alias : otherFamilyNames) {
       auto af = mAliasTable.LookupOrAdd(alias);
       af->AppendElement(facePtrs[i]);

gfx/webrender_bindings/RendererOGL.cpp

@@ -129,8 +129,7 @@ bool RendererOGL::UpdateAndRender(const Maybe<gfx::IntSize>& aReadbackSize,
     MOZ_ASSERT(aReadbackSize.isSome());
     MOZ_ASSERT(aReadbackFormat.isSome());
     wr_renderer_readback(mRenderer, aReadbackSize.ref().width,
-                         aReadbackSize.ref().height,
+                         aReadbackSize.ref().height, aReadbackFormat.ref(),
-                         aReadbackFormat.ref(),
                          &aReadbackBuffer.ref()[0],
                          aReadbackBuffer.ref().length());
   }

gfx/webrender_bindings/WebRenderAPI.cpp

@@ -430,7 +430,10 @@ void WebRenderAPI::Readback(const TimeStamp& aStartTime, gfx::IntSize size,
     explicit Readback(layers::SynchronousTask* aTask, TimeStamp aStartTime,
                       gfx::IntSize aSize, const gfx::SurfaceFormat& aFormat,
                       const Range<uint8_t>& aBuffer)
-        : mTask(aTask), mStartTime(aStartTime), mSize(aSize), mFormat(aFormat),
+        : mTask(aTask),
+          mStartTime(aStartTime),
+          mSize(aSize),
+          mFormat(aFormat),
           mBuffer(aBuffer) {
       MOZ_COUNT_CTOR(Readback);
     }
@@ -1161,8 +1164,7 @@ void DisplayListBuilder::PushShadow(const wr::LayoutRect& aRect,
   // being re-enabled mid-shadow. The optimization is restored in PopAllShadows.
   SuspendClipLeafMerging();
   wr_dp_push_shadow(mWrState, aRect, aClip, aIsBackfaceVisible,
-                    &mCurrentSpaceAndClipChain, aShadow,
+                    &mCurrentSpaceAndClipChain, aShadow, aShouldInflate);
-                    aShouldInflate);
 }
 
 void DisplayListBuilder::PopAllShadows() {

intl/hyphenation/glue/nsHyphenator.h

@@ -25,8 +25,8 @@ class nsHyphenator {
  private:
   ~nsHyphenator();
 
-  void HyphenateWord(const nsAString& aString, uint32_t aStart,
+  void HyphenateWord(const nsAString& aString, uint32_t aStart, uint32_t aLimit,
-                     uint32_t aLimit, nsTArray<bool>& aHyphens);
+                     nsTArray<bool>& aHyphens);
 
   void* mDict;
   bool mHyphenateCapitalized;

ipc/mscom/ProcessRuntime.cpp

@@ -69,7 +69,7 @@ ProcessRuntime::ProcessRuntime(GeckoProcessType aProcessType)
     }
     nsAutoHandle curThreadImpToken(rawCurThreadImpToken);
 
-#if defined(DEBUG)
+#  if defined(DEBUG)
     // Ensure that our current token is still an impersonation token (ie, we
     // have not yet called RevertToSelf() on this thread).
     DWORD len;
@@ -77,7 +77,7 @@ ProcessRuntime::ProcessRuntime(GeckoProcessType aProcessType)
     MOZ_ASSERT(::GetTokenInformation(rawCurThreadImpToken, TokenType,
                                      &tokenType, sizeof(tokenType), &len) &&
                len == sizeof(tokenType) && tokenType == TokenImpersonation);
-#endif  // defined(DEBUG)
+#  endif  // defined(DEBUG)
 
     // Create an impersonation token based on the current thread's token
     HANDLE rawMtaThreadImpToken = nullptr;
@@ -89,22 +89,26 @@ ProcessRuntime::ProcessRuntime(GeckoProcessType aProcessType)
     nsAutoHandle mtaThreadImpToken(rawMtaThreadImpToken);
 
     SandboxTarget::Instance()->RegisterSandboxStartCallback([]() -> void {
-      EnsureMTA([]() -> void {
+      EnsureMTA(
+          []() -> void {
             // This is a security risk if it fails, so we release assert
             MOZ_RELEASE_ASSERT(::RevertToSelf(),
                                "mscom::ProcessRuntime RevertToSelf failed");
-      }, EnsureMTA::Option::ForceDispatch);
+          },
+          EnsureMTA::Option::ForceDispatch);
     });
 
     // Impersonate and initialize.
-    EnsureMTA([this, rawMtaThreadImpToken]() -> void {
+    EnsureMTA(
+        [this, rawMtaThreadImpToken]() -> void {
           if (!::SetThreadToken(nullptr, rawMtaThreadImpToken)) {
             mInitResult = HRESULT_FROM_WIN32(::GetLastError());
             return;
           }
 
           InitInsideApartment();
-    }, EnsureMTA::Option::ForceDispatch);
+        },
+        EnsureMTA::Option::ForceDispatch);
 
     return;
   }

layout/generic/nsFrame.cpp

@@ -3642,8 +3642,8 @@ static bool DescendIntoChild(nsDisplayListBuilder* aBuilder,
     }
 
     nsDisplayTableBackgroundSet* tableBGs = aBuilder->GetTableBackgroundSet();
-    if (tableBGs &&
+    if (tableBGs && tableBGs->GetDirtyRect().Intersects(
-        tableBGs->GetDirtyRect().Intersects(normalPositionOverflowRelativeToTable)) {
+                        normalPositionOverflowRelativeToTable)) {
       return true;
     }
   }

layout/painting/RetainedDisplayListBuilder.cpp

@@ -130,7 +130,8 @@ bool RetainedDisplayListBuilder::PreProcessDisplayList(
   // list build if we hit them.
   static const uint32_t kMaxEdgeRatio = 5;
   const bool initializeDAG = !aList->mDAG.Length();
-  if (!aKeepLinked && !initializeDAG && aList->mDAG.mDirectPredecessorList.Length() >
+  if (!aKeepLinked && !initializeDAG &&
+      aList->mDAG.mDirectPredecessorList.Length() >
           (aList->mDAG.mNodesInfo.Length() * kMaxEdgeRatio)) {
     return false;
   }
@@ -227,7 +228,9 @@ bool RetainedDisplayListBuilder::PreProcessDisplayList(
       if (!PreProcessDisplayList(
               item->GetChildren(), SelectAGRForFrame(f, aAGR), aUpdated,
               item->GetPerFrameKey(), aNestingDepth + 1, keepLinked)) {
-        MOZ_RELEASE_ASSERT(!aKeepLinked, "Can't early return since we need to move the out list back");
+        MOZ_RELEASE_ASSERT(
+            !aKeepLinked,
+            "Can't early return since we need to move the out list back");
         return false;
       }
     }
@@ -1201,8 +1204,7 @@ static void AddFramesForContainingBlock(nsIFrame* aBlock,
 // ancestors must also be visited).
 static void FindContainingBlocks(nsIFrame* aFrame,
                                  nsTArray<nsIFrame*>& aExtraFrames) {
-  for (nsIFrame* f = aFrame; f;
+  for (nsIFrame* f = aFrame; f; f = nsLayoutUtils::GetDisplayListParent(f)) {
-       f = nsLayoutUtils::GetDisplayListParent(f)) {
     if (f->ForceDescendIntoIfVisible()) return;
     f->SetForceDescendIntoIfVisible(true);
     CRR_LOG("Considering OOFs for %p\n", f);

layout/painting/nsCSSRenderingBorders.cpp

@@ -3753,7 +3753,8 @@ nsCSSBorderImageRenderer::nsCSSBorderImageRenderer(
     const auto& width = aStyleBorder.mBorderImageWidth.Get(s);
     switch (width.tag) {
       case StyleBorderImageSideWidth::Tag::LengthPercentage:
-        value = std::max(0, width.AsLengthPercentage().Resolve(borderDimension));
+        value =
+            std::max(0, width.AsLengthPercentage().Resolve(borderDimension));
         break;
       case StyleBorderImageSideWidth::Tag::Number:
         value = width.AsNumber() * borderWidths.Side(s);

layout/style/CounterStyleManager.cpp

@@ -1153,8 +1153,7 @@ bool CustomCounterStyle::IsBullet() {
 void CustomCounterStyle::GetNegative(NegativeType& aResult) {
   if (!(mFlags & FLAG_NEGATIVE_INITED)) {
     mFlags |= FLAG_NEGATIVE_INITED;
-    if (!Servo_CounterStyleRule_GetNegative(mRule,
+    if (!Servo_CounterStyleRule_GetNegative(mRule, &mNegative.before,
-                                            &mNegative.before,
                                             &mNegative.after)) {
       if (IsExtendsSystem()) {
         GetExtends()->GetNegative(mNegative);

layout/style/FontFace.cpp

@@ -315,8 +315,7 @@ void FontFace::SetDisplay(const nsAString& aValue, ErrorResult& aRv) {
   }
 }
 
-void FontFace::DescriptorUpdated()
+void FontFace::DescriptorUpdated() {
-{
   // If we haven't yet initialized mUserFontEntry, no need to do anything here;
   // we'll respect the updated descriptor when the time comes to create it.
   if (!mUserFontEntry) {

layout/style/FontFaceSet.cpp

@@ -1032,10 +1032,9 @@ FontFaceSet::FindOrCreateUserFontEntryFromFontFace(
   if (existingEntry) {
     // aFontFace already has a user font entry, so we update its attributes
     // rather than creating a new one.
-    existingEntry->UpdateAttributes(weight, stretch, italicStyle,
+    existingEntry->UpdateAttributes(
-                                    featureSettings, variationSettings,
+        weight, stretch, italicStyle, featureSettings, variationSettings,
-                                    languageOverride, unicodeRanges,
+        languageOverride, unicodeRanges, fontDisplay, rangeFlags);
-                                    fontDisplay, rangeFlags);
     // If the family name has changed, remove the entry from its current family
     // and clear the mFamilyName field so it can be reset when added to a new
     // family.

layout/style/ServoStyleConstsForwards.h

@@ -80,7 +80,7 @@ class WritingMode;
 class ServoElementSnapshotTable;
 enum class StyleContentType : uint8_t;
 
-template<typename T>
+template <typename T>
 struct StyleForgottenArcSlicePtr;
 
 struct AnimationPropertySegment;

layout/style/nsStyleConsts.h

@@ -171,7 +171,8 @@ enum class StyleScrollbarWidth : uint8_t {
 // Shape source type
 enum class StyleShapeSourceType : uint8_t {
   None,
-  Image,  // shape-outside / clip-path only, and clip-path only uses it for <url>s
+  Image,  // shape-outside / clip-path only, and clip-path only uses it for
+          // <url>s
   Shape,
   Box,
   Path,  // SVG path function

layout/style/nsStyleUtil.h

@@ -29,7 +29,7 @@ class FontSlantStyle;
 namespace dom {
 class Document;
 class Element;
-}
+}  // namespace dom
 }  // namespace mozilla
 
 // Style utility functions

layout/svg/SVGImageContext.cpp

@@ -55,11 +55,13 @@ void SVGImageContext::MaybeStoreContextPaint(Maybe<SVGImageContext>& aContext,
     haveContextPaint = true;
     contextPaint->SetStroke(style->mStroke.GetColor(aFromComputedStyle));
   }
-  if (style->mMozContextProperties.bits & StyleContextPropertyBits_FILL_OPACITY) {
+  if (style->mMozContextProperties.bits &
+      StyleContextPropertyBits_FILL_OPACITY) {
     haveContextPaint = true;
     contextPaint->SetFillOpacity(style->mFillOpacity);
   }
-  if (style->mMozContextProperties.bits & StyleContextPropertyBits_STROKE_OPACITY) {
+  if (style->mMozContextProperties.bits &
+      StyleContextPropertyBits_STROKE_OPACITY) {
     haveContextPaint = true;
     contextPaint->SetStrokeOpacity(style->mStrokeOpacity);
   }

layout/svg/SVGObserverUtils.cpp

@@ -1234,7 +1234,8 @@ static nsSVGPaintingProperty* GetOrCreateClipPathObserver(
   if (svgStyleReset->mClipPath.GetType() != StyleShapeSourceType::Image) {
     return nullptr;
   }
-  const css::URLValue* url = svgStyleReset->mClipPath.ShapeImage().GetURLValue();
+  const css::URLValue* url =
+      svgStyleReset->mClipPath.ShapeImage().GetURLValue();
   MOZ_ASSERT(url);
   RefPtr<URLAndReferrerInfo> pathURI =
       ResolveURLUsingLocalRef(aClippedFrame, url);

layout/tables/nsTableRowGroupFrame.cpp

@@ -240,8 +240,8 @@ void nsTableRowGroupFrame::BuildDisplayList(nsDisplayListBuilder* aBuilder,
   DisplayOutsetBoxShadow(aBuilder, aLists.BorderBackground());
 
   for (nsTableRowFrame* row = GetFirstRow(); row; row = row->GetNextRow()) {
-    if (!aBuilder->GetDirtyRect().Intersects(
+    if (!aBuilder->GetDirtyRect().Intersects(row->GetVisualOverflowRect() +
-            row->GetVisualOverflowRect() + row->GetNormalPosition())) {
+                                             row->GetNormalPosition())) {
       continue;
     }
     row->PaintCellBackgroundsForFrame(this, aBuilder, aLists,

media/libdav1d/config.h

@@ -45,9 +45,9 @@
 #if ARCH_AARCH64 == 1
 // Those values are copied from the auto generated
 // config file produced by stand alone dav1d build.
-#define HAVE_AS_FUNC 0
+#  define HAVE_AS_FUNC 0
-#define HAVE_GETAUXVAL 1
+#  define HAVE_GETAUXVAL 1
-#define PIC 3
+#  define PIC 3
 #endif
 
 // The following macros are defined from autoconf

mfbt/HashTable.h

@@ -1618,7 +1618,6 @@ class HashTable : private AllocPolicy {
 
   static char* createTable(AllocPolicy& aAllocPolicy, uint32_t aCapacity,
                            FailureBehavior aReportFailure = ReportFailure) {
-
     FakeSlot* fake =
         aReportFailure
             ? aAllocPolicy.template pod_malloc<FakeSlot>(aCapacity)

mfbt/RecordReplay.cpp

@@ -45,42 +45,41 @@ namespace recordreplay {
                             (JSContext * aCx, JSObject * aObj), (aCx, aObj))
 
 #define FOR_EACH_INTERFACE_VOID(Macro)                                         \
+  Macro(InternalBeginOrderedAtomicAccess, (const void* aValue),                \
+        (aValue)) Macro(InternalEndOrderedAtomicAccess, (), ())                \
+      Macro(InternalBeginPassThroughThreadEvents, (), ()) Macro(               \
+          InternalEndPassThroughThreadEvents, (),                              \
+          ()) Macro(InternalBeginDisallowThreadEvents, (),                     \
+                    ()) Macro(InternalEndDisallowThreadEvents, (),             \
+                              ()) Macro(InternalRecordReplayBytes,             \
+                                        (void* aData, size_t aSize),           \
+                                        (aData, aSize))                        \
           Macro(                                                               \
-      InternalBeginOrderedAtomicAccess, (const void* aValue),                  \
+              InternalInvalidateRecording, (const char* aWhy),                 \
-      (aValue)) Macro(InternalEndOrderedAtomicAccess, (),                      \
+              (aWhy)) Macro(InternalDestroyPLDHashTableCallbacks,              \
-                      ()) Macro(InternalBeginPassThroughThreadEvents, (),      \
-                                ()) Macro(InternalEndPassThroughThreadEvents,  \
-                                          (), ())                              \
-      Macro(InternalBeginDisallowThreadEvents, (), ()) Macro(                  \
-          InternalEndDisallowThreadEvents, (),                                 \
-          ()) Macro(InternalRecordReplayBytes, (void* aData, size_t aSize),    \
-                    (aData, aSize)) Macro(InternalInvalidateRecording,         \
-                                          (const char* aWhy), (aWhy))          \
-          Macro(InternalDestroyPLDHashTableCallbacks,                          \
                             (const PLDHashTableOps* aOps),                     \
                             (aOps)) Macro(InternalMovePLDHashTableContents,    \
                                           (const PLDHashTableOps* aFirstOps,   \
                                            const PLDHashTableOps* aSecondOps), \
-                              (aFirstOps,                                      \
+                                          (aFirstOps, aSecondOps))             \
-                               aSecondOps)) Macro(SetWeakPointerJSRoot,        \
+              Macro(SetWeakPointerJSRoot,                                      \
-                                                  (const void* aPtr,           \
+                    (const void* aPtr, JSObject* aJSObj), (aPtr, aJSObj))      \
-                                                   JSObject* aJSObj),          \
-                                                  (aPtr, aJSObj))              \
                   Macro(RegisterTrigger,                                       \
                         (void* aObj, const std::function<void()>& aCallback),  \
-                    (aObj, aCallback)) Macro(UnregisterTrigger, (void* aObj),  \
+                        (aObj,                                                 \
-                                             (aObj))                           \
+                         aCallback)) Macro(UnregisterTrigger, (void* aObj),    \
-                  Macro(ActivateTrigger, (void* aObj), (aObj)) Macro(          \
+                                           (aObj)) Macro(ActivateTrigger,      \
-                      ExecuteTriggers, (),                                     \
+                                                         (void* aObj), (aObj)) \
-                      ()) Macro(InternalRecordReplayAssert,                    \
+                      Macro(ExecuteTriggers, (), ()) Macro(                    \
+                          InternalRecordReplayAssert,                          \
                           (const char* aFormat, va_list aArgs),                \
-                                (aFormat, aArgs))                              \
+                          (aFormat,                                            \
-                      Macro(InternalRecordReplayAssertBytes,                   \
+                           aArgs)) Macro(InternalRecordReplayAssertBytes,      \
                                          (const void* aData, size_t aSize),    \
-                            (aData, aSize)) Macro(InternalRegisterThing,       \
+                                         (aData, aSize))                       \
+                          Macro(InternalRegisterThing, (void* aThing),         \
+                                (aThing)) Macro(InternalUnregisterThing,       \
                                                 (void* aThing), (aThing))      \
-                          Macro(InternalUnregisterThing, (void* aThing),       \
-                                (aThing))                                      \
                               Macro(BeginContentParse,                         \
                                     (const void* aToken, const char* aURL,     \
                                      const char* aContentType),                \

mozglue/build/Authenticode.cpp

@@ -326,8 +326,8 @@ bool SignedBinary::VerifySignature(const wchar_t* aFilePath) {
 
   // We can't use UniquePtr for this because the deleter function requires two
   // parameters.
-  auto cleanCatInfoHdl = mozilla::MakeScopeExit(
+  auto cleanCatInfoHdl =
-    [rawCatAdmin, catInfoHdl]() -> void {
+      mozilla::MakeScopeExit([rawCatAdmin, catInfoHdl]() -> void {
         pCryptCATAdminReleaseCatalogContext(rawCatAdmin, catInfoHdl, 0);
       });
 

mozglue/tests/interceptor/TestDllInterceptor.cpp

@@ -832,7 +832,12 @@ extern "C" int wmain(int argc, wchar_t* argv[]) {
 #endif
       TEST_DETOUR_SKIP_EXEC(kernel32.dll, BaseThreadInitThunk) &&
       TEST_DETOUR_SKIP_EXEC(ntdll.dll, LdrLoadDll) &&
-      MAYBE_TEST_HOOK_PARAMS(HasApiSetQueryApiSetPresence(), Api-ms-win-core-apiquery-l1-1-0.dll, ApiSetQueryApiSetPresence, Equals, FALSE, &gEmptyUnicodeString, &gIsPresent) &&
+      MAYBE_TEST_HOOK_PARAMS(HasApiSetQueryApiSetPresence(),
+                             // clang-format off
+                             Api-ms-win-core-apiquery-l1-1-0.dll,
+                             // clang-format on
+                             ApiSetQueryApiSetPresence, Equals, FALSE,
+                             &gEmptyUnicodeString, &gIsPresent) &&
       TestTenByteDetour()) {
     printf("TEST-PASS | WindowsDllInterceptor | all checks passed\n");
 

netwerk/protocol/data/DataChannelParent.cpp

@@ -71,7 +71,7 @@ DataChannelParent::SetClassifierMatchedInfo(const nsACString& aList,
 
 NS_IMETHODIMP
 DataChannelParent::SetClassifierMatchedTrackingInfo(
-    const nsACString &aLists, const nsACString &aFullHashes) {
+    const nsACString& aLists, const nsACString& aFullHashes) {
   // nothing to do
   return NS_OK;
 }

netwerk/protocol/file/FileChannelParent.cpp

@@ -71,7 +71,7 @@ FileChannelParent::SetClassifierMatchedInfo(const nsACString& aList,
 
 NS_IMETHODIMP
 FileChannelParent::SetClassifierMatchedTrackingInfo(
-    const nsACString &aLists, const nsACString &aFullHashes) {
+    const nsACString& aLists, const nsACString& aFullHashes) {
   // nothing to do
   return NS_OK;
 }

netwerk/protocol/http/nsHttpHandler.h

@@ -75,8 +75,12 @@ class AltSvcMapping;
  * FRAMECHECK_STRICT - we also do not allow case 2) and 3) from
  *                     FRAMECHECK_BARELY.
  */
-enum FrameCheckLevel { FRAMECHECK_LAX, FRAMECHECK_BARELY,
+enum FrameCheckLevel {
-                       FRAMECHECK_STRICT_CHUNKED, FRAMECHECK_STRICT };
+  FRAMECHECK_LAX,
+  FRAMECHECK_BARELY,
+  FRAMECHECK_STRICT_CHUNKED,
+  FRAMECHECK_STRICT
+};
 
 //-----------------------------------------------------------------------------
 // nsHttpHandler - protocol handler for HTTP and HTTPS

netwerk/protocol/http/nsHttpTransaction.cpp

@@ -1143,8 +1143,7 @@ void nsHttpTransaction::Close(nsresult reason) {
         // response that ends on exactly a chunk boundary also as partial.
         // Here a response must have the last 0-size chunk.
         if ((clevel == FRAMECHECK_STRICT) ||
-            (mChunkedDecoder &&
+            (mChunkedDecoder && (mChunkedDecoder->GetChunkRemaining() ||
-             (mChunkedDecoder->GetChunkRemaining() ||
                                  (clevel == FRAMECHECK_STRICT_CHUNKED))) ||
             (!mChunkedDecoder && !mContentDecoding && mContentDecodingCheck)) {
           reason = NS_ERROR_NET_PARTIAL_TRANSFER;

parser/html/nsHtml5PlainTextUtils.cpp

@@ -13,8 +13,7 @@
 // static
 nsHtml5HtmlAttributes* nsHtml5PlainTextUtils::NewLinkAttributes() {
   nsHtml5HtmlAttributes* linkAttrs = new nsHtml5HtmlAttributes(0);
-  nsHtml5String rel =
+  nsHtml5String rel = nsHtml5Portability::newStringFromLiteral("stylesheet");
-      nsHtml5Portability::newStringFromLiteral("stylesheet");
   linkAttrs->addAttribute(nsHtml5AttributeName::ATTR_REL, rel, -1);
   nsHtml5String href = nsHtml5Portability::newStringFromLiteral(
       "resource://content-accessible/plaintext.css");

security/manager/ssl/CSTrustDomain.cpp

@@ -31,9 +31,11 @@ static LazyLogModule gTrustDomainPRLog("CSTrustDomain");
 CSTrustDomain::CSTrustDomain(UniqueCERTCertList& certChain)
     : mCertChain(certChain),
 #ifdef MOZ_NEW_CERT_STORAGE
-      mCertBlocklist(do_GetService(NS_CERT_STORAGE_CID)) {}
+      mCertBlocklist(do_GetService(NS_CERT_STORAGE_CID)) {
+}
 #else
-      mCertBlocklist(do_GetService(NS_CERTBLOCKLIST_CONTRACTID)) {}
+      mCertBlocklist(do_GetService(NS_CERTBLOCKLIST_CONTRACTID)) {
+}
 #endif
 
 Result CSTrustDomain::GetCertTrust(EndEntityOrCA endEntityOrCA,

security/sandbox/win/SandboxInitialization.cpp

@@ -48,16 +48,18 @@ static BOOL WINAPI patched_DuplicateHandle(
                               dwDesiredAccess, bInheritHandle, dwOptions);
 }
 
-typedef BOOL (WINAPI* ApiSetQueryApiSetPresence_func)(PCUNICODE_STRING, PBOOLEAN);
+typedef BOOL(WINAPI* ApiSetQueryApiSetPresence_func)(PCUNICODE_STRING,
-static WindowsDllInterceptor::FuncHookType<ApiSetQueryApiSetPresence_func> stub_ApiSetQueryApiSetPresence;
+                                                     PBOOLEAN);
+static WindowsDllInterceptor::FuncHookType<ApiSetQueryApiSetPresence_func>
+    stub_ApiSetQueryApiSetPresence;
 
 static const WCHAR gApiSetNtUserWindowStation[] =
     L"ext-ms-win-ntuser-windowstation-l1-1-0";
 
 static BOOL WINAPI patched_ApiSetQueryApiSetPresence(
     PCUNICODE_STRING aNamespace, PBOOLEAN aPresent) {
-  if (aNamespace && aPresent && !wcsncmp(aNamespace->Buffer,
+  if (aNamespace && aPresent &&
-                                         gApiSetNtUserWindowStation,
+      !wcsncmp(aNamespace->Buffer, gApiSetNtUserWindowStation,
                aNamespace->Length / sizeof(WCHAR))) {
     *aPresent = FALSE;
     return TRUE;
@@ -99,9 +101,8 @@ static void EnableApiQueryInterception() {
   }
 
   gApiQueryIntercept.Init(L"Api-ms-win-core-apiquery-l1-1-0.dll");
-  DebugOnly<bool> hookSetOk =
+  DebugOnly<bool> hookSetOk = stub_ApiSetQueryApiSetPresence.Set(
-    stub_ApiSetQueryApiSetPresence.Set(gApiQueryIntercept,
+      gApiQueryIntercept, "ApiSetQueryApiSetPresence",
-                                       "ApiSetQueryApiSetPresence",
       &patched_ApiSetQueryApiSetPresence);
   MOZ_ASSERT(hookSetOk);
 }

toolkit/components/places/nsNavBookmarks.cpp

@@ -1763,7 +1763,8 @@ nsNavBookmarks::RemoveObserver(nsINavBookmarkObserver* aObserver) {
 }
 
 NS_IMETHODIMP
-nsNavBookmarks::GetObservers(nsTArray<RefPtr<nsINavBookmarkObserver>>& aObservers) {
+nsNavBookmarks::GetObservers(
+    nsTArray<RefPtr<nsINavBookmarkObserver>>& aObservers) {
   aObservers.Clear();
 
   if (!mCanNotify) return NS_OK;

toolkit/components/satchel/nsFormFillController.cpp

@@ -299,7 +299,8 @@ nsFormFillController::MarkAsLoginManagerField(HTMLInputElement* aInput) {
   }
 
   if (!mLoginManagerAC) {
-    mLoginManagerAC = do_GetService("@mozilla.org/login-manager/autocompletesearch;1");
+    mLoginManagerAC =
+        do_GetService("@mozilla.org/login-manager/autocompletesearch;1");
   }
 
   return NS_OK;
@@ -708,7 +709,8 @@ nsFormFillController::StartSearch(const nsAString& aSearchString,
     // MarkAsLoginManagerField wasn't called because password manager is
     // disabled.
     if (!mLoginManagerAC) {
-      mLoginManagerAC = do_GetService("@mozilla.org/login-manager/autocompletesearch;1");
+      mLoginManagerAC =
+          do_GetService("@mozilla.org/login-manager/autocompletesearch;1");
     }
 
     if (NS_WARN_IF(!mLoginManagerAC)) {
@@ -718,7 +720,8 @@ nsFormFillController::StartSearch(const nsAString& aSearchString,
     // XXX aPreviousResult shouldn't ever be a historyResult type, since we're
     // not letting satchel manage the field?
     mLastListener = aListener;
-    rv = mLoginManagerAC->StartSearch(aSearchString, aPreviousResult, mFocusedInput, this);
+    rv = mLoginManagerAC->StartSearch(aSearchString, aPreviousResult,
+                                      mFocusedInput, this);
     NS_ENSURE_SUCCESS(rv, rv);
   } else {
     MOZ_LOG(sLogger, LogLevel::Debug, ("StartSearch: non-login field"));

toolkit/components/sessionstore/SessionStoreListener.cpp

@@ -517,4 +517,4 @@ void TabListener::RemoveListeners() {
   }
 }
 
-TabListener::~TabListener() { RemoveListeners();}
+TabListener::~TabListener() { RemoveListeners(); }

toolkit/components/startup/nsAppStartup.cpp

@@ -548,7 +548,7 @@ nsAppStartup::GetWasRestarted(bool* aResult) {
 }
 
 NS_IMETHODIMP
-nsAppStartup::GetSecondsSinceLastOSRestart(int64_t *aResult) {
+nsAppStartup::GetSecondsSinceLastOSRestart(int64_t* aResult) {
 #if defined(XP_WIN)
   *aResult = int64_t(GetTickCount64() / 1000ull);
   return NS_OK;

toolkit/components/telemetry/tests/gtest/TelemetryTestHelpers.cpp

@@ -233,7 +233,8 @@ void GetEncodedOriginStrings(
     nsAutoJSString jsStr;
     ASSERT_TRUE(jsStr.init(aCx, encodingVal));
 
-    nsPrintfCString encoding(aEncoding.get(), i % TelemetryOrigin::SizeOfPrioDatasPerMetric());
+    nsPrintfCString encoding(aEncoding.get(),
+                             i % TelemetryOrigin::SizeOfPrioDatasPerMetric());
     ASSERT_TRUE(NS_ConvertUTF16toUTF8(jsStr) == encoding)
     << "Actual 'encoding' (" << NS_ConvertUTF16toUTF8(jsStr).get()
     << ") must match expected (" << encoding << ")";

toolkit/components/url-classifier/nsUrlClassifierPrefixSet.cpp

@@ -35,10 +35,8 @@ static LazyLogModule gUrlClassifierPrefixSetLog("UrlClassifierPrefixSet");
 NS_IMPL_ISUPPORTS(nsUrlClassifierPrefixSet, nsIUrlClassifierPrefixSet,
                   nsIMemoryReporter)
 
-
 nsUrlClassifierPrefixSet::nsUrlClassifierPrefixSet()
-    : mLock("nsUrlClassifierPrefixSet.mLock"),
+    : mLock("nsUrlClassifierPrefixSet.mLock"), mTotalPrefixes(0) {}
-      mTotalPrefixes(0) {}
 
 NS_IMETHODIMP
 nsUrlClassifierPrefixSet::Init(const nsACString& aName) {

toolkit/components/url-classifier/tests/gtest/TestVariableLengthPrefixSet.cpp

@@ -491,5 +491,7 @@ TEST_P(UrlClassifierPrefixSetTest, LoadSaveNoDelta) {
   file->Remove(false);
 }
 
-// To run the same test for different configurations of "browser_safebrowsing_prefixset_max_array_size"
+// To run the same test for different configurations of
-INSTANTIATE_TEST_CASE_P(UrlClassifierPrefixSetTest, UrlClassifierPrefixSetTest, ::testing::Values(0, UINT32_MAX));
+// "browser_safebrowsing_prefixset_max_array_size"
+INSTANTIATE_TEST_CASE_P(UrlClassifierPrefixSetTest, UrlClassifierPrefixSetTest,
+                        ::testing::Values(0, UINT32_MAX));

toolkit/recordreplay/MemorySnapshot.cpp

@@ -170,8 +170,7 @@ struct DirtyPageSet {
   InfallibleVector<DirtyPage, 256, AllocPolicy<MemoryKind::DirtyPageSet>>
       mPages;
 
-  explicit DirtyPageSet(size_t aCheckpoint)
+  explicit DirtyPageSet(size_t aCheckpoint) : mCheckpoint(aCheckpoint) {}
-      : mCheckpoint(aCheckpoint) {}
 };
 
 // Worklist used by each snapshot thread.

toolkit/recordreplay/ProcessRewind.cpp

@@ -65,8 +65,7 @@ void RestoreCheckpointAndResume(size_t aCheckpoint) {
   MOZ_RELEASE_ASSERT(IsReplaying());
   MOZ_RELEASE_ASSERT(Thread::CurrentIsMainThread());
   MOZ_RELEASE_ASSERT(!AreThreadEventsPassedThrough());
-  MOZ_RELEASE_ASSERT(
+  MOZ_RELEASE_ASSERT(aCheckpoint == gRewindInfo->mLastCheckpoint ||
-      aCheckpoint == gRewindInfo->mLastCheckpoint ||
                      aCheckpoint < gRewindInfo->mLastCheckpoint);
 
   // Make sure we don't lose pending main thread callbacks due to rewinding.
@@ -82,8 +81,7 @@ void RestoreCheckpointAndResume(size_t aCheckpoint) {
   {
     // Rewind heap memory to the target checkpoint, which must have been saved.
     AutoDisallowMemoryChanges disallow;
-    size_t newCheckpoint =
+    size_t newCheckpoint = gRewindInfo->mSavedCheckpoints.back().mCheckpoint;
-        gRewindInfo->mSavedCheckpoints.back().mCheckpoint;
     RestoreMemoryToLastSavedCheckpoint();
     while (aCheckpoint < newCheckpoint) {
       gRewindInfo->mSavedCheckpoints.back().ReleaseContents();
@@ -97,9 +95,8 @@ void RestoreCheckpointAndResume(size_t aCheckpoint) {
   FixupFreeRegionsAfterRewind();
 
   double end = CurrentTime();
-  PrintSpew("Restore #%d -> #%d %.2fs\n",
+  PrintSpew("Restore #%d -> #%d %.2fs\n", (int)gRewindInfo->mLastCheckpoint,
-            (int)gRewindInfo->mLastCheckpoint, (int)aCheckpoint,
+            (int)aCheckpoint, (end - start) / 1000000.0);
-            (end - start) / 1000000.0);
 
   // Finally, let threads restore themselves to their stacks at the checkpoint
   // we are rewinding to.

toolkit/recordreplay/ThreadSnapshot.h

@@ -76,8 +76,7 @@ struct SavedCheckpoint {
   size_t mCheckpoint;
   SavedThreadStack mStacks[MaxRecordedThreadId];
 
-  explicit SavedCheckpoint(size_t aCheckpoint)
+  explicit SavedCheckpoint(size_t aCheckpoint) : mCheckpoint(aCheckpoint) {}
-      : mCheckpoint(aCheckpoint) {}
 
   void ReleaseContents() {
     for (SavedThreadStack& stack : mStacks) {

toolkit/recordreplay/ipc/Channel.cpp

@@ -224,9 +224,7 @@ void Channel::SendMessage(Message&& aMsg) {
 
   PrintMessage("SendMsg", aMsg);
 
-  if (gSimulatedLatency &&
+  if (gSimulatedLatency && gSimulatedBandwidth && mSimulateDelays &&
-      gSimulatedBandwidth &&
-      mSimulateDelays &&
       MessageSubjectToSimulatedDelay(aMsg.mType)) {
     AutoEnsurePassThroughThreadEvents pt;
 

toolkit/recordreplay/ipc/ChildIPC.cpp

@@ -150,8 +150,8 @@ static void ListenForCheckpointThreadMain(void*) {
     uint8_t data = 0;
     ssize_t rv = HANDLE_EINTR(read(gCheckpointReadFd, &data, 1));
     if (rv > 0) {
-      NS_DispatchToMainThread(NewRunnableFunction("NewCheckpoint",
+      NS_DispatchToMainThread(
-                                                  NewCheckpoint));
+          NewRunnableFunction("NewCheckpoint", NewCheckpoint));
     } else {
       MOZ_RELEASE_ASSERT(errno == EIO);
       MOZ_RELEASE_ASSERT(HasDivergedFromRecording());
@@ -488,8 +488,8 @@ static void PaintFromMainThread() {
 
   if (IsMainChild() && gDrawTargetBuffer) {
     memcpy(gGraphicsShmem, gDrawTargetBuffer, gDrawTargetBufferSize);
-    gChannel->SendMessage(PaintMessage(GetLastCheckpoint(),
+    gChannel->SendMessage(
-                                       gPaintWidth, gPaintHeight));
+        PaintMessage(GetLastCheckpoint(), gPaintWidth, gPaintHeight));
   }
 }
 

toolkit/recordreplay/ipc/JSControl.cpp

@@ -313,9 +313,7 @@ void SetupDevtoolsSandbox() {
   InitializeScriptHits();
 }
 
-bool IsInitialized() {
+bool IsInitialized() { return !!gReplay; }
-  return !!gReplay;
-}
 
 extern "C" {
 
@@ -574,8 +572,8 @@ static bool RecordReplay_AreThreadEventsDisallowed(JSContext* aCx,
   return true;
 }
 
-static bool RecordReplay_DivergeFromRecording(JSContext* aCx,
+static bool RecordReplay_DivergeFromRecording(JSContext* aCx, unsigned aArgc,
-                                              unsigned aArgc, Value* aVp) {
+                                              Value* aVp) {
   CallArgs args = CallArgsFromVp(aArgc, aVp);
   DivergeFromRecording();
   args.rval().setUndefined();
@@ -585,7 +583,7 @@ static bool RecordReplay_DivergeFromRecording(JSContext* aCx,
 static bool RecordReplay_ProgressCounter(JSContext* aCx, unsigned aArgc,
                                          Value* aVp) {
   CallArgs args = CallArgsFromVp(aArgc, aVp);
-  args.rval().setNumber((double) gProgressCounter);
+  args.rval().setNumber((double)gProgressCounter);
   return true;
 }
 
@@ -765,8 +763,8 @@ struct ScriptHitInfo {
     // The most recent checkpoint prior to the hit.
     uint32_t mCheckpoint;
 
-    // Index of the frame where the hit occurred, or UINT32_MAX if this represents
+    // Index of the frame where the hit occurred, or UINT32_MAX if this
-    // an aggregate set of hits after the checkpoint.
+    // represents an aggregate set of hits after the checkpoint.
     uint32_t mFrameIndex;
 
     // Progress counter when the hit occurred, invalid if this represents an
@@ -778,7 +776,8 @@ struct ScriptHitInfo {
 
     ScriptHit(uint32_t aCheckpoint, uint32_t aFrameIndex,
               ProgressCounter aProgress)
-        : mCheckpoint(aCheckpoint), mFrameIndex(aFrameIndex),
+        : mCheckpoint(aCheckpoint),
+          mFrameIndex(aFrameIndex),
           mProgress(aProgress) {}
   };
 
@@ -801,13 +800,14 @@ struct ScriptHitInfo {
     }
 
     static bool match(const ScriptHitKey& aFirst, const ScriptHitKey& aSecond) {
-      return aFirst.mScript == aSecond.mScript
+      return aFirst.mScript == aSecond.mScript &&
-          && aFirst.mOffset == aSecond.mOffset;
+             aFirst.mOffset == aSecond.mOffset;
     }
   };
 
   typedef HashMap<ScriptHitKey, ScriptHitChunk*, ScriptHitKey,
-                  AllocPolicy<MemoryKind::ScriptHits>> ScriptHitMap;
+                  AllocPolicy<MemoryKind::ScriptHits>>
+      ScriptHitMap;
   ScriptHitMap mTable;
   ScriptHitChunk* mFreeChunk;
 
@@ -871,8 +871,7 @@ static bool RecordReplay_AddScriptHit(JSContext* aCx, unsigned aArgc,
                                       Value* aVp) {
   CallArgs args = CallArgsFromVp(aArgc, aVp);
 
-  if (!args.get(0).isNumber() ||
+  if (!args.get(0).isNumber() || !args.get(1).isNumber() ||
-      !args.get(1).isNumber() ||
       !args.get(2).isNumber()) {
     JS_ReportErrorASCII(aCx, "Bad parameters");
     return false;
@@ -909,12 +908,12 @@ static bool RecordReplay_FindScriptHits(JSContext* aCx, unsigned aArgc,
       if (hit.mCheckpoint) {
         RootedObject hitObject(aCx, JS_NewObject(aCx, nullptr));
         if (!hitObject ||
-            !JS_DefineProperty(aCx, hitObject, "checkpoint",
+            !JS_DefineProperty(aCx, hitObject, "checkpoint", hit.mCheckpoint,
-                               hit.mCheckpoint, JSPROP_ENUMERATE) ||
+                               JSPROP_ENUMERATE) ||
             !JS_DefineProperty(aCx, hitObject, "progress",
-                               (double) hit.mProgress, JSPROP_ENUMERATE) ||
+                               (double)hit.mProgress, JSPROP_ENUMERATE) ||
-            !JS_DefineProperty(aCx, hitObject, "frameIndex",
+            !JS_DefineProperty(aCx, hitObject, "frameIndex", hit.mFrameIndex,
-                               hit.mFrameIndex, JSPROP_ENUMERATE) ||
+                               JSPROP_ENUMERATE) ||
             !values.append(ObjectValue(*hitObject))) {
           return false;
         }

toolkit/recordreplay/ipc/JSControl.h

@@ -21,7 +21,7 @@ namespace recordreplay {
 struct Message;
 
 namespace parent {
-  class ChildProcessInfo;
+class ChildProcessInfo;
 }
 
 namespace js {

toolkit/xre/LauncherRegistryInfo.cpp

@@ -105,9 +105,9 @@ LauncherVoidResult LauncherRegistryInfo::ReflectTelemetryPrefToRegistry(
 
   DWORD value = aEnable ? 1UL : 0UL;
   DWORD len = sizeof(value);
-  LSTATUS result = ::RegSetValueExW(mRegKey.get(), valueName.c_str(), 0,
+  LSTATUS result =
-                                    REG_DWORD, reinterpret_cast<PBYTE>(&value),
+      ::RegSetValueExW(mRegKey.get(), valueName.c_str(), 0, REG_DWORD,
-                                    len);
+                       reinterpret_cast<PBYTE>(&value), len);
   if (result != ERROR_SUCCESS) {
     return LAUNCHER_ERROR_FROM_WIN32(result);
   }
@@ -443,9 +443,9 @@ LauncherResult<bool> LauncherRegistryInfo::GetTelemetrySetting() {
   DWORD value;
   DWORD valueLen = sizeof(value);
   DWORD type;
-  LSTATUS result = ::RegQueryValueExW(
+  LSTATUS result =
-      mRegKey.get(), telemetryValueName.c_str(), nullptr, &type,
+      ::RegQueryValueExW(mRegKey.get(), telemetryValueName.c_str(), nullptr,
-      reinterpret_cast<PBYTE>(&value), &valueLen);
+                         &type, reinterpret_cast<PBYTE>(&value), &valueLen);
   if (result == ERROR_FILE_NOT_FOUND) {
     // Value does not exist, treat as false
     return false;

toolkit/xre/LauncherRegistryInfo.h

@@ -43,9 +43,9 @@ class LauncherRegistryInfo final {
   LauncherResult<EnabledState> IsEnabled();
   LauncherResult<bool> IsTelemetryEnabled();
   LauncherVoidResult ReflectTelemetryPrefToRegistry(const bool aEnable);
-  LauncherResult<ProcessType> Check(const ProcessType aDesiredType,
+  LauncherResult<ProcessType> Check(
-                                    const CheckOption aOption =
+      const ProcessType aDesiredType,
-                                      CheckOption::Default);
+      const CheckOption aOption = CheckOption::Default);
   LauncherVoidResult DisableDueToFailure();
 
  private:

uriloader/exthandler/nsExternalProtocolHandler.cpp

@@ -407,7 +407,7 @@ NS_IMETHODIMP nsExtProtocolChannel::SetClassifierMatchedInfo(
 }
 
 NS_IMETHODIMP nsExtProtocolChannel::SetClassifierMatchedTrackingInfo(
-    const nsACString &aLists, const nsACString &aFullHashes) {
+    const nsACString& aLists, const nsACString& aFullHashes) {
   // nothing to do
   return NS_OK;
 }

widget/cocoa/GfxInfo.mm

@@ -236,17 +236,18 @@ void GfxInfo::AddCrashReportAnnotations() {
 }
 
 // We don't support checking driver versions on Mac.
-#define IMPLEMENT_MAC_DRIVER_BLOCKLIST(os, vendor, driverVendor, device, features, blockOn, ruleId)          \
+#define IMPLEMENT_MAC_DRIVER_BLOCKLIST(os, vendor, driverVendor, device, features, blockOn, \
-  APPEND_TO_DRIVER_BLOCKLIST(os, vendor, driverVendor, device, features, blockOn, DRIVER_COMPARISON_IGNORED, \
+                                       ruleId)                                              \
-                             V(0, 0, 0, 0), ruleId, "")
+  APPEND_TO_DRIVER_BLOCKLIST(os, vendor, driverVendor, device, features, blockOn,           \
+                             DRIVER_COMPARISON_IGNORED, V(0, 0, 0, 0), ruleId, "")
 
 const nsTArray<GfxDriverInfo>& GfxInfo::GetGfxDriverInfo() {
   if (!sDriverInfo->Length()) {
     IMPLEMENT_MAC_DRIVER_BLOCKLIST(
         OperatingSystem::OSX, (nsAString&)GfxDriverInfo::GetDeviceVendor(VendorATI),
-        (nsAString&)GfxDriverInfo::GetDriverVendor(DriverVendorAll),
+        (nsAString&)GfxDriverInfo::GetDriverVendor(DriverVendorAll), GfxDriverInfo::allDevices,
-        GfxDriverInfo::allDevices, nsIGfxInfo::FEATURE_WEBGL_MSAA,
+        nsIGfxInfo::FEATURE_WEBGL_MSAA, nsIGfxInfo::FEATURE_BLOCKED_OS_VERSION,
-        nsIGfxInfo::FEATURE_BLOCKED_OS_VERSION, "FEATURE_FAILURE_MAC_ATI_NO_MSAA");
+        "FEATURE_FAILURE_MAC_ATI_NO_MSAA");
     IMPLEMENT_MAC_DRIVER_BLOCKLIST(
         OperatingSystem::OSX, (nsAString&)GfxDriverInfo::GetDeviceVendor(VendorATI),
         (nsAString&)GfxDriverInfo::GetDriverVendor(DriverVendorAll),

xpcom/base/nsMacUtilsImpl.h

@@ -55,11 +55,7 @@ class nsMacUtilsImpl final : public nsIMacUtils {
   static StaticMutex sCachedAppPathMutex;
 #endif
 
-  enum TCSMStatus {
+  enum TCSMStatus { TCSM_Unknown = 0, TCSM_Available, TCSM_Unavailable };
-    TCSM_Unknown = 0,
-    TCSM_Available,
-    TCSM_Unavailable
-  };
   static mozilla::Atomic<nsMacUtilsImpl::TCSMStatus> sTCSMStatus;
 
   static nsresult EnableTCSM();

xpcom/base/nsSystemInfo.cpp

@@ -169,11 +169,12 @@ nsresult GetHDDInfo(const char* aSpecialDirName, nsAutoCString& aModel,
     bytesRead = 0;
     DEVICE_SEEK_PENALTY_DESCRIPTOR seekPenaltyDescriptor = {
         sizeof(DEVICE_SEEK_PENALTY_DESCRIPTOR)};
-    if (::DeviceIoControl(handle, IOCTL_STORAGE_QUERY_PROPERTY, &queryParameters,
+    if (::DeviceIoControl(handle, IOCTL_STORAGE_QUERY_PROPERTY,
-          sizeof(queryParameters), &seekPenaltyDescriptor,
+                          &queryParameters, sizeof(queryParameters),
-          sizeof(seekPenaltyDescriptor), &bytesRead, nullptr)) {
+                          &seekPenaltyDescriptor, sizeof(seekPenaltyDescriptor),
-      // It is possible that the disk has TrimEnabled, but also IncursSeekPenalty;
+                          &bytesRead, nullptr)) {
-      // In this case, this is an HDD
+      // It is possible that the disk has TrimEnabled, but also
+      // IncursSeekPenalty; In this case, this is an HDD
       if (seekPenaltyDescriptor.IncursSeekPenalty) {
         isSSD = false;
       }

xpcom/io/nsLocalFileWin.cpp

@@ -1695,12 +1695,12 @@ nsresult nsLocalFile::CopySingleFile(nsIFile* aSourceFile, nsIFile* aDestParent,
 
     // Pass the flag COPY_FILE_NO_BUFFERING to CopyFileEx as we may be copying
     // to a SMBV2 remote drive. Without this parameter subsequent append mode
-    // file writes can cause the resultant file to become corrupt. We only need to
+    // file writes can cause the resultant file to become corrupt. We only need
-    // do this if the major version of Windows is > 5(Only Windows Vista and above
+    // to do this if the major version of Windows is > 5(Only Windows Vista and
-    // can support SMBV2).  With a 7200RPM hard drive:
+    // above can support SMBV2).  With a 7200RPM hard drive: Copying a 1KB file
-    // Copying a 1KB file with COPY_FILE_NO_BUFFERING takes about 30-60ms.
+    // with COPY_FILE_NO_BUFFERING takes about 30-60ms. Copying a 1KB file
-    // Copying a 1KB file without COPY_FILE_NO_BUFFERING takes < 1ms.
+    // without COPY_FILE_NO_BUFFERING takes < 1ms. So we only use
-    // So we only use COPY_FILE_NO_BUFFERING when we have a remote drive.
+    // COPY_FILE_NO_BUFFERING when we have a remote drive.
     DWORD dwCopyFlags = COPY_FILE_ALLOW_DECRYPTED_DESTINATION;
     bool path1Remote, path2Remote;
     if (!IsRemoteFilePath(filePath.get(), path1Remote) ||

xpcom/threads/PrioritizedEventQueue.cpp

@@ -14,10 +14,9 @@
 
 using namespace mozilla;
 
-void PrioritizedEventQueue::PutEvent(
+void PrioritizedEventQueue::PutEvent(already_AddRefed<nsIRunnable>&& aEvent,
-    already_AddRefed<nsIRunnable>&& aEvent, EventQueuePriority aPriority,
+                                     EventQueuePriority aPriority,
                                      const MutexAutoLock& aProofOfLock) {
-
   // Double check the priority with a QI.
   RefPtr<nsIRunnable> event(aEvent);
   EventQueuePriority priority = aPriority;
@@ -256,8 +255,7 @@ already_AddRefed<nsIRunnable> PrioritizedEventQueue::GetEvent(
   return event.forget();
 }
 
-bool PrioritizedEventQueue::IsEmpty(
+bool PrioritizedEventQueue::IsEmpty(const MutexAutoLock& aProofOfLock) {
-    const MutexAutoLock& aProofOfLock) {
   // Just check IsEmpty() on the sub-queues. Don't bother checking the idle
   // deadline since that only determines whether an idle event is ready or not.
   return mHighQueue->IsEmpty(aProofOfLock) &&
@@ -268,8 +266,7 @@ bool PrioritizedEventQueue::IsEmpty(
          mIdleQueue->IsEmpty(aProofOfLock);
 }
 
-bool PrioritizedEventQueue::HasReadyEvent(
+bool PrioritizedEventQueue::HasReadyEvent(const MutexAutoLock& aProofOfLock) {
-    const MutexAutoLock& aProofOfLock) {
   mHasPendingEventsPromisedIdleEvent = false;
 
   EventQueuePriority queue = SelectQueue(false, aProofOfLock);
@@ -309,8 +306,7 @@ bool PrioritizedEventQueue::HasPendingHighPriorityEvents(
   return !mHighQueue->IsEmpty(aProofOfLock);
 }
 
-size_t PrioritizedEventQueue::Count(
+size_t PrioritizedEventQueue::Count(const MutexAutoLock& aProofOfLock) const {
-    const MutexAutoLock& aProofOfLock) const {
   MOZ_CRASH("unimplemented");
 }
 

xpcom/threads/ThrottledEventQueue.cpp

@@ -254,8 +254,7 @@ class ThrottledEventQueue::Inner final : public nsISupports {
 
  public:
   static already_AddRefed<Inner> Create(nsISerialEventTarget* aBaseTarget,
-                                        const char* aName,
+                                        const char* aName, uint32_t aPriority) {
-                                        uint32_t aPriority) {
     MOZ_ASSERT(NS_IsMainThread());
     MOZ_ASSERT(ClearOnShutdown_Internal::sCurrentShutdownPhase ==
                ShutdownPhase::NotInShutdown);

xpcom/threads/ThrottledEventQueue.h

@@ -68,8 +68,7 @@ class ThrottledEventQueue final : public nsISerialEventTarget {
  public:
   // Create a ThrottledEventQueue for the given target.
   static already_AddRefed<ThrottledEventQueue> Create(
-      nsISerialEventTarget* aBaseTarget,
+      nsISerialEventTarget* aBaseTarget, const char* aName,
-      const char* aName,
       uint32_t aPriority = nsIRunnablePriority::PRIORITY_NORMAL);
 
   // Determine if there are any events pending in the queue.