Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-02 15:15:23 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Comments for JSOP_{,STRICT}{EQ,NE} about the layering and constraints on evolution of the non-strict equality ops' recorders.

Browse Source
This commit is contained in:
Brendan Eich 2008-08-11 23:44:43 -07:00
parent 7c6039450b
commit d5a31d6582
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
js/src/jstracer.cpp
View File

@ -2705,6 +2705,7 @@ TraceRecorder::record_JSOP_BITAND()
return binary(LIR_and);
}
// See FIXME for JSOP_STRICTEQ before evolving JSOP_EQ to handle mixed types.
bool
TraceRecorder::record_JSOP_EQ()
{
@ -2746,6 +2747,7 @@ TraceRecorder::record_JSOP_EQ()
return cmp(LIR_feq);
}
// See FIXME for JSOP_STRICTNE before evolving JSOP_NE to handle mixed types.
bool
TraceRecorder::record_JSOP_NE()
{
@ -3721,12 +3723,18 @@ TraceRecorder::record_JSOP_LOOKUPSWITCH()
bool
TraceRecorder::record_JSOP_STRICTEQ()
{
// FIXME: JSOP_EQ currently compares only like operand types; if it evolves
// to handle conversions we must insist on like "types" here (care required
// for 0 == -1, e.g.).
return record_JSOP_EQ();
}
bool
TraceRecorder::record_JSOP_STRICTNE()
{
// FIXME: JSOP_NE currently compares only like operand types; if it evolves
// to handle conversions we must insist on like "types" here (care required
// for 0 == -1, e.g.).
return record_JSOP_NE();
}