Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-26 06:11:37 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 282743 ABBA deadlock componentmanager monitor/jsgc claimscope

Browse Source 
r=dougt sr=bz
This commit is contained in:
timeless%mozdev.org 2005-02-18 22:46:24 +00:00
parent 54a988d483
commit d5a44a6b73
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
xpcom/components/nsComponentManager.cpp
View File

@ -2365,7 +2365,13 @@ nsComponentManagerImpl::GetServiceByContractID(const char* aContractID,
if (entry) {
if (entry->mServiceObject) {
return entry->mServiceObject->QueryInterface(aIID, result);
nsCOMPtr<nsISupports> serviceObject = entry->mServiceObject;
// We need to not be holding the service manager's monitor while calling
// QueryInterface, because it invokes user code which could try to re-enter
// the service manager, or try to grab some other lock/monitor/condvar
// and deadlock, e.g. bug 282743.
mon.Exit();
return serviceObject->QueryInterface(aIID, result);
}
#ifdef XPCOM_CHECK_PENDING_CIDS
rv = AddPendingCID(entry->mCid);