Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-17 22:32:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1320987 - Stop leaking tabs during test_session_zombification. r=gbrown

Browse Source 
A subtest's cleanup function only runs at the very end, after *all* subtests have finished. This means that we cannot use it to close the test tabs if we want to reuse the tab variables during following subtests. If we did, we'd be leaking those previous tabs, meaning they remain open at the end of the test and cause possible problems for following tests as well as lots of "Unable to restore focus" messages in the log.

MozReview-Commit-ID: H87JQ5gcIAg

--HG--
extra : rebase_source : 5e870acba4c8ee05557f1ac0175bda12606b4e28
This commit is contained in:
Jan Henning 2016-11-30 21:53:33 +01:00
parent 90fd151cc8
commit d67b48b711
1 changed files with 20 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
mobile/android/tests/browser/chrome/test_session_zombification.html
View File

@ -33,22 +33,31 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=1044556
});
// The chrome window
let chromeWin;
let chromeWin = Services.wm.getMostRecentWindow("navigator:browser");
let BrowserApp = chromeWin.BrowserApp;
// Track the tabs where the tests are happening
let tabBlank;
let tabTest;
function cleanupTabs() {
if (tabBlank) {
BrowserApp.closeTab(tabBlank);
tabBlank = null;
}
if (tabTest) {
BrowserApp.closeTab(tabTest);
tabTest = null;
}
}
const url1 = "data:text/html;charset=utf-8,It%20was%20a%20dark%20and%20stormy%20night.";
const url2 = "data:text/html;charset=utf-8,Suddenly%2C%20a%20tab%20was%20zombified.";
add_task(function* test_sessionStoreZombify() {
chromeWin = Services.wm.getMostRecentWindow("navigator:browser");
let BrowserApp = chromeWin.BrowserApp;
SimpleTest.registerCleanupFunction(function() {
BrowserApp.closeTab(tabBlank);
BrowserApp.closeTab(tabTest);
cleanupTabs();
});
// Add a new tab with some content
@ -94,16 +103,15 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=1044556
// Check that the test tab has loaded the correct url
is(tabTest.browser.currentURI.spec, url2, "Test tab is showing the second URL.");
cleanupTabs();
});
add_task(function* test_sessionStoreKeepAsZombie() {
chromeWin = Services.wm.getMostRecentWindow("navigator:browser");
let BrowserApp = chromeWin.BrowserApp;
let observerService = Services.obs;
SimpleTest.registerCleanupFunction(function() {
BrowserApp.closeTab(tabBlank);
BrowserApp.closeTab(tabTest);
cleanupTabs();
});
// Add a new tab with some content
@ -169,6 +177,8 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=1044556
yield promiseBrowserEvent(tabTest.browser, "DOMContentLoaded");
ok(!tabTest.browser.__SS_restore, "Test tab is no longer set for delay loading.");
is(tabTest.browser.currentURI.spec, url1, "Test tab is showing the test URL.");
cleanupTabs();
});
</script>