Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-24 13:21:05 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1758975 - Ensure GIF color tables are opaque by default. r=tnikkel

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D141176
This commit is contained in:
Andrew Osmond 2022-03-18 15:22:46 +00:00
parent c37c29dca4
commit d70a78efc1
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
image/decoders/nsGIFDecoder2.cpp
View File

@ -91,8 +91,10 @@ nsGIFDecoder2::nsGIFDecoder2(RasterImage* aImage)
mGIFOpen(false),
mSawTransparency(false),
mSwizzleFn(nullptr) {
// Clear out the structure, excluding the arrays.
// Clear out the structure, excluding the arrays. Ensure that the global
// colormap is initialized as opaque.
memset(&mGIFStruct, 0, sizeof(mGIFStruct));
memset(mGIFStruct.global_colormap, 0xFF, sizeof(mGIFStruct.global_colormap));
// Each color table will need to be unpacked.
mSwizzleFn = SwizzleRow(SurfaceFormat::R8G8B8, SurfaceFormat::OS_RGBA);
@ -855,6 +857,8 @@ LexerTransition<nsGIFDecoder2::State> nsGIFDecoder2::FinishImageDescriptor(
mGIFStruct.local_colormap_buffer_size = mColormapSize;
mGIFStruct.local_colormap =
static_cast<uint32_t*>(moz_xmalloc(mColormapSize));
// Ensure the local colormap is initialized as opaque.
memset(mGIFStruct.local_colormap, 0xFF, mColormapSize);
} else {
mColormapSize = mGIFStruct.local_colormap_buffer_size;
}