Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-12-13 18:27:35 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1271015 patch 2 - Add tests for things not happening (optimizations) in response to media query changes. r=heycam

Browse Source 
This adds a few basic tests for expectations of when we do and don't
restyle, construct frames, and reflow in response to changes of media
queries.  They don't give us a lot of coverage, but often the tiny bits
of coverage at the beginning are the most useful.

In general, I'd like us to have more tests for specific optimizations,
i.e., for specific things that we expect not to happen in certain cases.
The elementsRestyled, framesConstructed, and framesReflowed getters on
DOMWindowUtils are a good way to make such measurements for a number of
things in layout; that's why I added them.

(Inspired a bit by bug 1259641.)

MozReview-Commit-ID: JFtlPO1eyoD
This commit is contained in:
L. David Baron 2016-05-09 11:26:35 -07:00
parent 91233fe6f4
commit d7641eeef2
1 changed files with 92 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

92
layout/style/test/test_media_queries_dynamic.html
View File

@ -111,6 +111,98 @@ function run() {
SpecialPowers.setFullZoom(subwin, 1.0);
is(subwin.innerHeight, 228, "full zoom is 1.0");
// Now test that certain things *don't* happen, i.e., that we're
// making the optimizations we expect.
subdoc.body.textContent = "";
subdoc.body.appendChild(subdoc.createElement("div"));
for (var ruleIdx = sheet.cssRules.length; ruleIdx-- != 0; ) {
sheet.deleteRule(ruleIdx);
}
var utils = SpecialPowers.getDOMWindowUtils(subwin);
var elementsRestyled, framesConstructed, framesReflowed;
function reset_change_counters()
{
elementsRestyled = utils.elementsRestyled;
framesConstructed = utils.framesConstructed;
framesReflowed = utils.framesReflowed;
}
function flush_and_assert_change_counters(desc, expected) {
subdoc.body.offsetHeight;
if (!("restyle" in expected) ||
!("construct" in expected) ||
!("reflow" in expected)) {
ok(false, "parameter missing expectation");
return;
}
var restyles = utils.elementsRestyled - elementsRestyled;
var constructs = utils.framesConstructed - framesConstructed;
var reflows = utils.framesReflowed - framesReflowed;
(expected.restyle ? isnot : is)(restyles, 0, "restyle count: " + desc);
(expected.construct ? isnot : is)(constructs, 0,
"frame construct count: " + desc);
(expected.reflow ? isnot : is)(reflows, 0, "reflow count: " + desc);
reset_change_counters();
}
subdoc.body.offsetHeight;
reset_change_counters();
iframe_style.width = "103px";
flush_and_assert_change_counters("change width with no media queries",
{ restyle: false, construct: false, reflow: true });
flush_and_assert_change_counters("no change",
{ restyle: false, construct: false, reflow: false });
iframe_style.height = "123px";
flush_and_assert_change_counters("change height with no media queries",
{ restyle: false, construct: false, reflow: true });
sheet.insertRule("@media (min-width: 150px) { div { display:flex } }", 0);
flush_and_assert_change_counters("add non-matching media query",
// FIXME: We restyle here because
// nsIPresShell::RestyleForCSSRuleChanges posts a restyle, but it's
// probably avoidable if we wanted to avoid it.
{ restyle: true, construct: false, reflow: false });
iframe_style.width = "177px";
flush_and_assert_change_counters("resize width across media query with 'display'",
{ restyle: true, construct: true, reflow: true });
iframe_style.width = "162px";
flush_and_assert_change_counters("resize width without crossing media query",
{ restyle: false, construct: false, reflow: true });
sheet.deleteRule(0);
flush_and_assert_change_counters("remove matching media query with 'display'",
{ restyle: true, construct: true, reflow: true });
sheet.insertRule("@media (max-height: 150px) { div { display:flex } }", 0);
flush_and_assert_change_counters("add matching media query with 'display'",
{ restyle: true, construct: true, reflow: true });
iframe_style.height = "111px";
flush_and_assert_change_counters("resize height without crossing media query",
{ restyle: false, construct: false, reflow: true });
iframe_style.height = "184px";
flush_and_assert_change_counters("resize height across media query with 'display'",
{ restyle: true, construct: true, reflow: true });
sheet.deleteRule(0);
flush_and_assert_change_counters("remove non-matching media query",
// FIXME: We restyle here because
// nsIPresShell::RestyleForCSSRuleChanges posts a restyle, but it's
// probably avoidable if we wanted to avoid it.
{ restyle: true, construct: false, reflow: false });
SimpleTest.finish();
}