From d7db229da6d78aab4090e8eef5e6cac39c81dfbe Mon Sep 17 00:00:00 2001 From: Nicolas Silva Date: Wed, 3 Sep 2014 14:59:36 +0200 Subject: [PATCH] Bug 1061209 - Fix WError build failure on a CLOSED TREE --- widget/xpwidgets/nsBaseWidget.cpp | 24 ++++++++---------------- 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/widget/xpwidgets/nsBaseWidget.cpp b/widget/xpwidgets/nsBaseWidget.cpp index 43984a6d99c5..86f595847df3 100644 --- a/widget/xpwidgets/nsBaseWidget.cpp +++ b/widget/xpwidgets/nsBaseWidget.cpp @@ -872,19 +872,6 @@ nsBaseWidget::GetPreferredCompositorBackends(nsTArray& aHints) aHints.AppendElement(LayersBackend::LAYERS_BASIC); } -static void -RemoveBasicBackend(nsTArray& aHints) -{ -#ifndef XP_WIN - for (size_t i = 0; i < aHints.Length(); ++i) { - if (aHints[i] == LayersBackend::LAYERS_BASIC && - !Preferences::GetBool("layers.offmainthreadcomposition.force-basic", false)) { - aHints[i] = LayersBackend::LAYERS_NONE; - } - } -#endif -} - void nsBaseWidget::CreateCompositor(int aWidth, int aHeight) { MOZ_ASSERT(gfxPlatform::UsesOffMainThreadCompositing(), @@ -914,9 +901,14 @@ void nsBaseWidget::CreateCompositor(int aWidth, int aHeight) nsTArray backendHints; GetPreferredCompositorBackends(backendHints); -#ifndef MOZ_X11 - if (!mRequireOffMainThreadCompositing) { - RemoveBasicBackend(backendHints); +#if !defined(MOZ_X11) && !defined(XP_WIN) + if (!mRequireOffMainThreadCompositing && + !Preferences::GetBool("layers.offmainthreadcomposition.force-basic", false)) { + for (size_t i = 0; i < backendHints.Length(); ++i) { + if (backendHints[i] == LayersBackend::LAYERS_BASIC) { + backendHints[i] = LayersBackend::LAYERS_NONE; + } + } } #endif