Bug 1569128 [wpt PR 18108] - Revert "[LargestContentfulPaint] Set startTime", a=testonly

Automatic update from web-platform-tests
Revert "[LargestContentfulPaint] Set startTime"

This reverts commit 58051e426031caabd8ae28b96a9be1f92f3cd913.

Reason for revert: Most suspicious CL for failing paint-related test
failures as mentioned in the linked bug.

Bug: 987915

Original change's description:
> [LargestContentfulPaint] Set startTime
>
> Currently startTime is 0, which is a problem because getEntries()
> methods all sort by startTime. To help with this problem, we set the
> startTime to renderTime, if available, or to loadTime, if renderTime is
> nt available.
>
> Bug: 965505
> Change-Id: Ie70b69269f7ce4be0fdc94f33a44a84e062d3ba5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719379
> Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#681147}

TBR=npm@chromium.org,yoavweiss@chromium.org

Change-Id: Ie810b8a3ac88369ab73a66670865f462f590e1ec
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 965505
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719351
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681224}

--

wpt-commits: bc60e6f82132cfc9a5b688c566c7772024b3c15c
wpt-pr: 18108
This commit is contained in:
Friedrich [CET] 2019-08-01 14:31:58 +00:00 committed by moz-wptsync-bot
parent e73e00a7a0
commit d7f418f046
8 changed files with 8 additions and 8 deletions

View File

@ -25,7 +25,7 @@
'The rendering timestamp should occur after script starts running.');
assert_greater_than_equal(performance.now(), entry.renderTime,
'The rendering timestamp should occur before the entry is dispatched to the observer.');
assert_equals(entry.startTime, entry.renderTime, 'startTime should equal renderTime');
assert_equals(entry.startTime, 0);
assert_equals(entry.duration, 0);
// black-rectangle.png is 100 x 50. It occupies 50 x 50 so size will be bounded by the displayed size.
assert_equals(entry.size, 2500);

View File

@ -16,7 +16,7 @@
const entry = entryList.getEntries()[0];
assert_equals(entry.entryType, 'largest-contentful-paint');
assert_equals(entry.renderTime, 0, 'The renderTime value should be 0 for a cross origin image.');
assert_equals(entry.startTime, entry.loadTime, 'startTime should equal loadTime');
assert_equals(entry.startTime, 0);
assert_equals(entry.duration, 0);
// blue.png is 133 x 106.
assert_equals(entry.size, 14098);

View File

@ -25,7 +25,7 @@
'The rendering timestamp should occur after script starts running.');
assert_greater_than_equal(performance.now(), entry.renderTime,
'The rendering timestamp should occur before the entry is dispatched to the observer.');
assert_equals(entry.startTime, entry.renderTime, 'startTime should equal renderTime');
assert_equals(entry.startTime, 0);
assert_equals(entry.duration, 0);
// black-rectangle.png is 100 x 50. It occupies 300 x 300 so size will be bounded by the intrinsic size.
assert_equals(entry.size, 5000);

View File

@ -21,7 +21,7 @@
'The rendering timestamp should occur after script starts running.');
assert_greater_than_equal(performance.now(), entry.renderTime,
'The rendering timestamp should occur before the entry is dispatched to the observer.');
assert_equals(entry.startTime, entry.renderTime, 'startTime should equal renderTime');
assert_equals(entry.startTime, 0);
assert_equals(entry.duration, 0);
if (firstCallback) {
// blue.png is 133 x 106.

View File

@ -15,7 +15,7 @@
assert_equals(entryList.getEntries().length, 1);
const entry = entryList.getEntries()[0];
assert_equals(entry.entryType, 'largest-contentful-paint');
assert_equals(entry.startTime, entry.renderTime, 'startTime should equal renderTime');
assert_equals(entry.startTime, 0);
assert_equals(entry.duration, 0);
assert_equals(entry.url, window.location.origin + '/images/black-rectangle.png');
assert_greater_than(entry.renderTime, entry.loadTime,

View File

@ -19,7 +19,7 @@
'The rendering timestamp should occur after script starts running.');
assert_greater_than_equal(performance.now(), entry.renderTime,
'The rendering timestamp should occur before the entry is dispatched to the observer.');
assert_equals(entry.startTime, entry.renderTime, 'startTime should equal renderTime');
assert_equals(entry.startTime, 0);
assert_equals(entry.duration, 0);
// blue.png is 133 x 106.
assert_equals(entry.size, 14098);

View File

@ -22,7 +22,7 @@ p {
assert_equals(entry.entryType, 'largest-contentful-paint');
assert_greater_than_equal(entry.renderTime, beforeRender);
assert_greater_than_equal(performance.now(), entry.renderTime);
assert_equals(entry.startTime, entry.renderTime, 'startTime should equal renderTime');
assert_equals(entry.startTime, 0);
assert_equals(entry.duration, 0);
// Some lower bound: height of at least 12 px.
// Width of at least 100 px.

View File

@ -24,7 +24,7 @@
assert_equals(entryList.getEntries().length, 1);
const entry = entryList.getEntries()[0];
assert_equals(entry.entryType, 'largest-contentful-paint');
assert_equals(entry.startTime, entry.renderTime, 'startTime should equal renderTime');
assert_equals(entry.startTime, 0);
assert_equals(entry.duration, 0);
assert_equals(entry.url, path);
assert_less_than(entry.renderTime, performance.now(),