From d82f3cb0004604f00889a9c4901762f76cfd8fef Mon Sep 17 00:00:00 2001
From: flyingrub <flyinggrub@gmail.com>
Date: Fri, 25 Aug 2017 16:48:58 +0200
Subject: [PATCH] Bug 1393478 - Clear the search filter when switching section
 r=chutten

MozReview-Commit-ID: 3Rtr8eLsc77

--HG--
extra : rebase_source : 00220ac6283db92eef1e65f5c4304ead7313f044
---
 toolkit/content/aboutTelemetry.js | 24 +++++++++++++++---------
 1 file changed, 15 insertions(+), 9 deletions(-)

diff --git a/toolkit/content/aboutTelemetry.js b/toolkit/content/aboutTelemetry.js
index a38edf3a91ef..f2607d7f0a53 100644
--- a/toolkit/content/aboutTelemetry.js
+++ b/toolkit/content/aboutTelemetry.js
@@ -1313,6 +1313,10 @@ var Histogram = {
 
 var Search = {
 
+  blacklist: [
+    "raw-payload-section"
+  ],
+
   // Pass if: all non-empty array items match (case-sensitive)
   isPassText(subject, filter) {
     for (let item of filter) {
@@ -1841,19 +1845,21 @@ function displayProcessesSelector(selectedSection) {
   processes.hidden = !whitelist.includes(selectedSection);
 }
 
-function adjustSearchState() {
+function refreshSearch() {
   let selectedSection = document.querySelector(".category.selected").getAttribute("value");
-  let blacklist = [
-    "raw-payload-section"
-  ];
   let search = document.getElementById("search");
-  search.hidden = blacklist.includes(selectedSection);
-  // Filter element on section change.
-  if (!blacklist.includes(selectedSection)) {
+  if (!Search.blacklist.includes(selectedSection)) {
     Search.search(search.value);
   }
 }
 
+function adjustSearchState() {
+  let selectedSection = document.querySelector(".category.selected").getAttribute("value");
+  let search = document.getElementById("search");
+  search.hidden = Search.blacklist.includes(selectedSection);
+  Search.search(""); // reinitialize search state.
+}
+
 function adjustSection() {
   let selectedCategory = document.querySelector(".category.selected");
   if (!selectedCategory.classList.contains("has-data")) {
@@ -2084,8 +2090,8 @@ function onLoad() {
 
   // Update ping data when async Telemetry init is finished.
   Telemetry.asyncFetchTelemetryData(async () => {
-    await PingPicker.update();
     urlStateRestore();
+    await PingPicker.update();
   });
 }
 
@@ -2339,8 +2345,8 @@ function displayPingData(ping, updatePayloadList = false) {
   try {
     PingPicker.render();
     displayRichPingData(ping, updatePayloadList);
-    adjustSearchState();
     adjustSection();
+    refreshSearch();
   } catch (err) {
     console.log(err);
     PingPicker._showRawPingData();