Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-25 13:51:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1681096 - python3 - pylint --py3k - W1656: dict.values referenced when not iterating (dict-values-not-iterating) r=perftest-reviewers,jmaher,AlexandruIonescu

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D99057
This commit is contained in:
Bob Clary 2020-12-14 07:23:20 +00:00
parent c35f5ec5c8
commit d841c6145f
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
testing/mozbase/mozgeckoprofiler/mozgeckoprofiler/symbolication.py
View File

@ -331,6 +331,7 @@ class ProfileSymbolicator:
if lib["start"] not in libs_with_symbols:
libs_with_symbols[lib["start"]] = {"library": lib, "symbols": set()}
libs_with_symbols[lib["start"]]["symbols"].add(address)
# pylint: disable=W1656
return libs_with_symbols.values()
def _resolve_symbols(self, symbols_to_resolve):

3
testing/raptor/raptor/output.py
View File

@ -582,7 +582,8 @@ class PerftestOutput(object):
test["value"] = filters.mean(test["replicates"])
vals.append([test["value"], name])
return _subtests.values(), sorted(vals, reverse=True)
# pylint W1656
return list(_subtests.values()), sorted(vals, reverse=True)
def parseYoutubePlaybackPerformanceOutput(self, test):
"""Parse the metrics for the Youtube playback performance test.