Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-27 23:02:20 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1854303 - Apply the PT_DYNAMIC tag changes properly. r=firefox-build-system-reviewers,ahochheiden

Browse Source 
They are supposed to be applied unconditionally, not only when there is
a GLIBC_ABI_DT_RELR version in the libc.

Differential Revision: https://phabricator.services.mozilla.com/D188894
This commit is contained in:
Mike Hommey 2023-09-22 02:23:54 +00:00
parent efd7c74970
commit d8bb87469e
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
build/unix/elfhack/relrhack.cpp
View File

@ -180,6 +180,12 @@ bool RelR<bits>::hack(std::fstream& f) {
return false;
}
// Apply the PT_DYNAMIC tag changes we've recorded.
for (const auto& [offset, tag] : relr_tags) {
f.seekg(offset, std::ios::beg);
f.write(reinterpret_cast<const char*>(&tag), sizeof(tag));
}
if (verneednum && verneed_off && strsz && strtab_off) {
// Scan SHT_VERNEED for the GLIBC_ABI_DT_RELR version on the libc
// library.
@ -220,10 +226,6 @@ bool RelR<bits>::hack(std::fstream& f) {
// Don't overwrite vn_aux.
f.write(reinterpret_cast<char*>(&reuse),
sizeof(reuse) - sizeof(Elf_Word));
for (const auto& [offset, tag] : relr_tags) {
f.seekg(offset, std::ios::beg);
f.write(reinterpret_cast<const char*>(&tag), sizeof(tag));
}
}
}
verneed_off += verneed.vn_next;