Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-27 14:52:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1894428 - Set depended on bit from AutoStableStringChars r=sfink

Browse Source 
I wasn't able to see any significant performance regression from this, so
I think for the time being let's just take it?

Differential Revision: https://phabricator.services.mozilla.com/D210521
This commit is contained in:
alexical 2024-06-03 03:52:12 +00:00
parent 01bf6473f9
commit d9496bfef0
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
js/src/jsapi-tests/testDeduplication.cpp
View File

@ -120,8 +120,12 @@ BEGIN_TEST(testDeduplication_ASSC) {
// `str`, since it could legitimately have been detected to be identical to
// the tenured `depdep` and deduplicated to that.
CHECK(SameChars(cx, depdep2, str2, 20) || SameChars(cx, depdep2, str, 20));
CHECK(SameChars(cx, depdep2, original, 20) ||
SameChars(cx, depdep2, str, 20));
// TODO: this currently breaks because we are more conservative than we need
// to be with handling the DEPENDED_ON_BIT and deduplication. This will be
// fixed in bug 1900142
// CHECK(SameChars(cx, depdep2, original, 20) ||
// SameChars(cx, depdep2, str, 20));
return true;
}

4
js/src/vm/StringType.cpp
View File

@ -1518,6 +1518,8 @@ bool AutoStableStringChars::init(JSContext* cx, JSString* s) {
return false;
}
linearString->setDependedOn();
MOZ_ASSERT(state_ == Uninitialized);
length_ = linearString->length();
@ -1548,6 +1550,8 @@ bool AutoStableStringChars::initTwoByte(JSContext* cx, JSString* s) {
return false;
}
linearString->setDependedOn();
MOZ_ASSERT(state_ == Uninitialized);
length_ = linearString->length();