Bug 1528605 - Remove UrlbarInput::closePopup in favor of UrlbarView::close. r=harry

Differential Revision: https://phabricator.services.mozilla.com/D37550

--HG--
extra : moz-landing-system : lando

browser/base/content/tabbrowser.js

@@ -1325,7 +1325,7 @@
       // if the tab is a blank one.
       if (newBrowser._urlbarFocused && gURLBar) {
         // Explicitly close the popup if the URL bar retains focus
-        gURLBar.closePopup();
+        gURLBar.view.close();
 
         // If the user happened to type into the URL bar for this browser
         // by the time we got here, focusing will cause the text to be

browser/components/uitour/UITour.jsm

@@ -1619,7 +1619,7 @@ var UITour = {
       let panel = aWindow.gIdentityHandler._identityPopup;
       panel.hidePopup();
     } else if (aMenuName == "urlbar") {
-      aWindow.gURLBar.closePopup();
+      aWindow.gURLBar.view.close();
     } else if (aMenuName == "pageActionPanel") {
       aWindow.BrowserPageActions.panelNode.hidePopup();
     }

browser/components/urlbar/UrlbarInput.jsm

@@ -301,15 +301,6 @@ class UrlbarInput {
     }
   }
 
-  /**
-   * This exists for legacy compatibility, and can be removed once the old
-   * urlbar code goes away, by changing callers. Internal consumers should use
-   * view.close().
-   */
-  closePopup() {
-    this.view.close();
-  }
-
   focus() {
     this.inputField.focus();
   }

browser/docs/AddressBar.rst

@@ -307,8 +307,6 @@ Implements an input box *View*, owns an *UrlbarView*.
     // Uses UrlbarValueFormatter to highlight the base host, search aliases
     // and to keep the host visible on overflow.
     formatValue(val);
-    // Manage view visibility.
-    closePopup();
     openResults();
     // Converts an internal URI (e.g. a URI with a username or password) into
     // one which we can expose to the user.