Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-10 20:05:49 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1170059 - Fix -Wunreachable-code clang warnings in webrtc/signaling. r=jesup

Browse Source
This commit is contained in:
Chris Peterson 2015-05-31 19:38:34 -07:00
parent 50799137e0
commit db36559368
3 changed files with 1 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
media/webrtc/signaling/src/mediapipeline/MediaPipeline.cpp
View File

@ -991,9 +991,8 @@ void MediaPipelineTransmit::PipelineListener::ProcessAudioChunk(
memset(samples, 0, chunk.mDuration * sizeof(samples[0]));
break;
default:
MOZ_ASSERT(PR_FALSE);
MOZ_ASSERT_UNREACHABLE("Unexpected AudioSampleFormat");
return;
break;
}
} else {
// This means silence.

4
media/webrtc/signaling/src/sdp/sipcc/sdp_attr.c
View File

@ -5163,13 +5163,11 @@ sdp_result_e sdp_parse_attr_setup(sdp_t *sdp_p,
"%s Warning: Unknown setup attribute",
sdp_p->debug_str);
return SDP_INVALID_PARAMETER;
break;
default:
/* This is an internal error, not a parsing error */
CSFLogError(logTag, "%s Error: Invalid setup enum (%d)",
sdp_p->debug_str, attr_p->attr.setup);
return SDP_FAILURE;
break;
}
return SDP_SUCCESS;
@ -5223,13 +5221,11 @@ sdp_result_e sdp_parse_attr_connection(sdp_t *sdp_p,
"%s Warning: Unknown connection attribute",
sdp_p->debug_str);
return SDP_INVALID_PARAMETER;
break;
default:
/* This is an internal error, not a parsing error */
CSFLogError(logTag, "%s Error: Invalid connection enum (%d)",
sdp_p->debug_str, attr_p->attr.connection);
return SDP_FAILURE;
break;
}
return SDP_SUCCESS;
}

6
media/webrtc/signaling/src/sdp/sipcc/sdp_attr_access.c
View File

@ -1625,8 +1625,6 @@ sdp_result_e sdp_attr_get_ice_attribute (sdp_t *sdp_p, uint16_t level,
sdp_p->conf_p->num_invalid_param++;
return (SDP_INVALID_PARAMETER);
}
return (SDP_FAILURE);
}
/* Function: sdp_attr_is_present
@ -1693,8 +1691,6 @@ sdp_result_e sdp_attr_get_rtcp_mux_attribute (sdp_t *sdp_p, uint16_t level,
sdp_p->conf_p->num_invalid_param++;
return (SDP_INVALID_PARAMETER);
}
return (SDP_FAILURE);
}
/* Function: sdp_attr_get_setup_attribute
@ -1798,8 +1794,6 @@ sdp_result_e sdp_attr_get_dtls_fingerprint_attribute (sdp_t *sdp_p, uint16_t lev
sdp_p->conf_p->num_invalid_param++;
return (SDP_INVALID_PARAMETER);
}
return (SDP_FAILURE);
}
/* Function: sdp_attr_sprtmap_payload_valid