Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-12-14 02:31:59 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

updating some comments related to the defensive auth prompting patch, bug 232567

Browse Source
This commit is contained in:
darin%meer.net 2004-04-16 18:59:01 +00:00
parent 013ce92320
commit db90a4d605
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
netwerk/protocol/http/src/nsHttpChannel.cpp
View File

@ -2251,11 +2251,9 @@ nsHttpChannel::GetCredentialsForChallenge(const char *challenge,
} }
} }
// If the defensive auth pref is set, then we'll warn the user before
// automatically using the identity from the URL to automatically log
// them into a site (see bug 232567).
if (identFromURI) { if (identFromURI) {
// ask the user... // Warn the user before automatically using the identity from the URL
// to automatically log them into a site (see bug 232567).
if (!ConfirmAuth(NS_LITERAL_STRING("AutomaticAuth"), PR_FALSE)) { if (!ConfirmAuth(NS_LITERAL_STRING("AutomaticAuth"), PR_FALSE)) {
// calling cancel here sets our mStatus and aborts the HTTP // calling cancel here sets our mStatus and aborts the HTTP
// transaction, which prevents OnDataAvailable events. // transaction, which prevents OnDataAvailable events.
@ -2555,9 +2553,11 @@ nsHttpChannel::ConfirmAuth(const nsString &bundleKey, PRBool doYesNoPrompt)
void void
nsHttpChannel::CheckForSuperfluousAuth() nsHttpChannel::CheckForSuperfluousAuth()
{ {
// check whether authentication was provided, even if not required. // we've been called because it has been determined that this channel is
// if so, prompt the user as to whether to continue, as this might be an // getting loaded without taking the userpass from the URL. if the URL
// attempt to spoof a different site (see bug 232567). // contained a userpass, then (provided some other conditions are true),
// we'll give the user an opportunity to abort the channel as this might be
// an attempt to spoof a different site (see bug 232567).
if (!mAuthRetryPending) { if (!mAuthRetryPending) {
// ask user... // ask user...
if (!ConfirmAuth(NS_LITERAL_STRING("SuperfluousAuth"), PR_TRUE)) { if (!ConfirmAuth(NS_LITERAL_STRING("SuperfluousAuth"), PR_TRUE)) {