mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-30 13:45:27 +00:00
Bug 1279303 - Implement change to O.getOwnPropertyDescriptors and update tests. r=efaust
This commit is contained in:
parent
405f3bde8c
commit
dc41558384
@ -60,7 +60,8 @@ function ObjectGetOwnPropertyDescriptors(O) {
|
||||
var desc = std_Object_getOwnPropertyDescriptor(obj, key);
|
||||
|
||||
// Step 4.c.
|
||||
_DefineDataProperty(descriptors, key, desc);
|
||||
if (typeof desc !== "undefined")
|
||||
_DefineDataProperty(descriptors, key, desc);
|
||||
}
|
||||
|
||||
// Step 5.
|
||||
|
@ -27,5 +27,12 @@ var proxy = new Proxy({}, {
|
||||
|
||||
var result = Object.getOwnPropertyDescriptors(proxy);
|
||||
assert.sameValue(result.hasOwnProperty('DUPLICATE'), true);
|
||||
assert.sameValue(result.DUPLICATE, undefined);
|
||||
|
||||
var lastDescriptor = descriptors[descriptors.length - 1];
|
||||
assert.notSameValue(result.DUPLICATE, lastDescriptor);
|
||||
assert.sameValue(result.DUPLICATE.enumerable, lastDescriptor.enumerable);
|
||||
assert.sameValue(result.DUPLICATE.configurable, lastDescriptor.configurable);
|
||||
assert.sameValue(result.DUPLICATE.value, lastDescriptor.value);
|
||||
assert.sameValue(result.DUPLICATE.writable, lastDescriptor.writable);
|
||||
|
||||
assert.sameValue(log, 'ownKeys|getOwnPropertyDescriptor:DUPLICATE|getOwnPropertyDescriptor:DUPLICATE|getOwnPropertyDescriptor:DUPLICATE|');
|
||||
|
@ -0,0 +1,32 @@
|
||||
// Copyright (C) 2016 Jordan Harband. All rights reserved.
|
||||
// This code is governed by the BSD license found in the LICENSE file.
|
||||
|
||||
/*---
|
||||
description: Object.getOwnPropertyDescriptors should filter out undefined OwnPropertyDescriptors
|
||||
esid: sec-object.getownpropertydescriptors
|
||||
author: Jordan Harband
|
||||
featurewws: [Proxy]
|
||||
includes: [proxyTrapsHelper.js]
|
||||
---*/
|
||||
|
||||
var key = "a";
|
||||
var ownKeys = [key];
|
||||
var badProxyHandlers = {
|
||||
getOwnPropertyDescriptor: function () {},
|
||||
ownKeys: function () {
|
||||
return ownKeys;
|
||||
}
|
||||
};
|
||||
var proxy = new Proxy({}, badProxyHandlers);
|
||||
|
||||
var keys = Reflect.ownKeys(proxy);
|
||||
assert.notSameValue(keys, ownKeys, 'Object.keys returns a new Array');
|
||||
assert.sameValue(Array.isArray(keys), true, 'Object.keys returns an Array');
|
||||
assert.sameValue(keys.length, ownKeys.length, 'keys and ownKeys have the same length');
|
||||
assert.sameValue(keys[0], ownKeys[0], 'keys and ownKeys have the same contents');
|
||||
|
||||
var descriptor = Object.getOwnPropertyDescriptor(proxy, key);
|
||||
assert.sameValue(descriptor, undefined, "Descriptor matches result of [[GetOwnPropertyDescriptor]] trap");
|
||||
|
||||
var result = Object.getOwnPropertyDescriptors(proxy);
|
||||
assert.sameValue(key in result, false, "key is not present in result");
|
@ -1,5 +1,14 @@
|
||||
var assert = {
|
||||
sameValue: assertEq,
|
||||
notSameValue(a, b, msg) {
|
||||
try {
|
||||
assertEq(a, b);
|
||||
throw "equal"
|
||||
} catch (e) {
|
||||
if (e === "equal")
|
||||
throw new Error("Assertion failed: expected different values, got " + a);
|
||||
}
|
||||
},
|
||||
throws(ctor, f) {
|
||||
var fullmsg;
|
||||
try {
|
||||
|
Loading…
Reference in New Issue
Block a user