Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-14 05:45:37 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 931307 - Remove "!aTitle.IsEmpty()" assertion. r=mhenretty

Browse Source
This commit is contained in:
Andrea Marchesini 2013-10-30 15:41:07 -04:00
parent 2c0c3504dc
commit dc57aaff10
3 changed files with 32 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
dom/src/notification/Notification.cpp
View File

@ -61,7 +61,6 @@ public:
JSContext* aCx) JSContext* aCx)
{ {
MOZ_ASSERT(!aID.IsEmpty()); MOZ_ASSERT(!aID.IsEmpty());
MOZ_ASSERT(!aTitle.IsEmpty());
NotificationOptions options; NotificationOptions options;
options.mDir = Notification::StringToDirection(nsString(aDir)); options.mDir = Notification::StringToDirection(nsString(aDir));

1
dom/tests/mochitest/notification/mochitest.ini
View File

@ -5,3 +5,4 @@ support-files =
[test_notification_basics.html] [test_notification_basics.html]
[test_notification_storage.html] [test_notification_storage.html]
[test_bug931307.html]

31
dom/tests/mochitest/notification/test_bug931307.html Normal file
View File

@ -0,0 +1,31 @@
<!--
Any copyright is dedicated to the Public Domain.
http://creativecommons.org/publicdomain/zero/1.0/
-->
<html>
<head>
<title>Bug 931307</title>
<script type="application/javascript" src="/tests/SimpleTest/SimpleTest.js"></script>
<link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
</head>
<body>
<pre id="test">
<script type="application/javascript"><!--
SimpleTest.waitForExplicitFinish();
new Notification("");
var promise = Notification.get();
promise.then(
function onSuccess() {
ok(true, "No crash!");
SimpleTest.finish();
},
function onFailure() {
ok(false, "Should not get an error in promise callback");
}
);
</script>
</pre>
</body>
</html>