Bug 1786027 - Migrate appPicker.dtd to Fluent. r=jaws,fluent-reviewers,flod

I was not able to test this manually as it's a Windows-only component,
but it's at least somewhat covered by the tests in
    browser/components/preferences/tests/browser_change_app_handler.js
which pass in CI.

Differential Revision: https://phabricator.services.mozilla.com/D155105

python/l10n/fluent_migrations/bug_1786027_appPicker.py

@@ -0,0 +1,30 @@
+# coding=utf8
+
+# Any copyright is dedicated to the Public Domain.
+# http://creativecommons.org/publicdomain/zero/1.0/
+
+from __future__ import absolute_import
+import fluent.syntax.ast as FTL
+from fluent.migrate.helpers import transforms_from
+from fluent.migrate.helpers import COPY
+
+
+def migrate(ctx):
+    """Bug 1786027 - Migrate appPicker.dtd to Fluent, part {index}"""
+
+    ctx.add_transforms(
+        "toolkit/toolkit/global/appPicker.ftl",
+        "toolkit/toolkit/global/appPicker.ftl",
+        transforms_from(
+            """
+
+app-picker-browse-button =
+    .buttonlabelextra2 = { COPY(path1, "BrowseButton.label") }
+app-picker-send-msg =
+    .value = { COPY(path1, "SendMsg.label") }
+app-picker-no-app-found =
+    .value = { COPY(path1, "NoAppFound.label") }
+""",
+            path1="toolkit/chrome/global/appPicker.dtd",
+        ),
+    )

toolkit/components/apppicker/content/appPicker.xhtml

@@ -7,18 +7,23 @@
   <?xml-stylesheet href="chrome://global/skin/global.css" type="text/css"?>
   <?xml-stylesheet href="chrome://global/skin/appPicker.css" type="text/css"?>
 
-  <!DOCTYPE window SYSTEM "chrome://global/locale/appPicker.dtd" >
+  <!DOCTYPE window>
 
   <window
     xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"
+    xmlns:html="http://www.w3.org/1999/xhtml"
     onload="g_dialog.appPickerLoad();"
     aria-describedby="content-description suggested-filename"
     persist="screenX screenY">
   <dialog id="app-picker"
     buttons="accept,cancel,extra2"
-    buttonlabelextra2="&BrowseButton.label;"
+    data-l10n-id="app-picker-browse-button"
+    data-l10n-attrs="buttonlabelextra2"
     defaultButton="accept">
 
+    <linkset>
+      <html:link rel="localization" href="toolkit/global/appPicker.ftl"/>
+    </linkset>
     <script src="chrome://global/content/appPicker.js"/>
 
     <hbox id="file-info" align="center">
@@ -29,11 +34,11 @@
       </vbox>
     </hbox>
 
-    <label id="sendto-message" value="&SendMsg.label;" control="app-picker-listbox"/>
+    <label id="sendto-message" data-l10n-id="app-picker-send-msg" control="app-picker-listbox"/>
 
     <richlistbox id="app-picker-listbox"
                  ondblclick="g_dialog.appDoubleClick();"/>
 
-    <label id="app-picker-notfound" value="&NoAppFound.label;" hidden="true"/>
+    <label id="app-picker-notfound" data-l10n-id="app-picker-no-app-found" hidden="true"/>
   </dialog>
   </window>

toolkit/locales/en-US/chrome/global/appPicker.dtd

@@ -1,7 +0,0 @@
-<!-- This Source Code Form is subject to the terms of the Mozilla Public
-   - License, v. 2.0. If a copy of the MPL was not distributed with this
-   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
-
-<!ENTITY NoAppFound.label      "No applications were found for this file type.">
-<!ENTITY BrowseButton.label    "Browse…">
-<!ENTITY SendMsg.label         "Send this item to:">

toolkit/locales/en-US/toolkit/global/appPicker.ftl

@@ -0,0 +1,10 @@
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+
+app-picker-browse-button =
+    .buttonlabelextra2 = Browse…
+app-picker-send-msg =
+    .value = Send this item to:
+app-picker-no-app-found =
+    .value = No applications were found for this file type.

toolkit/locales/jar.mn

@@ -12,7 +12,6 @@
   locale/@AB_CD@/global/aboutReader.properties          (%chrome/global/aboutReader.properties)
   locale/@AB_CD@/global/aboutStudies.properties         (%chrome/global/aboutStudies.properties)
   locale/@AB_CD@/global/autocomplete.properties         (%chrome/global/autocomplete.properties)
-  locale/@AB_CD@/global/appPicker.dtd                   (%chrome/global/appPicker.dtd)
   locale/@AB_CD@/global/browser.properties              (%chrome/global/browser.properties)
   locale/@AB_CD@/global/commonDialogs.properties        (%chrome/global/commonDialogs.properties)
   locale/@AB_CD@/global/contentAreaCommands.properties  (%chrome/global/contentAreaCommands.properties)