Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-21 09:15:35 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1537596 - Make shift-click toggle all breakpoint states per line r=loganfsmyth

Browse Source 
Implements a function to enable or disable all breakpoints on a line based on shift-clicking. Uses the first breakpoint's state to decide whether to enable or disable all.

Differential Revision: https://phabricator.services.mozilla.com/D24524

--HG--
extra : moz-landing-system : lando
This commit is contained in:
David Walsh 2019-03-22 19:43:41 +00:00
parent 81e54c6f8e
commit dd65f15097
3 changed files with 21 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
devtools/client/debugger/new/src/actions/breakpoints/index.js
View File

@ -18,7 +18,8 @@ import {
getBreakpointAtLocation,
getConditionalPanelLocation,
getBreakpointsForSource,
isEmptyLineInSource
isEmptyLineInSource,
getBreakpointsAtLine
} from "../../selectors";
import {
assertBreakpoint,
@ -208,6 +209,16 @@ export function toggleBreakpoints(
};
}
export function toggleBreakpointsAtLine(
shouldDisableBreakpoints: boolean,
line: number
) {
return async ({ dispatch, getState }: ThunkArgs) => {
const breakpoints = await getBreakpointsAtLine(getState(), line);
return dispatch(toggleBreakpoints(shouldDisableBreakpoints, breakpoints));
};
}
/**
* Removes all breakpoints
*

7
devtools/client/debugger/new/src/components/Editor/Breakpoint.js
View File

@ -97,6 +97,13 @@ class Breakpoint extends PureComponent<Props> {
}
if (event.shiftKey) {
if (features.columnBreakpoints) {
return breakpointActions.toggleBreakpointsAtLine(
!breakpoint.disabled,
this.selectedLocation.line
);
}
return breakpointActions.toggleDisabledBreakpoint(breakpoint);
}

2
devtools/client/debugger/new/src/components/Editor/menus/breakpoints.js
View File

@ -215,6 +215,7 @@ export type BreakpointItemActions = {
enableBreakpointsAtLine: typeof actions.enableBreakpointsAtLine,
disableBreakpointsAtLine: typeof actions.disableBreakpointsAtLine,
toggleDisabledBreakpoint: typeof actions.toggleDisabledBreakpoint,
toggleBreakpointsAtLine: typeof actions.toggleBreakpointsAtLine,
openConditionalPanel: typeof actions.openConditionalPanel
};
@ -228,6 +229,7 @@ export function breakpointItemActions(dispatch: Function) {
disableBreakpointsAtLine: actions.disableBreakpointsAtLine,
disableBreakpoint: actions.disableBreakpoint,
toggleDisabledBreakpoint: actions.toggleDisabledBreakpoint,
toggleBreakpointsAtLine: actions.toggleBreakpointsAtLine,
openConditionalPanel: actions.openConditionalPanel
},
dispatch