Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-08 19:04:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1839147 - Fix comments about sAllocDelay's type r=glandium

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D181831
This commit is contained in:
Paul Bone 2023-06-26 23:45:43 +00:00
parent 2695cb5759
commit de53f7f654
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
memory/replace/phc/PHC.cpp
View File

@ -437,8 +437,8 @@ class GAtomic {
static Atomic<Time, Relaxed> sNow;
// Delay until the next attempt at a page allocation. See the comment in
// MaybePageAlloc() for an explanation of why it is a signed integer, and why
// it uses ReleaseAcquire semantics.
// MaybePageAlloc() for an explanation of why it uses ReleaseAcquire
// semantics.
static Atomic<Delay, ReleaseAcquire> sAllocDelay;
};
@ -1053,9 +1053,9 @@ static void* MaybePageAlloc(const Maybe<arena_id_t>& aArenaId, size_t aReqSize,
// guarantees that exactly one thread will see sAllocDelay have the value 0.
// (Relaxed semantics wouldn't guarantee that.)
//
// It's also nice that sAllocDelay is signed, given that we can decrement to
// below zero. (Strictly speaking, an unsigned integer would also work due
// to wrapping, but a signed integer is conceptually cleaner.)
// Note that sAllocDelay is unsigned and we expect that it will wrap after
// being decremented "below" zero. It must be unsigned so that IsPowerOfTwo()
// can work on some Delay values.
//
// Finally, note that the decrements that occur between (a) and (e) above are
// effectively ignored, because (e) clobbers them. This shouldn't be a