Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-25 20:01:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1782536 - Remove outdated comments from HttpChannelParent.h and ParentChannelListener.h r=necko-reviewers,valentin DONTBUILD

Browse Source 
These comments come from bug 1219469 which had an implementation for QueryInterface that included the following:
> if (aIID.Equals(NS_GET_IID(HttpChannelParentListener))) {
>  foundInterface = static_cast<nsIInterfaceRequestor*>(this);
> } else

That has been replaced by
> NS_INTERFACE_MAP_ENTRY_CONCRETE(HttpChannelParent)

so the comments are no longer correct, and nsIInterfaceRequestor doesn't need to be the first class we extend.

Differential Revision: https://phabricator.services.mozilla.com/D153568
This commit is contained in:
smayya 2022-08-03 09:49:48 +00:00
parent 3d04063622
commit de8e780d94
2 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
netwerk/protocol/http/HttpChannelParent.h
View File

@ -42,10 +42,6 @@ class HttpBackgroundChannelParent;
class ParentChannelListener;
class ChannelEventQueue;
// Note: nsIInterfaceRequestor must be the first base so that do_QueryObject()
// works correctly on this object, as it's needed to compute a void* pointing to
// the beginning of this object.
class HttpChannelParent final : public nsIInterfaceRequestor,
public PHttpChannelParent,
public nsIParentRedirectingChannel,

4
netwerk/protocol/http/ParentChannelListener.h
View File

@ -26,10 +26,6 @@ namespace net {
} \
}
// Note: nsIInterfaceRequestor must be the first base so that do_QueryObject()
// works correctly on this object, as it's needed to compute a void* pointing to
// the beginning of this object.
class ParentChannelListener final : public nsIInterfaceRequestor,
public nsIStreamListener,
public nsIMultiPartChannelListener,