Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-29 07:42:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1671725 - [puppeteer] Increase mocha timeout to 20 seconds. r=remote-protocol-reviewers,jgraham,whimboo

Browse Source 
We originally set 15s to keep the overall job duration under 30 minutes.
Since then, we hit timeouts much less frequently and should be able to
afford a longer timeout. The Puppeteer project's default test timeout
is currently 25 seconds.

Also skipping a Page test due to an async Firefox-specific protocol
error that interferes with teardown.

Differential Revision: https://phabricator.services.mozilla.com/D94245
This commit is contained in:
Maja Frydrychowicz 2020-10-22 14:11:16 +00:00
parent bb67e5edb1
commit ded3e267ad
3 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
remote/mach_commands.py
View File

@ -377,7 +377,7 @@ class PuppeteerRunner(MozbuildObject):
"--reporter", "./json-mocha-reporter.js",
"--retries", "0",
"--fullTrace",
"--timeout", "15000",
"--timeout", "20000",
"--no-parallel",
]
if product == "firefox":

6
remote/puppeteer-expected.json
View File

@ -1071,7 +1071,7 @@
"TIMEOUT"
],
"navigation Frame.goto should return matching responses (navigation.spec.ts)": [
"TIMEOUT"
"FAIL"
],
"navigation Frame.waitForNavigation should work (navigation.spec.ts)": [
"FAIL"
@ -1197,7 +1197,7 @@
"PASS"
],
"Page Page.close should run beforeunload if asked for (page.spec.ts)": [
"TIMEOUT"
"FAIL"
],
"Page Page.close should *not* run beforeunload by default (page.spec.ts)": [
"TIMEOUT"
@ -1542,7 +1542,7 @@
"FAIL"
],
"Page Page.Events.Close should work with window.close (page.spec.ts)": [
"FAIL"
"SKIP"
],
"Page Page.Events.Close should work with page.close (page.spec.ts)": [
"PASS"

3
remote/test/puppeteer/test/page.spec.ts
View File

@ -21,6 +21,7 @@ import expect from 'expect';
import sinon from 'sinon';
import {
getTestState,
itFailsFirefox,
setupTestBrowserHooks,
setupTestPageAndContextHooks,
} from './mocha-utils';
@ -1668,7 +1669,7 @@ describe('Page', function () {
});
describe('Page.Events.Close', function () {
it('should work with window.close', async () => {
itFailsFirefox('should work with window.close', async () => {
const { page, context } = getTestState();
const newPagePromise = new Promise<Page>((fulfill) =>