Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-12 18:50:08 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix bug#116315: don't pass null char into JRI_NewPlatformString

Browse Source
This commit is contained in:
selmer 1998-05-12 02:03:33 +00:00
parent c0cb1cb79c
commit df945999fd
1 changed files with 10 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
cmd/dialup/win/aswplugn/src/sysnregi.cpp
View File

@ -521,37 +521,21 @@ java_lang_String * getRegElement(JRIEnv *env,
}
}
// long length = 1 + strlen(value); // 1 extra for the null char -- WRONG!
// Don't add the 1 to the length here, do it in the malloc
long length = strlen(value);
long bufLen = (extendLen ? len : lenShort);
if (extendLen == TRUE) {
rtnValue = (char *)malloc(sizeof(char) * length);
rtnValue = (char *)malloc(sizeof(char) * (length+1));
if (!rtnValue)
return NULL;
if (!rtnValue)
return NULL;
strcpy(rtnValue, value);
strcpy(rtnValue, value);
if (!noData) {
length = length + len;
rtnValue = (char *)realloc(rtnValue, sizeof(char) * length);
strncat(rtnValue, buffer, len);
}
} else {
rtnValue = (char *)malloc(sizeof(char) * length);
if (!rtnValue)
return NULL;
strcpy(rtnValue, value);
if (!noData) {
length = length + lenShort;
rtnValue = (char *)realloc(rtnValue, sizeof(char) * length);
strncat(rtnValue, buffer, lenShort);
}
if (!noData) {
length = length + bufLen;
rtnValue = (char *)realloc(rtnValue, sizeof(char) * (length+1));
strncat(rtnValue, buffer, bufLen);
}
data = JRI_NewStringPlatform(env, rtnValue, length, NULL, 0);