Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-26 03:35:33 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1329897. Part 3 - call Request{Audio,Video}Data instead. r=kaku

Browse Source 
For HandleAudioCanceled():
1. IsRequestingAudioData() is false because mAudioDataRequest is completed in MDSM::RequestAudioData().
2. IsWaitingAudioData() is false because data promsie and wait promise are mutually exclusive.
3. IsAudioDecoding() is true because we wouldn't have requested audio data otherwise.

Likewise, we can prove EnsureAudioDecodeTaskQueued() can be reduced to mMaster->RequestAudioData()
in HandleAudioWaited.

MozReview-Commit-ID: 1i63IMfZaUh

--HG--
extra : rebase_source : ac389a7ccc74d969ecfc5f5f622c1c90e2d9b118
extra : intermediate-source : 50bb6d229443be0c410daf7c9553e84cd21fd929
extra : source : f4c3f02f3741c49eed38c2aaab5c872d18fb74ff
This commit is contained in:
JW Wang 2017-01-09 20:27:36 +08:00
parent 59e78145eb
commit e1c0f361aa
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
dom/media/MediaDecoderStateMachine.cpp
View File

@ -1651,12 +1651,12 @@ public:
void HandleAudioCanceled() override
{
EnsureAudioDecodeTaskQueued();
mMaster->RequestAudioData();
}
void HandleVideoCanceled() override
{
EnsureVideoDecodeTaskQueued();
mMaster->RequestVideoData(false, media::TimeUnit());
}
void HandleWaitingForAudio() override
@ -1671,12 +1671,12 @@ public:
void HandleAudioWaited(MediaData::Type aType) override
{
EnsureAudioDecodeTaskQueued();
mMaster->RequestAudioData();
}
void HandleVideoWaited(MediaData::Type aType) override
{
EnsureVideoDecodeTaskQueued();
mMaster->RequestVideoData(false, media::TimeUnit());
}
void HandleEndOfAudio() override;