Bug 1487246: Remove uses of comma sequences in linted code. r=Standard8

Two cases were hiding permanently failing tests. I've commented those out and
filed bug 1487431.

Differential Revision: https://phabricator.services.mozilla.com/D4680

--HG--
extra : rebase_source : 232fa6173de8844a9c47d59926ec8e39d0640ecd

accessible/tests/mochitest/actions/test_media.html

@@ -42,7 +42,7 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=483573
       this.target = aAcc;
       this.getID = function nameChecker_getID() {
         return "name change handling";
-      },
+      };
       this.check = function nameChecker_check(aEvent) {
         is(aEvent.accessible.name, aName,
            "Wrong name of " + prettyName(aEvent.accessible) + " on focus");

accessible/tests/mochitest/events/test_text_alg.html

@@ -191,14 +191,18 @@
       ];
       gQueue.push(new changeText("p12", newStr, events));
 
-      newStr = "a" + longStr2 + "b", insStr = longStr2, rmStr = longStr1;
+      newStr = "a" + longStr2 + "b";
+      insStr = longStr2;
+      rmStr = longStr1;
       events = [
         [ kRemoval, rmStr, 1 ],
         [ kInsertion, insStr, 1]
       ];
       gQueue.push(new changeText("p12", newStr, events));
 
-      newStr = "ab", insStr = "", rmStr = longStr2;
+      newStr = "ab";
+      insStr = "";
+      rmStr = longStr2;
       events = [
         [ kRemoval, rmStr, 1 ],
         [ kInsertion, insStr, 1, kUnexpected ]

accessible/tests/mochitest/scroll/test_zoom.html

@@ -41,7 +41,8 @@
       anchor = getAccessible("bottom3");
       [x, /* y */] = getPos(anchor);
       var [parentX, parentY] = getPos(anchor.parent);
-      scrollToX = parentX - docX, scrollToY = parentY - docY;
+      scrollToX = parentX - docX;
+      scrollToY = parentY - docY;
 
       anchor.scrollToPoint(COORDTYPE_PARENT_RELATIVE, scrollToX, scrollToY);
       testPos(anchor, [x, docY]);

browser/base/content/test/sanitize/browser_sanitize-timespans.js

@@ -601,7 +601,7 @@ async function setupDownloads() {
     source: "https://bugzilla.mozilla.org/show_bug.cgi?id=480169",
     target: "fakefile-10-minutes"
   });
-  download.startTime = new Date(now_mSec - 10 * kMsecPerMin), // 10 minutes ago
+  download.startTime = new Date(now_mSec - 10 * kMsecPerMin); // 10 minutes ago
   download.canceled = true;
   await publicList.add(download);
 
@@ -609,7 +609,7 @@ async function setupDownloads() {
     source: "https://bugzilla.mozilla.org/show_bug.cgi?id=453440",
     target: "fakefile-1-hour"
   });
-  download.startTime = new Date(now_mSec - 45 * kMsecPerMin), // 45 minutes ago
+  download.startTime = new Date(now_mSec - 45 * kMsecPerMin); // 45 minutes ago
   download.canceled = true;
   await publicList.add(download);
 
@@ -617,7 +617,7 @@ async function setupDownloads() {
     source: "https://bugzilla.mozilla.org/show_bug.cgi?id=480169",
     target: "fakefile-1-hour-10-minutes"
   });
-  download.startTime = new Date(now_mSec - 70 * kMsecPerMin), // 70 minutes ago
+  download.startTime = new Date(now_mSec - 70 * kMsecPerMin); // 70 minutes ago
   download.canceled = true;
   await publicList.add(download);
 
@@ -625,7 +625,7 @@ async function setupDownloads() {
     source: "https://bugzilla.mozilla.org/show_bug.cgi?id=453440",
     target: "fakefile-2-hour"
   });
-  download.startTime = new Date(now_mSec - 90 * kMsecPerMin), // 90 minutes ago
+  download.startTime = new Date(now_mSec - 90 * kMsecPerMin); // 90 minutes ago
   download.canceled = true;
   await publicList.add(download);
 
@@ -633,7 +633,7 @@ async function setupDownloads() {
     source: "https://bugzilla.mozilla.org/show_bug.cgi?id=480169",
     target: "fakefile-2-hour-10-minutes"
   });
-  download.startTime = new Date(now_mSec - 130 * kMsecPerMin), // 130 minutes ago
+  download.startTime = new Date(now_mSec - 130 * kMsecPerMin); // 130 minutes ago
   download.canceled = true;
   await publicList.add(download);
 
@@ -641,7 +641,7 @@ async function setupDownloads() {
     source: "https://bugzilla.mozilla.org/show_bug.cgi?id=453440",
     target: "fakefile-4-hour"
   });
-  download.startTime = new Date(now_mSec - 180 * kMsecPerMin), // 180 minutes ago
+  download.startTime = new Date(now_mSec - 180 * kMsecPerMin); // 180 minutes ago
   download.canceled = true;
   await publicList.add(download);
 
@@ -649,7 +649,7 @@ async function setupDownloads() {
     source: "https://bugzilla.mozilla.org/show_bug.cgi?id=480169",
     target: "fakefile-4-hour-10-minutes"
   });
-  download.startTime = new Date(now_mSec - 250 * kMsecPerMin), // 250 minutes ago
+  download.startTime = new Date(now_mSec - 250 * kMsecPerMin); // 250 minutes ago
   download.canceled = true;
   await publicList.add(download);
 
@@ -664,7 +664,7 @@ async function setupDownloads() {
     source: "https://bugzilla.mozilla.org/show_bug.cgi?id=453440",
     target: "fakefile-today"
   });
-  download.startTime = today, // 12:00:01 AM this morning
+  download.startTime = today; // 12:00:01 AM this morning
   download.canceled = true;
   await publicList.add(download);
 
@@ -676,7 +676,7 @@ async function setupDownloads() {
     source: "https://bugzilla.mozilla.org/show_bug.cgi?id=453440",
     target: "fakefile-old"
   });
-  download.startTime = lastYear,
+  download.startTime = lastYear;
   download.canceled = true;
   await publicList.add(download);
 

browser/components/uitour/test/browser_UITour3.js

@@ -32,7 +32,7 @@ add_UITour_task(async function test_info_icon() {
   is(icon.src, imageURL, "Popup should have correct icon shown");
 
   is(buttons.hasChildNodes(), false, "Popup should have no buttons");
-}),
+});
 
 add_UITour_task(async function test_info_buttons_1() {
   let popup = document.getElementById("UITourTooltip");
@@ -119,7 +119,7 @@ add_UITour_task(async function test_info_buttons_2() {
   let returnValue = await waitForCallbackResultPromise();
 
   is(returnValue.result, "button2", "Correct callback should have been called");
-}),
+});
 
 add_UITour_task(async function test_info_close_button() {
   let closeButton = document.getElementById("UITourTooltipClose");
@@ -131,7 +131,7 @@ add_UITour_task(async function test_info_close_button() {
   let returnValue = await waitForCallbackResultPromise();
 
   is(returnValue.result, "closeButton", "Close button callback called");
-}),
+});
 
 add_UITour_task(async function test_info_target_callback() {
   let popup = document.getElementById("UITourTooltip");
@@ -150,7 +150,7 @@ add_UITour_task(async function test_info_target_callback() {
   await hideInfoPromise();
 
   popup.removeAttribute("animate");
-}),
+});
 
 add_UITour_task(async function test_getConfiguration_selectedSearchEngine() {
   await new Promise((resolve) => {

browser/modules/AsyncTabSwitcher.jsm

@@ -132,7 +132,7 @@ class AsyncTabSwitcher {
     // For telemetry, keeps track of what most recently cleared
     // the loadTimer, which can tell us something about the cause
     // of tab switch spinners.
-    this._loadTimerClearedBy = "none",
+    this._loadTimerClearedBy = "none";
 
     this._useDumpForLogging = false;
     this._logInit = false;

dom/indexedDB/test/unit/test_create_objectStore.js

@@ -80,7 +80,7 @@ function* testSteps()
     is(objectStore.keyPath, info.options && info.options.keyPath ?
                             info.options.keyPath : null,
        "Bad keyPath");
-    if (objectStore.indexNames.length, 0, "Bad indexNames");
+    is(objectStore.indexNames.length, 0, "Bad indexNames");
 
     ok(event.target.transaction, "event has a transaction");
     ok(event.target.transaction.db === db, "transaction has the right db");

dom/media/mediasource/test/test_FrameSelection_mp4.html

@@ -39,8 +39,9 @@ runWithMSE(async (ms, v) => {
   await fetchAndLoad(sb, "bipbop/bipbop_480_624kbps-video", ["1"], ".m4s");
   ms.endOfStream();
   await Promise.all([once(ms, "sourceended"), once(v, "playing"), once(v, "ended")]);
-  if (v.width, 640, "has proper width");
-  if (v.height, 480, "has proper height");
+  // These tests are permafailing
+  // is(v.width, 640, "has proper width");
+  // is(v.height, 480, "has proper height");
   SimpleTest.finish();
 });
 </script>

services/sync/tests/unit/test_syncengine.js

@@ -258,7 +258,7 @@ add_task(async function test_wipeServer() {
   try {
     // Some data to reset.
     await engine.setLastSync(123.45);
-    engine.toFetch = guidSetOfSize(3),
+    engine.toFetch = guidSetOfSize(3);
 
     _("Wipe server data and reset client.");
     await engine.wipeServer();

testing/marionette/driver.js

@@ -1302,7 +1302,7 @@ GeckoDriver.prototype.getIdForBrowser = function(browser) {
     return winId;
   }
   return null;
-},
+};
 
 /**
  * Get the current window's handle. On desktop this typically corresponds

toolkit/components/alerts/test/test_alerts_requireinteraction.html

@@ -133,7 +133,7 @@ add_task(async function test_require_interaction() {
   var testFinishPromise = new Promise((resolve) => { testFinishResolve = resolve; });
 
   xulAlertCreated = await promiseCreateXULAlert(alertService,
-    createAlertListener("third"), "third"),
+    createAlertListener("third"), "third");
   ok(!xulAlertCreated, "XUL alert should not be visible");
 
   // Replace the not-yet-visible third alert.

toolkit/components/antitracking/test/browser/imageCacheWorker.js

@@ -8,13 +8,13 @@ AntiTracking.runTest("Image cache - should load the image twice.",
     // Let's load the image twice here.
     let img = document.createElement("img");
     document.body.appendChild(img);
-    img.src = "https://tracking.example.org/browser/toolkit/components/antitracking/test/browser/image.sjs",
+    img.src = "https://tracking.example.org/browser/toolkit/components/antitracking/test/browser/image.sjs";
     await new Promise(resolve => { img.onload = resolve; });
     ok(true, "Image 1 loaded");
 
     img = document.createElement("img");
     document.body.appendChild(img);
-    img.src = "https://tracking.example.org/browser/toolkit/components/antitracking/test/browser/image.sjs",
+    img.src = "https://tracking.example.org/browser/toolkit/components/antitracking/test/browser/image.sjs";
     await new Promise(resolve => { img.onload = resolve; });
     ok(true, "Image 2 loaded");
   },
@@ -29,13 +29,13 @@ AntiTracking.runTest("Image cache - should load the image twice.",
       // Let's load the image twice here as well.
       let img = document.createElement("img");
       document.body.appendChild(img);
-      img.src = "https://tracking.example.org/browser/toolkit/components/antitracking/test/browser/image.sjs",
+      img.src = "https://tracking.example.org/browser/toolkit/components/antitracking/test/browser/image.sjs";
       await new Promise(resolve => { img.onload = resolve; });
       ok(true, "Image 3 loaded");
 
       img = document.createElement("img");
       document.body.appendChild(img);
-      img.src = "https://tracking.example.org/browser/toolkit/components/antitracking/test/browser/image.sjs",
+      img.src = "https://tracking.example.org/browser/toolkit/components/antitracking/test/browser/image.sjs";
       await new Promise(resolve => { img.onload = resolve; });
       ok(true, "Image 4 loaded");
     },

toolkit/components/osfile/modules/osfile_async_front.jsm

@@ -1456,7 +1456,7 @@ var Barriers = {
 };
 
 function setupShutdown(phaseName) {
-  Barriers[phaseName] = new AsyncShutdown.Barrier(`OS.File: Waiting for clients before ${phaseName}`),
+  Barriers[phaseName] = new AsyncShutdown.Barrier(`OS.File: Waiting for clients before ${phaseName}`);
   File[phaseName] = Barriers[phaseName].client;
 
   // Auto-flush OS.File during `phaseName`. This ensures that any I/O

toolkit/components/osfile/modules/osfile_async_worker.js

@@ -30,7 +30,7 @@ if (this.Components) {
   let worker = new PromiseWorker.AbstractWorker();
   worker.dispatch = function(method, args = []) {
     return Agent[method](...args);
-  },
+  };
   worker.log = LOG;
   worker.postMessage = function(message, ...transfers) {
     if (timeStamps) {

toolkit/components/osfile/modules/osfile_win_front.jsm

@@ -803,7 +803,7 @@
             throw new File.Error("iter (FindNextFile)", error, this._path);
 
 
-     },
+     };
 
      /**
       * Return the next entry in the directory, if any such entry is

toolkit/components/promiseworker/tests/xpcshell/data/worker.js

@@ -13,7 +13,7 @@ var PromiseWorker = require("resource://gre/modules/workers/PromiseWorker.js");
 var worker = new PromiseWorker.AbstractWorker();
 worker.dispatch = function(method, args = []) {
   return Agent[method](...args);
-},
+};
 worker.postMessage = function(...args) {
   self.postMessage(...args);
 };

toolkit/modules/Preferences.jsm

@@ -187,14 +187,14 @@ Preferences.isSet = function(prefName) {
     return prefName.map(this.isSet, this);
 
   return (this.has(prefName) && this._prefBranch.prefHasUserValue(prefName));
-},
+};
 
 /**
  * Whether or not the given pref has a user-set value. Use isSet instead,
  * which is equivalent.
  * @deprecated
  */
-Preferences.modified = function(prefName) { return this.isSet(prefName); },
+Preferences.modified = function(prefName) { return this.isSet(prefName); };
 
 Preferences.reset = function(prefName) {
   if (Array.isArray(prefName)) {
@@ -329,7 +329,7 @@ Preferences.resetBranch = function(prefBranch = "") {
     else
       throw ex;
   }
-},
+};
 
 /**
  * A string identifying the branch of the preferences tree to which this