Bug 1389740 - Rename urlbar-icons to page-action-buttons. r=gijs

MozReview-Commit-ID: 980Rvv8mxtU

browser/base/content/browser-pageActions.js

@@ -457,8 +457,8 @@ var BrowserPageActions = {
       // like how #star-button is contained in #star-button-box, the latter
       // being the bookmark action's node.  Look up the ancestor chain.
       for (let n = node.parentNode; n && !action; n = n.parentNode) {
-        if (n.id == "urlbar-icons" || n.localName == "panelview") {
-          // We reached the urlbar icons container or the panelview container.
+        if (n.id == "page-action-buttons" || n.localName == "panelview") {
+          // We reached the page-action-buttons or panelview container.
           // Stop looking; no acton was found.
           break;
         }

browser/base/content/browser.css

@@ -663,8 +663,8 @@ html|input.urlbar-input[textoverflow]:not([focused]) {
   -moz-binding: url("chrome://global/content/bindings/datetimepopup.xml#datetime-popup");
 }
 
-#urlbar[pageproxystate="invalid"] > #urlbar-icons > .urlbar-icon,
-#urlbar[pageproxystate="invalid"] > #urlbar-icons > .urlbar-icon-wrapper > .urlbar-icon,
+#urlbar[pageproxystate="invalid"] > #page-action-buttons > .urlbar-icon,
+#urlbar[pageproxystate="invalid"] > #page-action-buttons > .urlbar-icon-wrapper > .urlbar-icon,
 .urlbar-go-button[pageproxystate="valid"],
 .urlbar-go-button:not([parentfocused="true"]),
 #urlbar[pageproxystate="invalid"] > #identity-box > #blocked-permissions-container,

browser/base/content/browser.xul

@@ -880,7 +880,7 @@
                 <label id="switchtab" class="urlbar-display urlbar-display-switchtab" value="&urlbar.switchToTab.label;"/>
                 <label id="extension" class="urlbar-display urlbar-display-extension" value="&urlbar.extension.label;"/>
               </box>
-              <hbox id="urlbar-icons">
+              <hbox id="page-action-buttons">
                 <image id="page-report-button"
                        class="urlbar-icon"
                        hidden="true"

browser/components/extensions/ext-pageAction.js

@@ -163,7 +163,7 @@ this.pageAction = class extends ExtensionAPI {
     return {style};
   }
 
-  // Create an |image| node and add it to the |urlbar-icons|
+  // Create an |image| node and add it to the |page-action-buttons|
   // container in the given window.
   addButton(window) {
     let document = window.document;
@@ -179,7 +179,7 @@ this.pageAction = class extends ExtensionAPI {
       document.addEventListener("popupshowing", this);
     }
 
-    document.getElementById("urlbar-icons").appendChild(button);
+    document.getElementById("page-action-buttons").appendChild(button);
 
     return button;
   }

browser/extensions/pocket/bootstrap.js

@@ -212,7 +212,7 @@ var PocketPageAction = {
           wrapper.appendChild(pocketButton);
           wrapper.appendChild(animatableBox);
           animatableBox.appendChild(animatableImage);
-          let iconBox = doc.getElementById("urlbar-icons");
+          let iconBox = doc.getElementById("page-action-buttons");
           iconBox.appendChild(wrapper);
           wrapper.hidden = true;
           wrapper.addEventListener("click", event => {

browser/themes/shared/urlbar-searchbar.inc.css

@@ -121,7 +121,7 @@
 
 /* Page action urlbar buttons */
 
-#urlbar-icons {
+#page-action-buttons {
   -moz-box-align: center;
   /* Add more space between the last icon and the urlbar's edge. */
   margin-inline-end: 3px;