Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-23 12:51:06 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Backed out changeset f9c41a2aac8b (bug 1869558) for causing wpt failures on subscribe-with-faulty-applicationServerKey.https.window.html.

Browse Source
This commit is contained in:
Iulian Moraru 2023-12-14 23:17:06 +02:00
parent 77926c2a05
commit e2371fe34d
5 changed files with 28 additions and 75 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
dom/push/test/test_register_key.html
View File

@ -78,6 +78,34 @@ http://creativecommons.org/licenses/publicdomain/
controlledFrame = await injectControlledFrame();
});
add_task(async function emptyKey() {
try {
await registration.pushManager.subscribe({
applicationServerKey: new ArrayBuffer(0),
});
ok(false, "Should reject for empty app server keys");
} catch (error) {
ok(error instanceof DOMException,
"Wrong exception type for empty key");
is(error.name, "InvalidAccessError",
"Wrong exception name for empty key");
}
});
add_task(async function invalidKey() {
try {
await registration.pushManager.subscribe({
applicationServerKey: new Uint8Array([0]),
});
ok(false, "Should reject for invalid app server keys");
} catch (error) {
ok(error instanceof DOMException,
"Wrong exception type for invalid key");
is(error.name, "InvalidAccessError",
"Wrong exception name for invalid key");
}
});
add_task(async function validKey() {
var pushSubscription = await registration.pushManager.subscribe({
applicationServerKey: await generateKey(),

1
testing/web-platform/meta/push-api/__dir__.ini
View File

@ -1,2 +1 @@
lsan-allowed: [Alloc, Create, Malloc, Realloc, Then, mozilla::BasePrincipal::CreateContentPrincipal, mozilla::dom::DocGroup::Create, mozilla::dom::ServiceWorkerManager::Unregister, mozilla::dom::ServiceWorkerRegistrationMainThread::Unregister, mozilla::dom::UnregisterCallback::UnregisterCallback, mozilla::net::nsStandardURL::TemplatedMutator, operator]
prefs: [notification.prompt.testing:true, dom.push.testing.ignorePermission:true, marionette.setpermission.enabled:true]

0
testing/web-platform/tests/push-api/noop-sw.js
View File

12
testing/web-platform/tests/push-api/resources/helpers.js
View File

@ -1,12 +0,0 @@
function resetSw() {
return navigator.serviceWorker.getRegistrations().then(registrations => {
return Promise.all(registrations.map(r => r.unregister()));
});
}
async function registerSw(path) {
await resetSw();
add_completion_callback(resetSw);
const reg = await navigator.serviceWorker.register(path);
return reg;
}

62
testing/web-platform/tests/push-api/subscribe-with-faulty-applicationServerKey.https.window.js
View File

@ -1,62 +0,0 @@
// META: script=/resources/testdriver.js
// META: script=/resources/testdriver-vendor.js
// META: script=resources/helpers.js
// NOTE:
// We are not testing success cases here as doing so will try creating external network
// connection, which is not allowed by all browser test environments.
// (e.g. Gecko explicitly disables push service for testing environment.)
// Ideally we should have WPT-specific mock server in this case. See also
// https://github.com/w3c/push-api/issues/365.
promise_setup(async () => {
// The spec does not enforce validation order and implementations
// indeed check other things before checking applicationServerKey.
// Get the permission because Firefox checks it before key validation.
// (The permission test is done in permission.https.html.)
await test_driver.set_permission({ name: "notifications" }, "granted");
// Get the active service worker because Chrome checks it before key validation
registration = await registerSw("noop-sw.js");
await navigator.serviceWorker.ready;
});
promise_test(async (t) => {
await promise_rejects_dom(
t,
"InvalidAccessError",
registration.pushManager.subscribe({ applicationServerKey: "" }),
);
}, "Reject empty string applicationServerKey");
promise_test(async (t) => {
await promise_rejects_dom(
t,
"InvalidAccessError",
registration.pushManager.subscribe({ applicationServerKey: new ArrayBuffer(0) }),
);
}, "Reject empty ArrayBuffer applicationServerKey");
promise_test(async (t) => {
await promise_rejects_dom(
t,
"InvalidAccessError",
registration.pushManager.subscribe({ applicationServerKey: new Uint8Array(0) }),
);
}, "Reject empty Uint8Array applicationServerKey");
promise_test(async (t) => {
await promise_rejects_dom(
t,
"InvalidAccessError",
registration.pushManager.subscribe({ applicationServerKey: new Uint8Array([1, 2, 3]) }),
);
}, "Reject a key that is not a valid point on P-256 curve");
promise_test(async (t) => {
await promise_rejects_dom(
t,
"InvalidCharacterError",
registration.pushManager.subscribe({ applicationServerKey: "!@#$^&*" }),
);
}, "Reject a string key that can't be decoded by base64url");