Bug 1251936 - turn static analysis off on windows debug clang-cl builds; r=bustage

Also revert the followup patch to nsTArray.h, as that shouldn't
generally be needed.

browser/config/mozconfigs/win32/clang-debug

@@ -8,7 +8,8 @@ MOZ_AUTOMATION_L10N_CHECK=0
 ac_add_options --enable-optimize
 ac_add_options --enable-debug
 
-ac_add_options --enable-clang-plugin
+#Work to make the clang-plugin work on Windows is ongoing in bug 1316545.
+#ac_add_options --enable-clang-plugin
 
 . $topsrcdir/build/win32/mozconfig.vs-latest
 

browser/config/mozconfigs/win64/clang-debug

@@ -10,7 +10,8 @@ ac_add_options --host=x86_64-pc-mingw32
 ac_add_options --enable-optimize
 ac_add_options --enable-debug
 
-ac_add_options --enable-clang-plugin
+#Work to make the clang-plugin work on Windows is ongoing in bug 1316545.
+#ac_add_options --enable-clang-plugin
 
 . $topsrcdir/build/win64/mozconfig.vs-latest
 

taskcluster/ci/build/windows.yml

@@ -115,13 +115,13 @@ win64/pgo:
             - builds/taskcluster_firefox_windows_64_opt.py
 
 win32-clang/debug:
-    description: "Win32 Static Analysis Debug (clang-cl)"
+    description: "Win32 Clang-cl Debug"
     index:
         product: firefox
         job-name: win32-clang-debug
     treeherder:
         platform: windows2012-32/debug
-        symbol: tc(S)
+        symbol: tc(Bcl)
         tier: 2
     worker-type: aws-provisioner-v1/gecko-{level}-b-win2012
     worker:
@@ -153,13 +153,13 @@ win32-clang/opt:
             - builds/taskcluster_firefox_win32_clang.py
 
 win64-clang/debug:
-    description: "Win64 Static Analysis Debug (clang-cl)"
+    description: "Win64 Clang-cl Debug"
     index:
         product: firefox
         job-name: win64-clang-debug
     treeherder:
         platform: windows2012-64/debug
-        symbol: tc(S)
+        symbol: tc(Bcl)
         tier: 2
     worker-type: aws-provisioner-v1/gecko-{level}-b-win2012
     worker:

xpcom/glue/nsTArray.h

@@ -50,12 +50,6 @@ struct SerializedStructuredCloneBuffer;
 class SourceBufferTask;
 } // namespace mozilla
 
-namespace mozilla {
-namespace gfx {
-class FilterPrimitiveDescription;
-} // namespace gfx
-} // namespace mozilla
-
 namespace mozilla {
 namespace dom {
 namespace ipc {
@@ -863,7 +857,6 @@ DECLARE_USE_COPY_CONSTRUCTORS(mozilla::dom::indexedDB::SerializedStructuredClone
 DECLARE_USE_COPY_CONSTRUCTORS(JSStructuredCloneData)
 DECLARE_USE_COPY_CONSTRUCTORS(mozilla::dom::MessagePortMessage)
 DECLARE_USE_COPY_CONSTRUCTORS(mozilla::SourceBufferTask)
-DECLARE_USE_COPY_CONSTRUCTORS(mozilla::gfx::FilterPrimitiveDescription)
 
 template<typename T>
 struct nsTArray_CopyChooser<std::function<T>>