Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-25 05:41:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1378016 - Fix keyboard navigation and selection on 'recent bookmarks'. r=Gijs

Browse Source 
MozReview-Commit-ID: GJ7vRPz8zuo

--HG--
extra : rebase_source : b8a212cd174f81994e3cdb5adc4226b5dfc531d3
This commit is contained in:
Erica Wright 2017-07-31 09:47:19 -04:00
parent 0be9924b76
commit e2a35da326
1 changed files with 13 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
browser/components/customizableui/PanelMultiView.jsm
View File

@ -1022,12 +1022,10 @@ this.PanelMultiView = class {
buttons = navMap.buttons = this._getNavigableElements(view); buttons = navMap.buttons = this._getNavigableElements(view);
// Set the 'tabindex' attribute on the buttons to make sure they're focussable. // Set the 'tabindex' attribute on the buttons to make sure they're focussable.
for (let button of buttons) { for (let button of buttons) {
if (button.classList.contains("subviewbutton-back")) if (!button.classList.contains("subviewbutton-back") &&
continue; !button.hasAttribute("tabindex")) {
// If we've been here before, forget about it! button.setAttribute("tabindex", 0);
if (button.hasAttribute("tabindex")) }
break;
button.setAttribute("tabindex", 0);
} }
} }
if (!buttons.length) if (!buttons.length)
@ -1078,14 +1076,21 @@ this.PanelMultiView = class {
break; break;
// Fall-through... // Fall-through...
} }
case "Space":
case "Enter": { case "Enter": {
let button = buttons[navMap.selected]; let button = buttons[navMap.selected];
if (!button) if (!button)
break; break;
stop(); stop();
// Unfortunately, 'tabindex' doesn't not execute the default action, so
// Unfortunately, 'tabindex' doesn't execute the default action, so
// we explicitly do this here. // we explicitly do this here.
button.click(); // We are sending a command event and then a click event.
// This is done in order to mimic a "real" mouse click event.
// The command event executes the action, then the click event closes the menu.
button.doCommand();
let clickEvent = new event.target.ownerGlobal.MouseEvent("click", {"bubbles": true});
button.dispatchEvent(clickEvent);
break; break;
} }
} }