Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-26 22:32:46 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

don't ASSERT that it doesn't support weak references for NULL. r=pinkerton

Browse Source
This commit is contained in:
scc%netscape.com 1999-11-23 03:10:02 +00:00
parent af437476c2
commit e2e36b3c4a
2 changed files with 68 additions and 54 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
xpcom/base/nsWeakReference.cpp
View File

@ -43,18 +43,25 @@ nsQueryReferent::operator()( const nsIID& aIID, void** answer ) const
}
NS_COM nsIWeakReference*
NS_GetWeakReference( nsISupports* aInstance, nsresult* aResult )
NS_GetWeakReference( nsISupports* aInstancePtr, nsresult* aErrorPtr )
{
nsresult status;
if ( !aResult )
aResult = &status;
nsIWeakReference* result = 0;
nsCOMPtr<nsISupportsWeakReference> factoryP = do_QueryInterface(aInstance, aResult);
NS_ASSERTION(factoryP, "Did you know you were calling |NS_GetWeakReference()| on something that doesn't support weak references?");
if ( aInstancePtr )
{
nsCOMPtr<nsISupportsWeakReference> factoryPtr = do_QueryInterface(aInstancePtr, &status);
NS_ASSERTION(factoryPtr, "Did you know you were calling |NS_GetWeakReference()| on something that doesn't support weak references?");
if ( factoryPtr )
status = factoryPtr->GetWeakReference(&result);
// else, |status| has already been set by |do_QueryInterface|
}
else
status = NS_ERROR_NULL_POINTER;
nsIWeakReference* weakP = 0;
status = factoryP ? factoryP->GetWeakReference(&weakP) : NS_ERROR_NO_INTERFACE;
return weakP;
if ( aErrorPtr )
*aErrorPtr = status;
return result;
}
NS_IMETHODIMP

23
xpcom/glue/nsWeakReference.cpp
View File

@ -43,18 +43,25 @@ nsQueryReferent::operator()( const nsIID& aIID, void** answer ) const
}
NS_COM nsIWeakReference*
NS_GetWeakReference( nsISupports* aInstance, nsresult* aResult )
NS_GetWeakReference( nsISupports* aInstancePtr, nsresult* aErrorPtr )
{
nsresult status;
if ( !aResult )
aResult = &status;
nsIWeakReference* result = 0;
nsCOMPtr<nsISupportsWeakReference> factoryP = do_QueryInterface(aInstance, aResult);
NS_ASSERTION(factoryP, "Did you know you were calling |NS_GetWeakReference()| on something that doesn't support weak references?");
if ( aInstancePtr )
{
nsCOMPtr<nsISupportsWeakReference> factoryPtr = do_QueryInterface(aInstancePtr, &status);
NS_ASSERTION(factoryPtr, "Did you know you were calling |NS_GetWeakReference()| on something that doesn't support weak references?");
if ( factoryPtr )
status = factoryPtr->GetWeakReference(&result);
// else, |status| has already been set by |do_QueryInterface|
}
else
status = NS_ERROR_NULL_POINTER;
nsIWeakReference* weakP = 0;
status = factoryP ? factoryP->GetWeakReference(&weakP) : NS_ERROR_NO_INTERFACE;
return weakP;
if ( aErrorPtr )
*aErrorPtr = status;
return result;
}
NS_IMETHODIMP