Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-17 15:25:52 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1476393 - Record pwmgr histograms in sync ping r=markh,tcsc

Browse Source 
MozReview-Commit-ID: CkZAwlCORtX

--HG--
extra : rebase_source : 3be3237c6a2d5919d839bc77cb1794fec0dcdec6
This commit is contained in:
irrationalagent 2018-08-03 09:30:06 -06:00
parent c9df37f8cd
commit e31593630b
3 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
toolkit/components/passwordmgr/content/passwordManager.js
View File

@ -101,8 +101,10 @@ function Startup() {
window.arguments[0].filterString) {
setFilter(window.arguments[0].filterString);
Services.telemetry.getHistogramById("PWMGR_MANAGE_OPENED").add(1);
Services.obs.notifyObservers(null, "weave:telemetry:histogram", "PWMGR_MANAGE_OPENED");
} else {
Services.telemetry.getHistogramById("PWMGR_MANAGE_OPENED").add(0);
Services.obs.notifyObservers(null, "weave:telemetry:histogram", "PWMGR_MANAGE_OPENED");
}
FocusFilterBox();
@ -409,6 +411,7 @@ function DeleteAllSignons() {
removeAllButton.setAttribute("disabled", "true");
FinalizeSignonDeletions(syncNeeded);
Services.telemetry.getHistogramById("PWMGR_MANAGE_DELETED_ALL").add(1);
Services.obs.notifyObservers(null, "weave:telemetry:histogram", "PWMGR_MANAGE_DELETED_ALL");
}
function TogglePasswordVisible() {
@ -424,6 +427,7 @@ function TogglePasswordVisible() {
// completed. (Mostly useful for tests)
Services.obs.notifyObservers(null, "passwordmgr-password-toggle-complete");
Services.telemetry.getHistogramById("PWMGR_MANAGE_VISIBILITY_TOGGLED").add(showingPasswords);
Services.obs.notifyObservers(null, "weave:telemetry:histogram", "PWMGR_MANAGE_VISIBILITY_TOGGLED");
}
function AskUserShowPasswords() {
@ -440,6 +444,7 @@ function FinalizeSignonDeletions(syncNeeded) {
for (let s = 0; s < deletedSignons.length; s++) {
Services.logins.removeLogin(deletedSignons[s]);
Services.telemetry.getHistogramById("PWMGR_MANAGE_DELETED").add(1);
Services.obs.notifyObservers(null, "weave:telemetry:histogram", "PWMGR_MANAGE_DELETED");
}
// If the deletion has been performed in a filtered view, reflect the deletion in the unfiltered table.
// See bug 405389.
@ -625,6 +630,7 @@ function CopyPassword() {
let password = signonsTreeView.getCellText(row, {id: "passwordCol" });
clipboard.copyString(password);
Services.telemetry.getHistogramById("PWMGR_MANAGE_COPIED_PASSWORD").add(1);
Services.obs.notifyObservers(null, "weave:telemetry:histogram", "PWMGR_MANAGE_COPIED_PASSWORD");
}
function CopyUsername() {
@ -635,6 +641,7 @@ function CopyUsername() {
let username = signonsTreeView.getCellText(row, {id: "userCol" });
clipboard.copyString(username);
Services.telemetry.getHistogramById("PWMGR_MANAGE_COPIED_USERNAME").add(1);
Services.obs.notifyObservers(null, "weave:telemetry:histogram", "PWMGR_MANAGE_COPIED_USERNAME");
}
function EditCellInSelectedRow(columnName) {

5
toolkit/components/passwordmgr/nsLoginManager.js
View File

@ -205,10 +205,13 @@ LoginManager.prototype = {
clearAndGetHistogram("PWMGR_NUM_HTTPAUTH_PASSWORDS").add(
this.countLogins("", null, "")
);
Services.obs.notifyObservers(null, "weave:telemetry:histogram", "PWMGR_BLOCKLIST_NUM_SITES");
Services.obs.notifyObservers(null, "weave:telemetry:histogram", "PWMGR_NUM_SAVED_PASSWORDS");
// This is a boolean histogram, and not a flag, because we don't want to
// record any value if _gatherTelemetry is not called.
clearAndGetHistogram("PWMGR_SAVING_ENABLED").add(this._remember);
Services.obs.notifyObservers(null, "weave:telemetry:histogram", "PWMGR_SAVING_ENABLED");
// Don't try to get logins if MP is enabled, since we don't want to show a MP prompt.
if (!this.isLoggedIn) {
@ -235,11 +238,13 @@ LoginManager.prototype = {
);
}
}
Services.obs.notifyObservers(null, "weave:telemetry:histogram", "PWMGR_LOGIN_LAST_USED_DAYS");
let passwordsCountHistogram = clearAndGetHistogram("PWMGR_NUM_PASSWORDS_PER_HOSTNAME");
for (let count of hostnameCount.values()) {
passwordsCountHistogram.add(count);
}
Services.obs.notifyObservers(null, "weave:telemetry:histogram", "PWMGR_NUM_PASSWORDS_PER_HOSTNAME");
},

4
toolkit/components/passwordmgr/nsLoginManagerPrompter.js
View File

@ -821,6 +821,7 @@ LoginManagerPrompter.prototype = {
: "PWMGR_PROMPT_UPDATE_ACTION";
let histogram = Services.telemetry.getHistogramById(histogramName);
histogram.add(PROMPT_DISPLAYED);
Services.obs.notifyObservers(null, "weave:telemetry:histogram", histogramName);
const promptType = type == "password-save" ? "save" : "update";
const flow_id = browser.ownerGlobal.gBrowser.getTabForBrowser(browser).linkedPanel;
@ -974,6 +975,7 @@ LoginManagerPrompter.prototype = {
}
readDataFromUI();
persistData();
Services.obs.notifyObservers(null, "weave:telemetry:histogram", histogramName);
browser.focus();
}
};
@ -983,6 +985,7 @@ LoginManagerPrompter.prototype = {
accessKey: this._getLocalizedString(initialMsgNames.secondaryButtonAccessKey),
callback: () => {
histogram.add(PROMPT_NOTNOW);
Services.obs.notifyObservers(null, "weave:telemetry:histogram", histogramName);
browser.focus();
}
}];
@ -993,6 +996,7 @@ LoginManagerPrompter.prototype = {
accessKey: this._getLocalizedString("notifyBarNeverRememberButtonAccessKey2"),
callback: () => {
histogram.add(PROMPT_NEVER);
Services.obs.notifyObservers(null, "weave:telemetry:histogram", histogramName);
Services.logins.setLoginSavingEnabled(login.hostname, false);
browser.focus();
}