Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-26 06:11:37 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Use bigger buffers to avoid spilling to the heap during string manipulation.

Browse Source
This commit is contained in:
waterson%netscape.com 1999-09-02 21:29:46 +00:00
parent 1e1077c6f8
commit e31f9fb786
1 changed files with 6 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
rdf/content/src/nsRDFContentUtils.cpp
View File

@ -202,19 +202,7 @@ nsRDFContentUtils::GetElementResource(nsIContent* aElement, nsIRDFResource** aRe
if (! doc)
return NS_ERROR_FAILURE;
char buf[256];
nsCAutoString uri;
nsStr::Initialize(uri, buf, sizeof(buf) - 1, 0, eOneByte, PR_FALSE);
buf[0] = 0;
rv = nsRDFContentUtils::MakeElementURI(doc, id, uri);
if (NS_FAILED(rv)) return rv;
NS_WITH_SERVICE(nsIRDFService, rdf, kRDFServiceCID, &rv);
if (NS_FAILED(rv)) return rv;
rv = rdf->GetResource(uri, aResult);
NS_ASSERTION(NS_SUCCEEDED(rv), "unable to create resource");
rv = nsRDFContentUtils::MakeElementResource(doc, id, aResult);
if (NS_FAILED(rv)) return rv;
return NS_OK;
@ -475,9 +463,9 @@ nsRDFContentUtils::MakeElementURI(nsIDocument* aDocument, const nsString& aEleme
aURI = spec;
if (aElementID.First() != '#') {
aURI += '#';
aURI.Append('#');
}
aURI += aElementID;
aURI.Append(nsCAutoString(aElementID));
#else
nsXPIDLCString spec;
rv = NS_MakeAbsoluteURI(nsCAutoString(aElementID), docURL, getter_Copies(spec));
@ -499,7 +487,9 @@ nsresult
nsRDFContentUtils::MakeElementResource(nsIDocument* aDocument, const nsString& aID, nsIRDFResource** aResult)
{
nsresult rv;
nsCAutoString uri;
char buf[256];
nsCAutoString uri(CBufDescriptor(buf, PR_TRUE, sizeof(buf)));
rv = MakeElementURI(aDocument, aID, uri);
if (NS_FAILED(rv)) return rv;