Bug 1908833 - Remove ZLIB_IN_MOZGLUE. r=firefox-build-system-reviewers,ahochheiden

It's not used on Android anymore, which was the last remaining thing
that would set it.

Differential Revision: https://phabricator.services.mozilla.com/D217349

config/external/zlib/moz.build

@@ -9,13 +9,6 @@ Library("zlib")
 if CONFIG["MOZ_SYSTEM_ZLIB"]:
     OS_LIBS += CONFIG["MOZ_ZLIB_LIBS"]
 else:
-    if CONFIG["ZLIB_IN_MOZGLUE"]:
-        # Can't do this until mozglue is handled by moz.build instead of
-        # config/rules.mk.
-        # USE_LIBS += [
-        #     'mozglue'
-        # ]
-        pass
     DIRS += [
         "../../../modules/zlib",
     ]

modules/zlib/src/moz.build

@@ -10,11 +10,8 @@ EXPORTS += [
     'zlib.h',
 ]
 
-if CONFIG['ZLIB_IN_MOZGLUE']:
-    FINAL_LIBRARY = 'mozglue'
-else:
-    # The final library is in config/external/zlib
-    FINAL_LIBRARY = 'zlib'
+# The final library is in config/external/zlib
+FINAL_LIBRARY = 'zlib'
 
 # These files can't be unified because zlib's headers don't use include guards.
 SOURCES += [

modules/zlib/src/mozzconf.h

@@ -6,12 +6,6 @@
 #ifndef MOZZCONF_H
 #define MOZZCONF_H
 
-#if defined(ZLIB_IN_MOZGLUE)
-#include "mozilla/Types.h"
-
-#define ZEXTERN MFBT_API
-#endif
-
 /* Exported Symbols */
 #define zlibVersion MOZ_Z_zlibVersion
 #define deflate MOZ_Z_deflate

moz.configure

@@ -912,16 +912,6 @@ pkg_check_modules("MOZ_ZLIB", "zlib >= 1.2.3", when="--with-system-zlib")
 set_config("MOZ_SYSTEM_ZLIB", True, when="--with-system-zlib")
 
 
-@depends(with_system_zlib_option, target.os)
-def zlib_in_mozglue(system_zlib, os):
-    if not system_zlib and os == "Android":
-        return True
-
-
-set_config("ZLIB_IN_MOZGLUE", zlib_in_mozglue)
-set_define("ZLIB_IN_MOZGLUE", zlib_in_mozglue)
-
-
 with only_when(cross_compiling):
     option(
         env="JS_BINARY",