Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-24 13:21:05 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1543337 - Change some for (let _ of …) to for (const _ of …), r=webdriver-reviewers,jdescottes

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D150812
This commit is contained in:
James Graham 2022-07-15 14:42:09 +00:00
parent 01bd544526
commit e56d9c755b
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
remote/marionette/action.js
View File

@ -124,7 +124,7 @@ action.State = class {
* @return {Iterator} Iterator over [id, input source]. * @return {Iterator} Iterator over [id, input source].
*/ */
*inputSourcesByType(type) { *inputSourcesByType(type) {
for (let [id, inputSource] of this.inputStateMap) { for (const [id, inputSource] of this.inputStateMap) {
if (inputSource.type === type) { if (inputSource.type === type) {
yield [id, inputSource]; yield [id, inputSource];
} }
@ -148,7 +148,7 @@ action.State = class {
// Reserve pointer ids 0 and 1 for mouse pointers // Reserve pointer ids 0 and 1 for mouse pointers
const idValues = Array.from(this.pointerIdMap.values()); const idValues = Array.from(this.pointerIdMap.values());
if (type === "mouse") { if (type === "mouse") {
for (let mouseId of [0, 1]) { for (const mouseId of [0, 1]) {
if (!idValues.includes(mouseId)) { if (!idValues.includes(mouseId)) {
pointerId = mouseId; pointerId = mouseId;
break; break;
@ -1428,7 +1428,7 @@ async function moveOverTime(startCoords, targetCoords, duration, callback) {
} }
const actionTypes = new Map(); const actionTypes = new Map();
for (let cls of [ for (const cls of [
KeyDownAction, KeyDownAction,
KeyUpAction, KeyUpAction,
PauseAction, PauseAction,
@ -1612,7 +1612,7 @@ action.Chain = class extends Array {
dispatch(state, win) { dispatch(state, win) {
let i = 1; let i = 1;
const chainEvents = (async () => { const chainEvents = (async () => {
for (let tickActions of this) { for (const tickActions of this) {
lazy.logger.trace(`Dispatching tick ${i++}/${this.length}`); lazy.logger.trace(`Dispatching tick ${i++}/${this.length}`);
await tickActions.dispatch(state, win); await tickActions.dispatch(state, win);
} }
@ -1635,7 +1635,7 @@ action.Chain = class extends Array {
); );
const actionsByTick = new this(); const actionsByTick = new this();
for (let actionSequence of actions) { for (const actionSequence of actions) {
const inputSourceActions = Sequence.fromJSON(state, actionSequence); const inputSourceActions = Sequence.fromJSON(state, actionSequence);
for (let i = 0; i < inputSourceActions.length; i++) { for (let i = 0; i < inputSourceActions.length; i++) {
// new tick // new tick
@ -1660,7 +1660,7 @@ class TickActions extends Array {
*/ */
getDuration() { getDuration() {
let max = 0; let max = 0;
for (let action of this) { for (const action of this) {
if (action.affectsWallClockTime && action.duration) { if (action.affectsWallClockTime && action.duration) {
max = Math.max(action.duration, max); max = Math.max(action.duration, max);
} }
@ -1765,7 +1765,7 @@ class Sequence extends Array {
InputSource.fromJSON(state, actionSequence); InputSource.fromJSON(state, actionSequence);
const sequence = new this(); const sequence = new this();
for (let actionItem of actions) { for (const actionItem of actions) {
sequence.push(Action.fromJSON(type, id, actionItem)); sequence.push(Action.fromJSON(type, id, actionItem));
} }
@ -1837,7 +1837,7 @@ class PointerEventData extends InputEventData {
update(state, inputSource) { update(state, inputSource) {
// set modifier properties based on whether any corresponding keys are // set modifier properties based on whether any corresponding keys are
// pressed on any key input source // pressed on any key input source
for (let [, otherInputSource] of state.inputSourcesByType("key")) { for (const [, otherInputSource] of state.inputSourcesByType("key")) {
this.altKey = otherInputSource.alt || this.altKey; this.altKey = otherInputSource.alt || this.altKey;
this.ctrlKey = otherInputSource.ctrl || this.ctrlKey; this.ctrlKey = otherInputSource.ctrl || this.ctrlKey;
this.metaKey = otherInputSource.meta || this.metaKey; this.metaKey = otherInputSource.meta || this.metaKey;