Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-27 21:00:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1277377 - prevent unsafe C-style cast in Vector (r=waldo)

Browse Source 
MozReview-Commit-ID: L0bTDSBHOeY
This commit is contained in:
Luke Wagner 2016-06-02 14:38:02 -05:00
parent 38784200aa
commit e574e0eda0
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
mfbt/Vector.h
View File

@ -163,7 +163,12 @@ struct VectorImpl<T, N, AP, true>
MOZ_NONNULL(1)
static inline void new_(T* aDst, Args&&... aArgs)
{
*aDst = T(Forward<Args>(aArgs)...);
// Explicitly construct a local object instead of using a temporary since
// T(args...) will be treated like a C-style cast in the unary case and
// allow unsafe conversions. Both forms should be equivalent to an
// optimizing compiler.
T temp(Forward<Args>(aArgs)...);
*aDst = temp;
}
static inline void destroy(T*, T*) {}