From e6065804c9144548b29825e95bf53f9b3b11978c Mon Sep 17 00:00:00 2001 From: Sebastian Hengst Date: Mon, 2 Oct 2017 17:25:14 +0200 Subject: [PATCH] Backed out changeset 0a5a34ef66d1 (bug 1388998) for mass test failures during shutdown. r=backout on a CLOSED TREE --- storage/mozStorageService.cpp | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/storage/mozStorageService.cpp b/storage/mozStorageService.cpp index 4f35692ff93b..6439e60261cb 100644 --- a/storage/mozStorageService.cpp +++ b/storage/mozStorageService.cpp @@ -309,15 +309,8 @@ Service::unregisterConnection(Connection *aConnection) // Ensure the connection is released on its opening thread. Note, we // must use .forget().take() so that we can manually cast to an // unambiguous nsISupports type. - // - // We specify aAlwaysProxy=true because if we don't, the destructor for - // the connection will be invoked if the connection is owned by the - // main thread. And since the Connection destructor calls Close() and - // that may in turn call SpinningSynchronousClose() if the connection - // was not properly shutdown, that can lead to re-entrancy problems. NS_ProxyRelease( - "storage::Service::mConnections", thread, mConnections[i].forget(), - true); + "storage::Service::mConnections", thread, mConnections[i].forget()); mConnections.RemoveElementAt(i); return;