Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-19 16:25:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1635309: Clear conceptual parent when updating AccGroupInfo. r=MarcoZ

Browse Source 
When an Accessible is removed, the AccGroupInfo for its siblings is marked dirty.
However, when AccGroupInfo::Update is called, it previously didn't clear mParent, which is used for the NODE_CHILD_OF relation.
This meant that if the conceptual group parent was removed and there was subsequently no conceptual parent, NODE_CHILD_OF would return an incorrect (potentially dead) Accessible.

Differential Revision: https://phabricator.services.mozilla.com/D73776
This commit is contained in:
James Teh 2020-05-05 05:36:31 +00:00
parent c46daa5d4d
commit e6468d4b89
3 changed files with 60 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
accessible/base/AccGroupInfo.cpp
View File

@ -18,6 +18,8 @@ AccGroupInfo::AccGroupInfo(const Accessible* aItem, role aRole)
}
void AccGroupInfo::Update() {
mParent = nullptr;
Accessible* parent = mItem->Parent();
if (!parent) return;

1
accessible/tests/mochitest/relations/a11y.ini
View File

@ -6,6 +6,7 @@ support-files =
skip-if = os == 'linux' && !debug # bug 1411145
[test_general.html]
[test_general.xhtml]
[test_groupInfoUpdate.html]
[test_tabbrowser.xhtml]
[test_tree.xhtml]
[test_ui_modalprompt.html]

57
accessible/tests/mochitest/relations/test_groupInfoUpdate.html Normal file
View File

@ -0,0 +1,57 @@
<html>
<head>
<title>Test accessible relations when AccGroupInfo updated</title>
<link rel="stylesheet" type="text/css"
href="chrome://mochikit/content/tests/SimpleTest/test.css" />
<script src="chrome://mochikit/content/tests/SimpleTest/SimpleTest.js"></script>
<script type="application/javascript"
src="../common.js"></script>
<script type="application/javascript"
src="../relations.js"></script>
<script type="application/javascript"
src="../promisified-events.js"></script>
<script type="application/javascript">
async function doTests() {
info("Testing NODE_CHILD_OF update after DOM removal");
testRelation("l1i2", RELATION_NODE_CHILD_OF, "l1i1");
let reorder = waitForEvent(EVENT_REORDER, "l1");
getNode("l1i1").remove();
await reorder;
testRelation("l1i2", RELATION_NODE_CHILD_OF, "l1");
info("Testing NODE_CHILD_OF update after aria-owns removal");
testRelation("l2i2", RELATION_NODE_CHILD_OF, "l2i1");
reorder = waitForEvent(EVENT_REORDER, "l2");
// Move l2i1 out of l2 using aria-owns.
getNode("l2trash").setAttribute("aria-owns", "l2i1");
await reorder;
testRelation("l2i2", RELATION_NODE_CHILD_OF, "l2");
SimpleTest.finish();
}
SimpleTest.waitForExplicitFinish();
addA11yLoadEvent(doTests);
</script>
</head>
<body id="body">
<p id="display"></p>
<div id="content" style="display: none"></div>
<pre id="test">
</pre>
<div id="l1" role="list">
<div id="l1i1" role="listitem" aria-level="1">a</div>
<div id="l1i2" role="listitem" aria-level="2">b</div>
</div>
<div id="l2" role="list">
<div id="l2i1" role="listitem" aria-level="1">a</div>
<div id="l2i2" role="listitem" aria-level="2">b</div>
</div>
<div id="l2trash"></div>
</body>
</html>