Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-03-03 23:30:46 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 199502 - It's possible to take down Bugzilla by changing the languages param

Browse Source 
r=gerv,a=myk
This commit is contained in:
burnus%gmx.de 2003-08-28 22:59:14 +00:00
parent 4f4355b894
commit e65903b938
1 changed files with 36 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
webtools/bugzilla/defparams.pl
View File

@ -47,6 +47,7 @@
use strict;
use vars qw(@param_list);
use File::Spec; # for find_languages
# Checking functions for the various values
# Some generic checking functions are included in Bugzilla::Config
@ -148,6 +149,35 @@ sub check_loginmethod {
return "";
}
sub check_languages {
my @languages = split /,/, trim($_);
if(!scalar(@languages)) {
return "You need to specify a language tag."
}
foreach my $language (@languages) {
if( ! -d 'template/'.trim($language).'/custom'
&& ! -d 'template/'.trim($language).'/default') {
return "The template directory for $language does not exist";
}
}
return "";
}
sub find_languages {
my @languages = ();
opendir(DIR, "template") || return "Can't open 'template' directory: $!";
my @langdirs = grep { /^[a-z-]+$/i } readdir(DIR);
closedir DIR;
foreach my $lang (@langdirs) {
next if($lang =~ /^CVS$/i);
my $deft_path = File::Spec->catdir('template', $lang, 'default');
my $cust_path = File::Spec->catdir('template', $lang, 'custom');
push(@languages, $lang) if(-d $deft_path or -d $cust_path);
}
return join(', ', @languages);
}
# OK, here are the parameter definitions themselves.
#
# Each definition is a hash with keys:
@ -233,9 +263,11 @@ sub check_loginmethod {
'to be displayed. Note that you must install the appropriate ' .
'language pack before adding a language to this Param. The ' .
'language used is the one in this list with the highest ' .
'q-value in the user\'s Accept-Language header.' ,
'q-value in the user\'s Accept-Language header.<br>' .
'Available languages: ' . find_languages() ,
type => 't' ,
default => 'en'
default => 'en' ,
checker => \&check_languages
},
{
@ -243,7 +275,8 @@ sub check_loginmethod {
desc => 'The UI language Bugzilla falls back on if no suitable ' .
'language is found in the user\'s Accept-Language header.' ,
type => 't' ,
default => 'en'
default => 'en' ,
checker => \&check_languages
},
{