Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-11 20:35:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1364872 - take zero tolerance of decoding error in debug and playback test. r=jya

Browse Source 
MozReview-Commit-ID: 9DYBfyIvGvk

--HG--
extra : rebase_source : 81c85e2f271110fe85f94fb687a60820fc37f0fa
This commit is contained in:
Alfredo Yang 2017-05-24 15:25:09 +08:00
parent 5db65a6f2c
commit e6b2ddf4c2
4 changed files with 16 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
dom/media/MediaFormatReader.cpp
View File

@ -1098,9 +1098,9 @@ MediaFormatReader::MediaFormatReader(AbstractMediaDecoder* aDecoder,
VideoFrameContainer* aVideoFrameContainer)
: MediaDecoderReader(aDecoder)
, mAudio(this, MediaData::AUDIO_DATA,
Preferences::GetUint("media.audio-max-decode-error", 3))
MediaPrefs::MaxAudioDecodeError())
, mVideo(this, MediaData::VIDEO_DATA,
Preferences::GetUint("media.video-max-decode-error", 2))
MediaPrefs::MaxVideoDecodeError())
, mDemuxer(new DemuxerProxy(aDemuxer))
, mDemuxerInitDone(false)
, mPendingNotifyDataArrived(false)

9
dom/media/MediaPrefs.h
View File

@ -165,6 +165,15 @@ private:
DECL_MEDIA_PREF("media.num-decode-threads", MediaThreadPoolDefaultCount, uint32_t, 4);
DECL_MEDIA_PREF("media.decoder.limit", MediaDecoderLimit, int32_t, MediaDecoderLimitDefault());
#if defined(RELEASE_OR_BETA)
DECL_MEDIA_PREF("media.audio-max-decode-error", MaxAudioDecodeError, uint32_t, 3);
DECL_MEDIA_PREF("media.video-max-decode-error", MaxVideoDecodeError, uint32_t, 2);
#else
// Take zero tolerance of decoding error in debug for any decoder regression.
DECL_MEDIA_PREF("media.audio-max-decode-error", MaxAudioDecodeError, uint32_t, 0);
DECL_MEDIA_PREF("media.video-max-decode-error", MaxVideoDecodeError, uint32_t, 0);
#endif
// Ogg
DECL_MEDIA_PREF("media.ogg.enabled", OggEnabled, bool, true);
// Flac

4
dom/media/mediasource/test/mediasource.js
View File

@ -1,7 +1,9 @@
// Helpers for Media Source Extensions tests
var gMSETestPrefs = [
[ "media.mediasource.enabled", true ]
[ "media.mediasource.enabled", true ],
['media.audio-max-decode-error', 0],
['media.video-max-decode-error', 0],
];
// Called before runWithMSE() to set the prefs before running MSE tests.

2
dom/media/test/manifest.js
View File

@ -1593,6 +1593,8 @@ var PARALLEL_TESTS = 2;
// conditions that might not otherwise be encountered on the test data.
var gTestPrefs = [
['media.recorder.max_memory', 1024],
['media.audio-max-decode-error', 0],
['media.video-max-decode-error', 0],
];
// When true, we'll loop forever on whatever test we run. Use this to debug