Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-12 21:05:36 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Added 1 pixel to the invalidate rect to compensate for twips to pixel rounding error. bug=63951; sr=karnaze@netscape.com; r=attinasi@netscape.com

Browse Source
This commit is contained in:
kmcclusk%netscape.com 2001-03-23 14:36:28 +00:00
parent 76db806bca
commit e6b6217eb3
2 changed files with 20 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
layout/generic/nsTextFrame.cpp
View File

@ -4630,7 +4630,16 @@ nsTextFrame::Reflow(nsIPresContext* aPresContext,
// has actually changed...
/*if (eReflowReason_Incremental == aReflowState.reason ||
eReflowReason_Dirty == aReflowState.reason) {*/
maxFrameWidth = PR_MAX(maxFrameWidth, mRect.width);
// XXX See bug 71523 We should really adjust the frames x coordinate to
// a pixel boundary to solve this.
// For now we add 1 pixel to the width of the invalidated rect.
// This fixes cases where the twips to pixel roundoff causes the invalidated
// rect's width to be one pixel short.
float p2t;
aPresContext->GetScaledPixelsToTwips(&p2t);
nscoord onePixel = NSIntPixelsToTwips(1, p2t);
maxFrameWidth = PR_MAX(maxFrameWidth, mRect.width) + onePixel;
maxFrameHeight = PR_MAX(maxFrameHeight, mRect.height);
Invalidate(aPresContext, nsRect(0,0,maxFrameWidth,maxFrameHeight));
/*}*/

11
layout/html/base/src/nsTextFrame.cpp
View File

@ -4630,7 +4630,16 @@ nsTextFrame::Reflow(nsIPresContext* aPresContext,
// has actually changed...
/*if (eReflowReason_Incremental == aReflowState.reason ||
eReflowReason_Dirty == aReflowState.reason) {*/
maxFrameWidth = PR_MAX(maxFrameWidth, mRect.width);
// XXX See bug 71523 We should really adjust the frames x coordinate to
// a pixel boundary to solve this.
// For now we add 1 pixel to the width of the invalidated rect.
// This fixes cases where the twips to pixel roundoff causes the invalidated
// rect's width to be one pixel short.
float p2t;
aPresContext->GetScaledPixelsToTwips(&p2t);
nscoord onePixel = NSIntPixelsToTwips(1, p2t);
maxFrameWidth = PR_MAX(maxFrameWidth, mRect.width) + onePixel;
maxFrameHeight = PR_MAX(maxFrameHeight, mRect.height);
Invalidate(aPresContext, nsRect(0,0,maxFrameWidth,maxFrameHeight));
/*}*/