Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-12-04 19:33:18 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

bug 824970 - nsROCSSPrimitiveValue::GetRectValue() should return nsDOMCSSRect* r=bz

Browse Source
This commit is contained in:
Trevor Saunders 2012-12-26 12:02:37 -05:00
parent fec9d2daa0
commit e6efa7865a
3 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dom/bindings/Bindings.conf
View File

@ -158,7 +158,7 @@ DOMInterfaces = {
"CSSPrimitiveValue": {
"nativeType": "nsROCSSPrimitiveValue",
"resultNotAddRefed": ["GetRGBColorValue"]
"resultNotAddRefed": ["getRGBColorValue", "getRectValue"]
},
'CSSStyleDeclaration': {

5
layout/style/nsROCSSPrimitiveValue.cpp
View File

@ -458,7 +458,7 @@ nsROCSSPrimitiveValue::GetCounterValue(ErrorResult& aRv)
return nullptr;
}
already_AddRefed<nsDOMCSSRect>
nsDOMCSSRect*
nsROCSSPrimitiveValue::GetRectValue(ErrorResult& aRv)
{
if (mType != CSS_RECT) {
@ -467,7 +467,6 @@ nsROCSSPrimitiveValue::GetRectValue(ErrorResult& aRv)
}
NS_ASSERTION(mValue.mRect, "mValue.mRect should never be null");
NS_ADDREF(mValue.mRect);
return mValue.mRect;
}
@ -475,7 +474,7 @@ NS_IMETHODIMP
nsROCSSPrimitiveValue::GetRectValue(nsIDOMRect** aRect)
{
ErrorResult error;
*aRect = GetRectValue(error).get();
NS_IF_ADDREF(*aRect = GetRectValue(error));
return error.ErrorCode();
}

2
layout/style/nsROCSSPrimitiveValue.h
View File

@ -55,7 +55,7 @@ public:
void SetStringValue(uint16_t aUnitType, const nsAString& aString,
mozilla::ErrorResult& aRv);
already_AddRefed<nsIDOMCounter> GetCounterValue(mozilla::ErrorResult& aRv);
already_AddRefed<nsDOMCSSRect> GetRectValue(mozilla::ErrorResult& aRv);
nsDOMCSSRect* GetRectValue(mozilla::ErrorResult& aRv);
nsDOMCSSRGBColor *GetRGBColorValue(mozilla::ErrorResult& aRv);
// nsROCSSPrimitiveValue