Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-24 13:21:05 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1863044 - remove unneeded variable and associated MOZ_ASSERT r=ipc-reviewers,nika

Browse Source 
`mFileDialogInstance` is not needed, since we don't reuse old file-
dialog actors. (We _do_ reuse active file-dialog utility processes as
hosts for those actors; this check is a leftover from when that was
expected not to be the case.)

Differential Revision: https://phabricator.services.mozilla.com/D192983
This commit is contained in:
Ray Kraesig 2023-11-08 17:25:57 +00:00
parent 5e55c7effe
commit e722e487bb
2 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ipc/glue/UtilityProcessChild.cpp
View File

@ -310,9 +310,6 @@ mozilla::ipc::IPCResult UtilityProcessChild::RecvStartWinFileDialogService(
"UtilityProcessChild::RecvStartWinFileDialogService", OTHER,
MarkerOptions(MarkerTiming::IntervalUntilNowFrom(mChildStartTime)));
MOZ_RELEASE_ASSERT(!mFileDialogInstance,
"attempted to double-start file dialog service");
auto instance = MakeRefPtr<widget::filedialog::WinFileDialogChild>();
if (!instance) {
return IPC_FAIL(this, "Failed to create WinFileDialogChild");
@ -323,7 +320,6 @@ mozilla::ipc::IPCResult UtilityProcessChild::RecvStartWinFileDialogService(
return IPC_FAIL(this, "Failed to bind created WinFileDialogChild");
}
mFileDialogInstance = std::move(instance);
return IPC_OK();
}

1
ipc/glue/UtilityProcessChild.h
View File

@ -100,7 +100,6 @@ class UtilityProcessChild final : public PUtilityProcessChild {
RefPtr<dom::JSOracleChild> mJSOracleInstance{};
#ifdef XP_WIN
RefPtr<PWindowsUtilsChild> mWindowsUtilsInstance;
RefPtr<PWinFileDialogChild> mFileDialogInstance;
#endif
AsyncBlockers mShutdownBlockers;