From e750a6aff2f0190e559dae2a4bfca763c7be2618 Mon Sep 17 00:00:00 2001 From: Alastor Wu Date: Wed, 11 Oct 2017 10:49:05 +0800 Subject: [PATCH] Bug 1247189 - part1 : should detach TBM after detaching it from demuxers. r=jya After detaching TBM, we should not access it anymore. So we should finish all other related detaching process, before detaching TBM. MozReview-Commit-ID: 8bNzqXVHVyy --HG-- extra : rebase_source : e135eb3d0fd4e5c41bbac4ebfc8d6fcbd1b32d5b --- dom/media/mediasource/SourceBuffer.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dom/media/mediasource/SourceBuffer.cpp b/dom/media/mediasource/SourceBuffer.cpp index cd25bfcf9f0d..09ad6daaff68 100644 --- a/dom/media/mediasource/SourceBuffer.cpp +++ b/dom/media/mediasource/SourceBuffer.cpp @@ -280,9 +280,9 @@ SourceBuffer::Detach() } AbortBufferAppend(); if (mTrackBuffersManager) { - mTrackBuffersManager->Detach(); mMediaSource->GetDecoder()->GetDemuxer()->DetachSourceBuffer( mTrackBuffersManager); + mTrackBuffersManager->Detach(); } mTrackBuffersManager = nullptr; mMediaSource = nullptr;