From e7c81e93060a5a1d71e94a8f6324eff67b774c2a Mon Sep 17 00:00:00 2001 From: David Zbarsky Date: Fri, 23 Aug 2013 13:56:20 -0400 Subject: [PATCH] Bug 905542: IsNull/SetNull functions for nullable unions should have bodyInHeader=True to prevent compiler warnings r=Ms2ger --- dom/bindings/Codegen.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/dom/bindings/Codegen.py b/dom/bindings/Codegen.py index 662e0a5e7b49..f2b14761fda7 100644 --- a/dom/bindings/Codegen.py +++ b/dom/bindings/Codegen.py @@ -6097,9 +6097,11 @@ class CGUnionStruct(CGThing): if self.type.hasNullableType: enumValues.append("eNull") methods.append(ClassMethod("IsNull", "bool", [], const=True, inline=True, - body="return mType == eNull;")) + body="return mType == eNull;", + bodyInHeader=True)) methods.append(ClassMethod("SetNull", "void", [], inline=True, - body="mType = eNull;")) + body="mType = eNull;", + bodyInHeader=True)) destructorCases.append(CGCase("eNull", None)) toJSValCases.append(CGCase("eNull", CGGeneric("rval.setNull();\n" "return true;")))