From e7fe85d170a5aa7a9f2f8bceb8eec0aca0e1be0f Mon Sep 17 00:00:00 2001 From: Richard Newman Date: Thu, 31 Dec 2015 19:32:41 -0800 Subject: [PATCH] Bug 1062537 - Pre: correct comments in android_version_code.py. --HG-- extra : commitid : Lcw6EWjP7DD --- python/mozbuild/mozbuild/android_version_code.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/python/mozbuild/mozbuild/android_version_code.py b/python/mozbuild/mozbuild/android_version_code.py index cb23538b792c..5a2b4d34d34c 100644 --- a/python/mozbuild/mozbuild/android_version_code.py +++ b/python/mozbuild/mozbuild/android_version_code.py @@ -18,12 +18,12 @@ def android_version_code_v0(buildid, cpu_arch=None, min_sdk=0, max_sdk=0): # None is interpreted as arm. if not cpu_arch or cpu_arch in ['armeabi', 'armeabi-v7a']: # Increment by MIN_SDK_VERSION -- this adds 9 to every build ID as a - # minimum. Our split APK starts at 11. + # minimum. Our split APK starts at 14. return base + min_sdk + 0 elif cpu_arch in ['x86']: # Increment the version code by 3 for x86 builds so they are offered to # x86 phones that have ARM emulators, beating the 2-point advantage that - # the v11+ ARMv7 APK has. If we change our splits in the future, we'll + # the v14+ ARMv7 APK has. If we change our splits in the future, we'll # need to do this further still. return base + min_sdk + 3 else: @@ -55,8 +55,8 @@ def android_version_code_v1(buildid, cpu_arch=None, min_sdk=0, max_sdk=0): The bit labelled 'p' is a placeholder that is always 0 (for now). - The bit labelled 'g' is 1 if the build is targeting Android API 14+ and 0 - otherwise, which means the build targets Android API 9-10 (Gingerbread). + The bit labelled 'g' is 1 if the build is an ARM build targeting API 14+ + and 0 otherwise, which means the build targets Android API 9-10 (Gingerbread). Fennec no longer supports Android API 8 or earlier. After Bug 1155801 it no longer supports API 11-13. API 9 is still supported due to significant usage.