Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-09 19:35:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1733034 - Ignore unreachable-core-return in PermissionManager.cpp. r=baku

Browse Source 
extensions/permissions/PermissionManager.cpp:2468:12: error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
    return NS_OK;
           ^~~~~

Differential Revision: https://phabricator.services.mozilla.com/D126875
This commit is contained in:
Mike Hommey 2021-09-29 21:44:53 +00:00
parent ceabf5781e
commit e80f1e4448
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
extensions/permissions/PermissionManager.cpp
View File

@ -2463,10 +2463,13 @@ nsresult PermissionManager::GetStripPermsForPrincipal(
aResult.Clear(); aResult.Clear();
aResult.SetCapacity(kStripOAPermissions.size()); aResult.SetCapacity(kStripOAPermissions.size());
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wunreachable-code-return"
// No special strip permissions // No special strip permissions
if (kStripOAPermissions.empty()) { if (kStripOAPermissions.empty()) {
return NS_OK; return NS_OK;
} }
#pragma clang diagnostic pop
nsresult rv; nsresult rv;
// Create a key for the principal, but strip any origin attributes // Create a key for the principal, but strip any origin attributes