Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-27 04:38:02 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1691578 - part1 : rename MediaPlatformDecoderNotFound to MediaFFMpegNotFound. r=bryce

Browse Source 
`MediaPlatformDecoderNotFound` sounds too general and seems indicating that this error is platform independent, but that is not true. This error is actually for not founding ffmpeg.

Differential Revision: https://phabricator.services.mozilla.com/D104471
This commit is contained in:
alwu 2021-02-25 18:07:04 +00:00
parent 18f0466bc6
commit e85012fb68
1 changed files with 9 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
dom/media/doctor/DecoderDoctorDiagnostics.cpp
View File

@ -254,7 +254,7 @@ static const NotificationAndReportStringId sMediaWMFNeeded = {
dom::DecoderDoctorNotificationType::Platform_decoder_not_found,
"MediaWMFNeeded",
{ReportParam::Formats}};
static const NotificationAndReportStringId sMediaPlatformDecoderNotFound = {
static const NotificationAndReportStringId sMediaFFMpegNotFound = {
dom::DecoderDoctorNotificationType::Platform_decoder_not_found,
"MediaPlatformDecoderNotFound",
{ReportParam::Formats}};
@ -284,15 +284,12 @@ static const NotificationAndReportStringId sMediaDecodeWarning = {
{ReportParam::ResourceURL, ReportParam::DecodeIssue}};
static const NotificationAndReportStringId* const
sAllNotificationsAndReportStringIds[] = {&sMediaWidevineNoWMF,
&sMediaWMFNeeded,
&sMediaPlatformDecoderNotFound,
&sMediaCannotPlayNoDecoders,
&sMediaNoDecoders,
&sCannotInitializePulseAudio,
&sUnsupportedLibavcodec,
&sMediaDecodeError,
&sMediaDecodeWarning};
sAllNotificationsAndReportStringIds[] = {
&sMediaWidevineNoWMF, &sMediaWMFNeeded,
&sMediaFFMpegNotFound, &sMediaCannotPlayNoDecoders,
&sMediaNoDecoders, &sCannotInitializePulseAudio,
&sUnsupportedLibavcodec, &sMediaDecodeError,
&sMediaDecodeWarning};
// Create a webcompat-friendly description of a MediaResult.
static nsString MediaResultDescription(const MediaResult& aResult,
@ -694,12 +691,11 @@ void DecoderDoctorDocumentWatcher::SynthesizeAnalysis() {
DD_INFO(
"DecoderDoctorDocumentWatcher[%p, "
"doc=%p]::SynthesizeAnalysis() - unplayable formats: %s -> "
"Cannot play media because platform decoder was not found "
"(Reason: %s)",
"Cannot play media because ffmpeg was not found (Reason: %s)",
this, mDocument,
NS_ConvertUTF16toUTF8(formatsRequiringFFMpeg).get(),
FFmpegRuntimeLinker::LinkStatusString());
ReportAnalysis(mDocument, sMediaPlatformDecoderNotFound, false,
ReportAnalysis(mDocument, sMediaFFMpegNotFound, false,
formatsRequiringFFMpeg);
return;
}